Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b8pnY-0006ZJ-7c for pgadmin-hackers@arkaria.postgresql.org; Fri, 03 Jun 2016 14:10:04 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1b8pnX-00035R-CC for pgadmin-hackers@arkaria.postgresql.org; Fri, 03 Jun 2016 14:10:03 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1b8pnK-0002ql-03 for pgadmin-hackers@postgresql.org; Fri, 03 Jun 2016 14:09:50 +0000 Received: from mail-it0-x22a.google.com ([2607:f8b0:4001:c0b::22a]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1b8pnB-0007Pi-Iy for pgadmin-hackers@postgresql.org; Fri, 03 Jun 2016 14:09:48 +0000 Received: by mail-it0-x22a.google.com with SMTP id z123so80914656itg.0 for ; Fri, 03 Jun 2016 07:09:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=enNHOI2tOFGz2kOI30XDPc1bAiIa0MdWxnQ3ml0UeD8=; b=MZSYxD6iaI+JK2bVRx+ZYwGK5tXjMUChyga1saNuqEDnIo/oNjhKBSxHPMGEJhoycA isC1vQufCbZ+3aktUq7uf6ehRQyT4DlByvlrcn6QjDAuYwFQX0/kOm2VtqSYQ7pdcFGs /7l6lJpl9igfJxFF5uestiW4CJSuBo/wgftTG7ELa+I6FiqjzYb0mMajBlMxu8HU7avI XD9+MBtDDk3yYeN9aD9RFfzFYiDUs8PeqjwFB+Uke83TsvJqBUn2MtWpSY/i8aHsu6nd ZNq4+gC76U4Cr1UJgGLj83mud7Kuj+vEQxk7vvh+fgzjKyrLIRzj+evciJo1LqoIQdFX OpFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=enNHOI2tOFGz2kOI30XDPc1bAiIa0MdWxnQ3ml0UeD8=; b=E3LdavULLJR4BY0NoDI0YW7Ywm4VAa66KdDjBjGelPFGIVrsrnxGyqLw6kj4akkRFK 1CVeSXiO9th8UFopeUJcr7ujPRxmw7m3HgRE3iIR7Q4PM7BBGa+FwPFcyjCC1H5K41xz LnUZ5m6DWLOPBRMyU5CaMedhh6ElmDWGaAqZ0d0vBZI+mtxdNqhYgGPooGQScFyZoWWX oQb2SnxeWNOUCdUiWA2YORbKg1BkFre30K2gz0YPPfCzO266GuOZ7sQP3kYN21UjVCVQ qcaWwbIkWkjwkZPxTD4MC2ey2YiSMNWGGS33L2YjKc8vaMgnn5sxm+UGmMkKF9x8wtcF fhEA== X-Gm-Message-State: ALyK8tI+Ivd77DJmQj7Tt5ytqU8xRALaOjUFLFZtJqnIQl+8aLKeaDBLRrw9QBDqo2leoO41wce6LMjh0OmDtQ== X-Received: by 10.36.116.17 with SMTP id o17mr9815724itc.35.1464962980298; Fri, 03 Jun 2016 07:09:40 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.236.101 with HTTP; Fri, 3 Jun 2016 07:09:39 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Fri, 3 Jun 2016 15:09:39 +0100 Message-ID: Subject: Re: Patch for pgAdmin4 RPM package To: Sandeep Thakkar Cc: pgadmin-hackers , Hamid Quddus , =?UTF-8?B?RGV2cmltIEfDnE5Ew5xa?= Content-Type: multipart/alternative; boundary=94eb2c0925280ce63d05346046bb X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --94eb2c0925280ce63d05346046bb Content-Type: text/plain; charset=UTF-8 Hi, Well, I have to wonder why we need the changes to the runtime? We're linking the runtime with the same build of Python that's already on the system - doesn't it know where it's site-packages are already? I could see us needing this is we were using a distro-independent build of Python and wanted to find the OS site-packages location, but we're not. On Fri, Jun 3, 2016 at 10:15 AM, Sandeep Thakkar < sandeep.thakkar@enterprisedb.com> wrote: > Hi Dave, > > how about changes in the pgadmin4 source code for conf.py and Server.cpp? > Looks okay? > > On Fri, Jun 3, 2016 at 2:41 PM, Sandeep Thakkar < > sandeep.thakkar@enterprisedb.com> wrote: > >> Thanks Dave. >> >> On Fri, Jun 3, 2016 at 2:08 PM, Dave Page wrote: >> >>> Hi >>> >>> On Thu, Jun 2, 2016 at 4:23 PM, Sandeep Thakkar >>> wrote: >>> > Hi Devrim, Hi Dave, >>> > >>> > I have updated the patch. The earlier patch may fail because of app >>> bundle >>> > commit in git. >>> > >>> > For testing, you may define the source tarball location as : >>> > Source0: >>> > >>> http://bugatti.pn.in.enterprisedb.com/temp/pgadmin4/%{name}-v%{version}.tar.gz >>> > >>> > Known issue that I'm still working on: >>> > 1. web rpm has a dependency on doc. But, even if I install doc, the web >>> > still complains. Here is the scenario: >>> > [root@localhost tmp]# rpm -ivh >>> > dist/noarch/pgadmin4-web-1.0_dev-1.rhel7.noarch.rpm >>> > error: Failed dependencies: >>> > pgadmin4-doc = 1.0_dev is needed by pgadmin4-web-1.0_dev-1.rhel7.noarch >>> > ... ( trimmed the python dependencies list here...) >>> > >>> > [root@localhost tmp]# rpm -ivh >>> > dist/noarch/pgadmin4-docs-1.0_dev-1.rhel7.noarch.rpm >>> > Preparing... ################################# >>> > [100%] >>> > Updating / installing... >>> > 1:pgadmin4-docs-1.0_dev-1.rhel7 ################################# >>> > [100%] >>> > >>> > >>> > [root@localhost tmp]# yum list | grep pgadmin4-docs >>> > pgadmin4-docs.noarch 1.0_dev-1.rhel7 >>> > installed >>> > >>> > >>> > [root@localhost tmp]# rpm -ivh >>> > dist/noarch/pgadmin4-web-1.0_dev-1.rhel7.noarch.rpm >>> > error: Failed dependencies: >>> > pgadmin4-doc = 1.0_dev is needed by pgadmin4-web-1.0_dev-1.rhel7.noarch >>> >>> You have a typo - the Requires line is for pgadmin4-doc, but the RPM >>> is pgadmin4-docs. >>> >>> Oh, right. >> >> >>> Other review comments: >>> >>> - We have multiple identical pgadmin4.spec.in's in the patch. We need >>> to get that down to a single file. >>> >>> - In fact, why do we need a directory for each distro at all? As far >>> as I can see, the only difference is the $DIST definition, which is >>> surely something we can get programmatically very easily. It seems to >>> me we could reduce this all to 3 files - Makefile, README and >>> pgadmin4.spec.in >>> >>> Agree. I copied the structure from somewhere thinking this is good to >> have more OS specific changes. >> >> >>> - make rpm has a dependency on make prep. This has 2 issues as far as I >>> can see: >>> >>> - It does a git pull, which is bad. If I'm making an RPM from within >>> the source tree, I want it for the current source. The git pull only >>> makes sense for external builds, i.e. in a much larger automated build >>> system. >>> >>> - It goes and grabs the source code and patches from the FTP site. >>> Again, this is not what I want for an "in-tree" build. I want to use >>> the source code as I have it now. >>> >>> Okay. got it. Will remove downloading the tarballs and build the cloned >> source. >> >> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> >> >> -- >> Sandeep Thakkar >> >> > > > -- > Sandeep Thakkar > Lead Software Engineer > > > Phone: +91.20.30589505 > > Website: www.enterprisedb.com > EnterpriseDB Blog: http://blogs.enterprisedb.com/ > Follow us on Twitter: http://www.twitter.com/enterprisedb > > This e-mail message (and any attachment) is intended for the use of the > individual or entity to whom it is addressed. This message contains > information from EnterpriseDB Corporation that may be privileged, > confidential, or exempt from disclosure under applicable law. If you are > not the intended recipient or authorized to receive this for the intended > recipient, any use, dissemination, distribution, retention, archiving, or > copying of this communication is strictly prohibited. If you have received > this e-mail in error, please notify the sender immediately by reply e-mail > and delete this message. > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --94eb2c0925280ce63d05346046bb Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,

Well, I have to wonder why we need = the changes to the runtime? We're linking the runtime with the same bui= ld of Python that's already on the system - doesn't it know where i= t's site-packages are already? I could see us needing this is we were u= sing a distro-independent build of Python and wanted to find the OS site-pa= ckages location, but we're not.


On Fri, Jun 3, 2016 at 10:15 AM= , Sandeep Thakkar <sandeep.thakkar@enterprisedb.com>= wrote:
Hi Dave,= =C2=A0

how about changes in the pgadmin4 source code for= conf.py and Server.cpp? Looks okay?
=

On Fri, Jun 3, 2016 a= t 2:41 PM, Sandeep Thakkar <sandeep.thakkar@enterprisedb.co= m> wrote:
= Thanks Dave.=C2=A0

On Fri, Jun 3, 2016 at 2:08 PM, Dave Page = <dpage@pgadmin.or= g> wrote:
Hi

On Thu, Jun 2, 2016 at 4:23 PM, Sandeep Thakkar
<s= andeep.thakkar@enterprisedb.com> wrote:
> Hi Devrim, Hi Dave,
>
> I have updated the patch. The earlier patch may fail because of app bu= ndle
> commit in git.
>
> For testing, you may define the source tarball location as :
> Source0:
> http://bu= gatti.pn.in.enterprisedb.com/temp/pgadmin4/%{name}-v%{version}.tar.gz >
> Known issue that I'm still working on:
> 1. web rpm has a dependency on doc. But, even if I install doc, the we= b
> still complains. Here is the scenario:
> [root@localhost tmp]# rpm -ivh
> dist/noarch/pgadmin4-web-1.0_dev-1.rhel7.noarch.rpm
> error: Failed dependencies:
> pgadmin4-doc =3D 1.0_dev is needed by pgadmin4-web-1.0_dev-1.rhel7.noa= rch
> ... ( trimmed the python dependencies list here...)
>
> [root@localhost tmp]# rpm -ivh
> dist/noarch/pgadmin4-docs-1.0_dev-1.rhel7.noarch.rpm
> Preparing...=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 #################################
> [100%]
> Updating / installing...
>=C2=A0 =C2=A0 1:pgadmin4-docs-1.0_dev-1.rhel7=C2=A0 =C2=A0 ############= #####################
> [100%]
>
>
> [root@localhost tmp]# yum list | grep pgadmin4-docs
> pgadmin4-docs.noarch=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 1.0_dev-1.rhel7
> installed
>
>
> [root@localhost tmp]# rpm -ivh
> dist/noarch/pgadmin4-web-1.0_dev-1.rhel7.noarch.rpm
> error: Failed dependencies:
> pgadmin4-doc =3D 1.0_dev is needed by pgadmin4-web-1.0_dev-1.rhel7.noa= rch

You have a typo - the Requires line is for pgadmin4-doc, but th= e RPM
is pgadmin4-docs.

Oh, right.
=C2=A0
Other review comments:

- We have multiple identical pgadmin4.spec.in's in the patch. We need=
to get that down to a single file.

- In fact, why do we need a directory for each distro at all? As far
as I can see, the only difference is the $DIST definition, which is
surely something we can get programmatically very easily. It seems to
me we could reduce this all to 3 files - Makefile, README and
pg= admin4.spec.in

Agree. I copied the structure from somewhere t= hinking this is good to have more OS specific changes.
=C2= =A0
- make rpm has a dependency on make prep. This has 2 issues as far as I can= see:

=C2=A0 - It does a git pull, which is bad. If I'm making an RPM from wi= thin
the source tree, I want it for the current source. The git pull only
makes sense for external builds, i.e. in a much larger automated build
system.

=C2=A0 - It goes and grabs the source code and patches from the FTP site. Again, this is not what I want for an "in-tree" build. I want to = use
the source code as I have it now.

Okay. got it. Will remov= e downloading the tarballs and build the cloned source.
=C2= =A0
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Sandeep Thakkar




--
<= div>
Sandeep Thakkar
Lead Software Engineer
<= img src=3D"http://www.enterprisedb.com/sites/default/files/EDB-logo-4c.png"= width=3D"96" height=3D"54">

Phone: +91.20.30589505

Webs= ite: www.enterpri= sedb.com
EnterpriseDB Blog: http://blogs.enterprisedb.com/
Follow us on Twi= tter: htt= p://www.twitter.com/enterprisedb

This e-mail message (and any at= tachment) is intended for the use of the individual or entity to whom it is= addressed. This message contains information from EnterpriseDB Corporation= that may be privileged, confidential, or exempt from disclosure under appl= icable law. If you are not the intended recipient or authorized to receive = this for the intended recipient, any use, dissemination, distribution, rete= ntion, archiving, or copying of this communication is strictly prohibited. = If you have received this e-mail in error, please notify the sender immedia= tely by reply e-mail and delete this message.



--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--94eb2c0925280ce63d05346046bb--