Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hgVQO-0005GG-73 for pgadmin-hackers@arkaria.postgresql.org; Thu, 27 Jun 2019 14:30:56 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hgVQN-0002R5-0w for pgadmin-hackers@arkaria.postgresql.org; Thu, 27 Jun 2019 14:30:55 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hgVQM-0002Qy-PF for pgadmin-hackers@lists.postgresql.org; Thu, 27 Jun 2019 14:30:54 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hgVQK-0005Hg-4Q for pgadmin-hackers@postgresql.org; Thu, 27 Jun 2019 14:30:54 +0000 Received: by mail-wm1-x344.google.com with SMTP id v19so5909580wmj.5 for ; Thu, 27 Jun 2019 07:30:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=O1JtoMUn15TlNX6YLg9N0FaosJHlaE8/VxtuIIOuorQ=; b=P91y4h4GlWg4gkF1VZeRc0oIgm5kKukpqIvaOLpNAjxZlka8mKH6qzFMXlps86TiBl Q8RqwEX9LCLInWnIVhobQsXoi+EZlN9v1F63GCRxhoMUZ6PCdPzVUHys19Hl1cpj1TXV Q2RvHeGaM8udio5KXr6x42LNZoZ0OYba5cwtuMgOfehYQ0g7PI+aat6sqfdODf26/0iU CVMkMKP1YiYpSBpAkp9KJ2Gt4j/flDiGcKYyl/mvq+t+yxT7NkqZy8D8FQBxxrZNMSAM 61OhrGV0Oo2hNos/u+y8QwVPBWhXQlir3/8Uxp7UlymR5/mMqoutEAYfNKeA2TDchf3p RCxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=O1JtoMUn15TlNX6YLg9N0FaosJHlaE8/VxtuIIOuorQ=; b=nxlnrw5NujiUVUJVNFup3Hl+aV7FzRRQjNY4V2fAsXAhxzJCtSPDDXNdgXT3a9PpAQ LRAt+Q6aa8dzQksOoLxQJtYHwaJRhBWPzQCiPDqYSmZpeE89ZvdCZDCAMoN/xwSrcOjA 2ktLR7iJ3/w8Vs/wS/fVFWHrAUxHzyPGLIPhYPtn6ryDVOKcbT8uUvOyKW2hsCA4ue2a P51QVilFfCQImXRw7XYLdTqglN/+izW4t6FnLtScExKyQqAgX9384S4zVYGv/tXmgeZ7 wkOtcGpdNxeXeymNkQi+LUTszMyG+mqRUBqwlSZPWXiju/E94bZTOJ6PDHc3CBY0XkAR GLBQ== X-Gm-Message-State: APjAAAWckUVlR5rrV0ujVTgVO1O7uQ9DD+zHyhHXAc+qkG69rH2jov9C PywMqTmi98pHGICgBoWNWZjXmiR8hRsT1i5QG5kPZQ== X-Google-Smtp-Source: APXvYqyKjlMC396GeVgTKCWNvcxgkt/3CFGF1oUWnkuEOeRVWuZHaPoQ88qh4RhDUg0VyUPtPZwBSWW3212iTgJPVTA= X-Received: by 2002:a1c:f018:: with SMTP id a24mr3352074wmb.66.1561645851145; Thu, 27 Jun 2019 07:30:51 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Thu, 27 Jun 2019 10:30:39 -0400 Message-ID: Subject: Re: [pgAdmin][RM4139] Drag and drop object names in Query Editor from Browser Tree To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000039036a058c4f0293" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000039036a058c4f0293 Content-Type: text/plain; charset="UTF-8" Thanks, applied. On Thu, Jun 27, 2019 at 6:32 AM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the updated patch based on the review comments in > trailing mail. > Kindly review. > > On Wed, Jun 26, 2019 at 5:09 PM Dave Page wrote: > >> >> >> On Wed, Jun 26, 2019 at 7:38 AM Aditya Toshniwal < >> aditya.toshniwal@enterprisedb.com> wrote: >> >>> Hi, >>> >>> On Wed, Jun 26, 2019 at 5:06 PM Dave Page wrote: >>> >>>> >>>> >>>> On Wed, Jun 26, 2019 at 7:28 AM Aditya Toshniwal < >>>> aditya.toshniwal@enterprisedb.com> wrote: >>>> >>>>> Hi, >>>>> >>>>> On Wed, Jun 26, 2019 at 4:51 PM Dave Page wrote: >>>>> >>>>>> Hi >>>>>> >>>>>> On Wed, Jun 26, 2019 at 2:24 AM Aditya Toshniwal < >>>>>> aditya.toshniwal@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi Hackers, >>>>>>> >>>>>>> Attached is the patch to allow tree nodes to be dragged and dropped >>>>>>> in query editor wherever you take the drop cursor. The drop text will be >>>>>>> fully qualified and double quoted if required. >>>>>>> For functions/procedures it will drop the the label stripping away >>>>>>> the parameter names, with empty pair of round brackets. It will also set >>>>>>> the focus cursor inside the brackets if there were params otherwiser to the >>>>>>> end of text. >>>>>>> For adding a node type, you need to register it in browser.js along >>>>>>> with a callback function which will return drop text along with cursor >>>>>>> positioning and selection. Currently, I have registered for "table >>>>>>> partition type sequence package view mview foreign_table edbvar schema >>>>>>> column edbfunc function edbproc procedure". >>>>>>> >>>>>>> Please note, the drag design customisation is not supported in IE. >>>>>>> >>>>>> >>>>>> I think for functions/procedures, we should include placeholders for >>>>>> the parameters, so the user has a hint about what they need to fill in to >>>>>> complete the call. >>>>>> >>>>> I can fill in the parameter names same as tree node, with cursor >>>>> selection on all the params ? >>>>> >>>> >>>> Can you select the first one, and put the cursor in front of it? >>>> >>> Yes. Will do that. So that, just after drop if the user types anything >>> it will replace the first param name. >>> >> >> Right. >> >> >>> >>>> >>>>> >>>>>> Also; shouldn't there be a doc update? >>>>>> >>>>> Yeah :/ >>>>> Should there be any screenshots ? >>>>> >>>> >>>> I don't see much need. >>>> >>> Cool. >>> >> >> :-) >> >> >>> >>>> Thanks. >>>> >>>> >>>>> >>>>>> Thanks. >>>>>> >>>>>> -- >>>>>> Dave Page >>>>>> Blog: http://pgsnake.blogspot.com >>>>>> Twitter: @pgsnake >>>>>> >>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>> >>>>> >>>>> -- >>>>> Thanks and Regards, >>>>> Aditya Toshniwal >>>>> Software Engineer | EnterpriseDB India | Pune >>>>> "Don't Complain about Heat, Plant a TREE" >>>>> >>>> >>>> >>>> -- >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EnterpriseDB UK: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>> >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> Software Engineer | EnterpriseDB India | Pune >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --00000000000039036a058c4f0293 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, applied.

On Thu, Jun 27, 2019 at 6:32 AM Aditya Tos= hniwal <aditya.tosh= niwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the update= d patch based on the review comments in trailing=C2=A0mail.
Kindly review.<= /div>

On Wed, Jun 26, 2019 at 5:09 PM Dave Page <dpage@pgadmin.org> wrote:


On Wed, Jun 26, 2019 at 7:38 AM Aditya Toshniwal <aditya.tosh= niwal@enterprisedb.com> wrote:
Hi,

On Wed, Jun 26, 2019 at 5:06 PM Dave Pa= ge <dpage@pgadmin= .org> wrote:


On Wed, Jun 26, 2019 at 7:28 AM A= ditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft:1px solid rgb(204,204,204);padding-left:1ex">
Hi,

<= div class=3D"gmail_quote">
On Wed, Jun= 26, 2019 at 4:51 PM Dave Page <dpage@pgadmin.org> wrote:
Hi

On Wed, Jun 26, 20= 19 at 2:24 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wr= ote:
Hi Hackers,

Attached is the patch to allow tree nodes to be dragge= d and dropped in query editor wherever you take the drop cursor. The drop t= ext will be fully qualified and double quoted if required.
For functions/procedures it will drop t= he the label stripping away the parameter names, with empty pair of round b= rackets. It will also set the focus cursor inside the brackets if there wer= e params otherwiser to the end of text.
For adding a node type, you need to register it in br= owser.js along with a callback function which will return drop text along w= ith cursor positioning and selection. Currently, I have=C2=A0registered for "table partition type seque= nce package view mview foreign_table edbvar schema column edbfunc function = edbproc procedure".
Please note, the= drag design customisation is not supported in IE.

I think for functions/procedures, we should incl= ude placeholders for the parameters, so the user has a hint about what they= need to fill in to complete the call.
<= span class=3D"gmail_default" style=3D"font-family:verdana,sans-serif">I can= fill in the parameter names same as tree node, with cursor selection on al= l the params ?

Can= you select the first one, and put the cursor in front of it?
Yes. Will do that. So that, just after drop if the user t= ypes anything it will replace the first param name.

Right.
=C2=A0
<= div class=3D"gmail_quote">
=C2=A0

Also; shouldn't there be a doc update?
<= /div>
Yeah :/
Should there be any screensho= ts ?=C2=A0

I don&#= 39;t see much need.
Cool.=C2=A0
=

:-)
=C2=A0

Thanks.
= =C2=A0

Thank= s.
=C2=A0
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company<= br>


--
= Thanks and = Regards,
Aditya Toshniwal=
Softw= are Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain about Heat, Pl= ant a TREE"


--
Dave Page
B= log: http://pgsna= ke.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com=
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Com= plain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

Enterpr= iseDB UK: http://= www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0EnterpriseDB I= ndia |=C2=A0Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @p= gsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL = Company
--00000000000039036a058c4f0293--