public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Harshal Dhumal <[email protected]>
Cc: Joao Pedro De Almeida Pereira <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: RM3079 fix for wrong sql datetime/time related datatypes
Date: Fri, 2 Mar 2018 11:52:02 +0000
Message-ID: <CA+OCxozOK8+6-a1RwjZoQ2MtL-GqLFpUukTWa8FG0Twz8Eoj_A@mail.gmail.com> (raw)
In-Reply-To: <CAFiP3vwa=qH0e5bSP+Gk66HDRJK8AdO4N9u23Y-o4HRfr+9UPw@mail.gmail.com>
References: <CAFiP3vzmHJfQhsmH6pNgDTyGXfYDBCznwxidTbFJsbnfA9X5Tg@mail.gmail.com>
<CA+OCxoz5=7Vo7VpsKPO4J4BZeJQQeiQ-pv8uK5WuVKvpM-Cefg@mail.gmail.com>
<CAFiP3vxELyjKv3LRoLP66g_FPGA_ajdSA6Rai-vZmgUJwpCfrA@mail.gmail.com>
<CAE+jjamv2BCcpqnHCmEJRg47HMF-REkvvnV3pR4XdSKpwM-8Dw@mail.gmail.com>
<CAFiP3vwa=qH0e5bSP+Gk66HDRJK8AdO4N9u23Y-o4HRfr+9UPw@mail.gmail.com>
Thanks, applied.
On Wed, Feb 28, 2018 at 3:00 PM, Harshal Dhumal <
[email protected]> wrote:
> Great, thanks!
>
> On Feb 28, 2018 8:15 PM, "Joao De Almeida Pereira" <
> [email protected]> wrote:
>
>> Hello Harshal,
>>
>> I tried the example you showed and it works. Also passed the patch
>> through our CI Pipeline and everything is good.
>>
>> Thanks
>> Joao
>>
>> On Wed, Feb 28, 2018 at 6:25 AM Harshal Dhumal <
>> [email protected]> wrote:
>>
>>> Hi,
>>>
>>> On Tue, Feb 27, 2018 at 8:54 PM, Dave Page <[email protected]> wrote:
>>>
>>>> Hi
>>>>
>>>> On Tue, Feb 27, 2018 at 2:36 PM, Harshal Dhumal <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> Please find patch to fix wrong sql issue for time related type.
>>>>>
>>>>> Steps to reproduce:
>>>>>
>>>>> Alter any time/datetime array related data type, it generates sql with
>>>>> addition array bracket
>>>>>
>>>>> [image: Inline image 1]
>>>>>
>>>>
>>>> This seems to be missing the test case that you noted should be
>>>> included in the original bug report!
>>>>
>>>
>>> Please find updated patch with test cases.
>>>
>>>
>>> Thanks,
>>>
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachments:
[image/png] Screen Shot 2018-02-27 at 8.05.47 pm.png (42.0K, 3-Screen%20Shot%202018-02-27%20at%208.05.47%20pm.png)
download | view image
view thread (6+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: RM3079 fix for wrong sql datetime/time related datatypes
In-Reply-To: <CA+OCxozOK8+6-a1RwjZoQ2MtL-GqLFpUukTWa8FG0Twz8Eoj_A@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox