MIME-Version: 1.0
In-Reply-To: 
 <CAHowoHYZxBvHUNDVmYc0nO2vcSc7AG4w+HVrs2s-h5h_-oSKPg@mail.gmail.com>
References: 
 <CAHowoHbaKvtMXqDjFT_xQjqo3FFhVYb_nV1v1NR=HT0U+hTPmg@mail.gmail.com>
 <CA+OCxoysm1Fw3axLN75Qy7d=1tFxMrQ142kREVLFTTOqqcmmTw@mail.gmail.com>
 <CAHowoHY+9h_=wpkGS3DUhey9ua+OVee6X+4OmifMH9cU6KiCug@mail.gmail.com>
 <CA+OCxowafvQt7Cp1O=XSHt34Hr0bCjDCy4bnLdO5WPCXE=H9hw@mail.gmail.com>
 <CAAtBm9X4vaL5Ni3axtn-oxmZ3LDN5M8oNgDWZC9uf5dADs9wkw@mail.gmail.com>
 <CAHowoHYZxBvHUNDVmYc0nO2vcSc7AG4w+HVrs2s-h5h_-oSKPg@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Fri, 13 Jan 2017 11:18:42 +0530
Message-ID: 
 <CA+OCxozQ+HTa0Cinb+Ka6t5OwWPUVQvsMnJvtOgr-_HoR5OL3g@mail.gmail.com>
Subject: Re: Driver Module
To: George Gelashvili <ggelashvili@pivotal.io>
Cc: Robert Eckhardt <reckhardt@pivotal.io>,
	"pgadmin-hackers@postgresql.org" <pgadmin-hackers@postgresql.org>,
	"plumadmin@pivotal.io" <plumadmin@pivotal.io>,
 Ashesh Vashi <ashesh.vashi@enterprisedb.com>
Content-Type: text/plain; charset=UTF-8
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

Hi

On Thu, Jan 12, 2017 at 8:18 PM, George Gelashvili
<ggelashvili@pivotal.io> wrote:
> Hi Dave,
>
> We looked through the places where there is existing version checking and
> there isn't a ton of it.

That's because we went to great lengths to minimise it in pgAdmin 4.
It's mostly confined to template selection for SQL now.

> Our current plan for supporting Greenplum in
> pgAdmin4 was not necessarily to support all the features of pgAdmin4, but to
> at least get the core functionality working.
> I'm not too concerned about there being a ton of switches, because I don't
> think most features will need to be disabled. We will also likely make
> changes to Greenplum to support certain features like query plans rather
> than doing all the changes on the pgAdmin4 side.

OK. From my perspective though, I have to ensure that what we offer in
the community is a good experience. If it's not appropriate or
necessary to support a feature in GP, that's fine - but it needs to be
disabled to prevent users reporting bugs to us

> What I would like to see though is version checking that happens in one
> place and is not tied exclusively to either flavor or version, but to a
> combination of the two. E.g. Greenplum 5.0 might support a feature that is
> not supported in 8.3 postgres.

Can you do a rough assessment of how many 'features' we'd be likely to
need to have the PG driver advertise? That would give a better idea of
the extent of the work involved.

In principal I'm not against the idea of having a function in each
driver that allows us to check for the presence of a given feature,
including by-version as required. What I'm against is that becoming a
mess of spaghetti...

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers