MIME-Version: 1.0
From: Dave Page <dpage@pgadmin.org>
Date: Wed, 30 Jun 2021 11:05:19 +0100
Message-ID: 
 <CA+OCxozRoYYgSp+BRrovk31uzn4sB0JCL6ztcgaOjpx6qnfbqA@mail.gmail.com>
Subject: RM 6427 - Newlines in text columns of resultset show an allegedly
 "empty" field
To: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Cc: Nikhil Mohite <nikhil.mohite@enterprisedb.com>
Content-Type: multipart/mixed; boundary="000000000000cf19f205c5f8dcc7"
Archived-At: 
 <https://www.postgresql.org/message-id/CA%2BOCxozRoYYgSp%2BBRrovk31uzn4sB0JCL6ztcgaOjpx6qnfbqA%40mail.gmail.com>
Precedence: bulk

--000000000000cf19f205c5f8dcc7
Content-Type: multipart/alternative; boundary="000000000000cf19ee05c5f8dcc5"

--000000000000cf19ee05c5f8dcc5
Content-Type: text/plain; charset="UTF-8"

Here's a simple patch for $SUBJECT. It will remove any leading spaces from
the grid cell display and replace them with '[...] '. In edit mode, the
data is unchanged.

The only downside I can see to this is that the tooltip will show the
modified data when it probably should actually show the un-modified data.
Unfortunately that's handled by a SlickGrid plugin, which would have to be
vendorised and modified (perhaps non-trivially). I don't think that's a big
issue though.

-- 
Dave Page
Blog: https://pgsnake.blogspot.com
Twitter: @pgsnake

EDB: https://www.enterprisedb.com

--000000000000cf19ee05c5f8dcc5
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Here&#39;s a simple patch for $SUBJECT. It will remove any=
 leading spaces from the grid cell display and replace them with &#39;[...]=
 &#39;. In edit mode, the data is unchanged.<div><br></div><div>The only do=
wnside I can see to this is that the tooltip will show the modified data wh=
en it probably should actually show the un-modified data. Unfortunately tha=
t&#39;s handled by a SlickGrid plugin, which would have to be vendorised an=
d modified (perhaps non-trivially). I don&#39;t think that&#39;s a big issu=
e though.<br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr" class=3D"=
gmail_signature" data-smartmail=3D"gmail_signature"><div dir=3D"ltr">Dave P=
age<br>Blog: <a href=3D"https://pgsnake.blogspot.com" target=3D"_blank">htt=
ps://pgsnake.blogspot.com</a><br>Twitter: @pgsnake<br><br>EDB: <a href=3D"h=
ttps://www.enterprisedb.com" target=3D"_blank">https://www.enterprisedb.com=
</a><br><br></div></div></div></div>

--000000000000cf19ee05c5f8dcc5--

--000000000000cf19f205c5f8dcc7
Content-Type: application/octet-stream; name="RM_6427.diff"
Content-Disposition: attachment; filename="RM_6427.diff"
Content-Transfer-Encoding: base64
Content-ID: <f_kqjb9zge0>
X-Attachment-Id: f_kqjb9zge0

ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3N0YXRpYy9qcy9zbGlja2dyaWQvZm9ybWF0dGVycy5q
cyBiL3dlYi9wZ2FkbWluL3N0YXRpYy9qcy9zbGlja2dyaWQvZm9ybWF0dGVycy5qcwppbmRleCA3
YzliMmEyMWIuLjIxNTljOWRkYSAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vc3RhdGljL2pzL3Ns
aWNrZ3JpZC9mb3JtYXR0ZXJzLmpzCisrKyBiL3dlYi9wZ2FkbWluL3N0YXRpYy9qcy9zbGlja2dy
aWQvZm9ybWF0dGVycy5qcwpAQCAtMTAzLDEyICsxMDMsMjEgQEAKIAogICBmdW5jdGlvbiBUZXh0
Rm9ybWF0dGVyKHJvdywgY2VsbCwgdmFsdWUsIGNvbHVtbkRlZikgewogICAgIC8vIElmIGNvbHVt
biBoYXMgZGVmYXVsdCB2YWx1ZSwgc2V0IHBsYWNlaG9sZGVyCi0gICAgdmFyIGRhdGEgPSBOdWxs
QW5kRGVmYXVsdEZvcm1hdHRlcihyb3csIGNlbGwsIHZhbHVlLCBjb2x1bW5EZWYpOwotICAgIGlm
IChkYXRhKSB7Ci0gICAgICByZXR1cm4gZGF0YTsKKyAgICB2YXIgcmF3ID0gTnVsbEFuZERlZmF1
bHRGb3JtYXR0ZXIocm93LCBjZWxsLCB2YWx1ZSwgY29sdW1uRGVmKTsKKworICAgIHZhciBkYXRh
OworICAgIGlmIChyYXcpIHsKKyAgICAgIGRhdGEgPSByYXc7CiAgICAgfSBlbHNlIHsKLSAgICAg
IHJldHVybiBfLmVzY2FwZSh2YWx1ZSk7CisgICAgICBkYXRhID0gXy5lc2NhcGUodmFsdWUpOwog
ICAgIH0KKworICAgIC8vIFJlcGxhY2UgbGVhZGluZyB3aGl0ZXNwYWNlIHdpdGggYSBtYXJrZXIg
c28gd2UgZG9uJ3QganVzdCBzaG93IGJsYW5rIGxpbmVzCisgICAgaWYgKGRhdGEudHJpbVN0YXJ0
KCkgIT0gZGF0YSkgeworICAgICAgZGF0YSA9ICdbLi4uXSAnICsgZGF0YS50cmltU3RhcnQoKTsK
KyAgICB9CisKKyAgICByZXR1cm4gZGF0YTsKICAgfQogCiAgIGZ1bmN0aW9uIEJpbmFyeUZvcm1h
dHRlcihyb3csIGNlbGwsIHZhbHVlLCBjb2x1bW5EZWYpIHsK
--000000000000cf19f205c5f8dcc7--