Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1haJyQ-0003Ys-24 for pgadmin-hackers@arkaria.postgresql.org; Mon, 10 Jun 2019 13:04:30 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1haJyN-00024a-LN for pgadmin-hackers@arkaria.postgresql.org; Mon, 10 Jun 2019 13:04:27 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1haJyN-0001pv-09 for pgadmin-hackers@lists.postgresql.org; Mon, 10 Jun 2019 13:04:27 +0000 Received: from mail-it1-x142.google.com ([2607:f8b0:4864:20::142]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1haJyJ-0005yS-O4 for pgadmin-hackers@postgresql.org; Mon, 10 Jun 2019 13:04:25 +0000 Received: by mail-it1-x142.google.com with SMTP id e25so6747552itk.3 for ; Mon, 10 Jun 2019 06:04:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KZ2m+yHE+ZF4pMVBkPue5Bwsco6N7b6uFaY99iuPD4w=; b=NQAjFEwVOinlojwvdFFYVsh/xa1+4s4+SMVL66qZdmd2cOJZQqJF5j6vGOYTpDkP9i OtCF0d+MqbkzHvBRbexUyTx3uQCkmQoZax+CaG6vSNRiAI6JjU23Fnq2II5FK4QxMIZK dazXpH4mLKm8A3s0OosV2bmdua99Sa/E4zF+WRkJfdOtpRandQmK85xlRfpgxuRFCPgj KmCT1fPrcuCJ4VmXxsRSGQKuPBkAv2TMkC8v/FYv1DdSClEyZVvlbepFycToipFkxgIg /aO2BQnkVlw3wh3k8faUwxPp02pHCtvlN++W1tsvm2mAY3RrZHgUCp4BFP7cQViCYGLm YKJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KZ2m+yHE+ZF4pMVBkPue5Bwsco6N7b6uFaY99iuPD4w=; b=Gg4uRKDtH95meSXwCMbl+gfGOakzC34PQninY2MfOWBZpGrNu61YQN/t9DjnENVEzL Q97RejnPFEFZ3wdNSutpZpVrZTwp9p8LFxkhySL0keuSE4t2hVrvPObCFILtlAdaIZdT V03rAQiY4Nxcw3iei72oUtmqeqjSetgg52CjEKJOhmU1TDbI3+PtQI+Q1Yq1+h4Gc+Hd KIdxCk8+9eJq/UULuKWRFUKU7nkBELiHoFGesC0g9bp4sI20ygMhEKnePm+Suy1qHm4s BRUpRd2bur6sNGygJDr3iJN5u1AElfHLJGakJ7qNFKnJo/SnNyeuOtRFBMAdJjSsWUvR JCUQ== X-Gm-Message-State: APjAAAVM5gMp3PnOZsranD60luEbKrQFam0859hkl2Pgo5xIOgwLgPuQ nq51HEXSovPEwbPkVpVXCLkOYX15RFsVcgWnWyQX4A== X-Google-Smtp-Source: APXvYqyQV2e8nH0CevPJ3rr6AYrD/i0l403prbgzYmnsrcSZG8m+MeMOfxML0VOl1Esepj2YH/5dJODiSa6K5Ctk7iQ= X-Received: by 2002:a02:9143:: with SMTP id b3mr21428229jag.12.1560171862619; Mon, 10 Jun 2019 06:04:22 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Mon, 10 Jun 2019 14:04:10 +0100 Message-ID: Subject: Re: [pgAdmin][RM4310] User can not connect to the Master Password with Enter button To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000a90fe1058af7d12c" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000a90fe1058af7d12c Content-Type: text/plain; charset="UTF-8" Thanks, applied! On Mon, Jun 10, 2019 at 10:35 AM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi, > > On Mon, Jun 10, 2019 at 2:34 PM Dave Page wrote: > >> Hi >> >> On Wed, Jun 5, 2019 at 1:39 PM Aditya Toshniwal < >> aditya.toshniwal@enterprisedb.com> wrote: >> >>> Hi, >>> >>> On Wed, Jun 5, 2019 at 4:48 PM Dave Page wrote: >>> >>>> Hi >>>> >>>> On Wed, Jun 5, 2019 at 8:14 AM Aditya Toshniwal < >>>> aditya.toshniwal@enterprisedb.com> wrote: >>>> >>>>> Hi Hackers, >>>>> >>>>> Attached is the patch to fix an issue where using browser autofills in >>>>> alertify dialogs triggers the help page button (#4317). >>>>> A workaround was added to master password dialog to avoid this, but >>>>> that in turn disabled the 'OK' button tigger on pressing enter button. This >>>>> is also fixed with this patch.(#4310) >>>>> >>>> >>>> This isn't quite right. When the browser auto-fills the password, the >>>> OK button remains disabled. I can hit enter though - however, I shouldn't >>>> be able to do that when the OK button is disabled (being the default button >>>> on the dialogue, it should respond to enter, unless another control which >>>> also accepts enter has focus (e.g. a multiline text area). >>>> >>> The autofilled password appears as set, but it is actually not set to >>> textbox unless you enter/click in the dropdown. We get the DOM element >>> value as blank even if it appears filled. This is how chromium autofill >>> behaves. Upon hitting enter the autofill value is set to the textbox and OK >>> button is enabled. >>> >>>> >>>> The OK button should be enabled - probably all the time, as the user >>>> could have entered a blank password, and most systems won't prevent a user >>>> from trying to use such a password. >>>> >>> I have made the changes to allow blank master password, plus enabling OK >>> button always. Attached is the updated patch. >>> >> >> I think you've slightly mis-understood what I was trying to say. >> >> - We should not allow a blank password. >> - We should not disable the OK button at all. >> >> My analogy was focussed on the fact that most systems never disable OK >> buttons on login dialogues, as some of those systems (but not all of >> course) may allow blank passwords. >> > Got it !! Attached is the updated patch. > >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --000000000000a90fe1058af7d12c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, applied!

On Mon, Jun 10, 2019 at 10:35 AM Aditya To= shniwal <aditya.tos= hniwal@enterprisedb.com> wrote:
Hi,

On Mon, Jun 10= , 2019 at 2:34 PM Dave Page <dpage@pgadmin.org> wrote:
Hi

On Wed, Jun 5, 2019 = at 1:39 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote= :
Hi,
=

= On Wed, Jun 5, 2019 at 4:48 PM Dave Page <dpage@pgadmin.org> wrote:

The OK button = should be enabled - probably all the time, as the user could have entered a= blank password, and most systems won't prevent a user from trying to u= se such a password.



--=
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @= pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL= Company


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0EnterpriseDB I= ndia |=C2=A0Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @p= gsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL = Company
--000000000000a90fe1058af7d12c--