Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jOLXf-0000yW-94 for pgadmin-hackers@arkaria.postgresql.org; Tue, 14 Apr 2020 13:23:55 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jOLXe-00022C-5C for pgadmin-hackers@arkaria.postgresql.org; Tue, 14 Apr 2020 13:23:54 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jOLXd-000224-4Q for pgadmin-hackers@lists.postgresql.org; Tue, 14 Apr 2020 13:23:54 +0000 Received: from mail-ed1-x542.google.com ([2a00:1450:4864:20::542]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jOLXZ-0005hO-TY for pgadmin-hackers@lists.postgresql.org; Tue, 14 Apr 2020 13:23:52 +0000 Received: by mail-ed1-x542.google.com with SMTP id a43so17114037edf.6 for ; Tue, 14 Apr 2020 06:23:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4PImyg3baQPxeJ1ffhUfsZjQB/liGxvYSDkXJSFnxvY=; b=AE5FL1/+l2bQSVoJIwynG+ZhhmTiReL8sm6/OW3jJDnvJFSaucGUdKPr+LvvdHot6q hAPWlHzCiPzX6kTNxFmRBgPfkXj5dIqpeX29BNaX/NTrfgFbLp0gFfgbILohmTHm26vC /203EVQhljwxntrfhhWctQaa6KWrAHXZ7MgRuJT/PlI70bVl1Mpq6gmEuz2selyQ/z52 4qEZQ7/LDtH0fVv5D7y3c/egRX503BTZGWg2T+x+Rb2Y2CeMmaMCmqTStJbN+6AiXujk YzggD38oGvSBvEcr1yp/Z3JhW5RuP2TDeTguvdOJgZ532VLVcnqbc+KjDwK1AJOa4pA6 d+Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4PImyg3baQPxeJ1ffhUfsZjQB/liGxvYSDkXJSFnxvY=; b=lTlXxiTNgrlA/ndEbvRj52B1QdU5GPxcEGSmuub5x1nVK3pY+JmWrIjFGCaiiXjMz1 Po8rrBMrt7BJXdcFaWtGv/3EAPqLIE4qs04VSKa1PbwP7mx4EZ5678dT3JljZP73UPYi x/cWALMm8CyA/7YQFdoQiCVvlggVNbUnX0e7un5sgOEeXfuzCyKhhmABEsPE1wSjJTZN pcMf1VEhraq4V6YlqctF/Fya7W1DPfRFK0LhiX9f2JyFzYhdgVbfYc7zxV1dYqXn5D8G U8v/j4jlsKiYw2NlDJfnd2a9plAdaHkfEUgePqj81LzraT73Du/65G7YIq47MR4/bKlk X9Bg== X-Gm-Message-State: AGi0PuZNCmETeginc0ASEiLliuHbo8dYW5qur+8tfXOZ9TNDUPFkI39d LB1morL3N/wwxyi2zA7RxEKCq1S9QF7MnO4FRov3Xg== X-Google-Smtp-Source: APiQypJBqzA0rnMsRDeu8VmLKCp/0n+kwdd9aEu4TCbFOjRsng6VbJ0/ohm/qqvaw63UvADsBnXq6krGU5JuLDF8lWM= X-Received: by 2002:a17:906:9482:: with SMTP id t2mr34439ejx.241.1586870629118; Tue, 14 Apr 2020 06:23:49 -0700 (PDT) MIME-Version: 1.0 References: <1e6b5a0b-2fc9-1cac-f13a-bcc84f02e00e@darrenduncan.net> <6148f1ed-8eee-931e-06a1-23c64d790cf5@darrenduncan.net> In-Reply-To: From: Dave Page Date: Tue, 14 Apr 2020 14:23:37 +0100 Message-ID: Subject: Re: Proposal: Drop support for Internet Explorer To: Khushboo Vashi Cc: Darren Duncan , pgAdmin Support , pgadmin-hackers , Akshay Joshi Content-Type: multipart/alternative; boundary="00000000000027491705a3401cb4" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000027491705a3401cb4 Content-Type: text/plain; charset="UTF-8" Here's an updated patch that gives a slightly different message if the browser is unknown vs. unsupported/deprecated. As with the previous patch, the check can be disabled in the config. On Fri, Apr 10, 2020 at 5:07 AM Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > > > On Thu, Apr 9, 2020 at 11:57 PM Darren Duncan > wrote: > >> The patch looks good as much as I understand it, but this raises an >> important >> question: >> >> How should one best handle minority browsers that may be completely >> modern but >> you may not specifically know about them? Such as the newer crop of >> browsers >> that emphasize stronger privacy or may have fewer identifiers? >> >> While going on a whitelist as the patch essentially does for known good >> browsers >> is conservative, I feel that an alteration would be good. >> >> I propose dividing the browsers/environments into 3 categories, which are >> recognized-supported, recognized-unsupported, and unrecognized. >> > >> So the unsupported older versions of supported browsers get a stronger >> message >> encouraging a browser switch as they are recognized as unsupported, while >> unrecognized browsers get a different weaker message saying they weren't >> recognized so we can't determine if they'd work; both can point to the >> list of >> known supported browsers. >> >> I do agree with this suggestion. > > >> Related to this, there could be an application toggle that affects the >> unrecognized category where users can basically say, yes I understand you >> don't >> recognize this browser, please hide the warning, or something like that. >> >> Also, it probably goes without saying, but the code/templates will need >> to be >> structured in such a way that the warning message uses about plain as >> possible >> HTML so that if the browser doesn't support displaying the UI in general >> it can >> at least display the message. >> >> -- Darren Duncan >> >> On 2020-04-09 4:36 a.m., Dave Page wrote: >> > Hi >> > >> > On Thu, Apr 9, 2020 at 12:26 AM Darren Duncan wrote: >> > >> > If its hard to know how many people are actually using Internet >> Explorer: >> > >> > You could make the next release of pgAdmin display a message >> occasionally to >> > users of Internet Explorer saying that Internet Explorer will no >> longer be >> > officially supported in a future version, and when that version >> comes the >> > message says now no longer supported. >> > >> > You can then see how many people contact you about this to express >> concern. >> > >> > >> > Good idea. I've hacked up a patch to warn users if they're using a >> deprecated or >> > unsupported browser. >> > >> > CCing Akshay for a review :-) >> > >> > -- >> > Dave Page >> > Blog: http://pgsnake.blogspot.com >> > Twitter: @pgsnake >> > >> > EnterpriseDB UK: http://www.enterprisedb.com >> > The Enterprise PostgreSQL Company >> >> >> >> -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --00000000000027491705a3401cb4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Here's an updated patch that gives a slightly dif= ferent message if the browser is unknown vs. unsupported/deprecated. As wit= h the previous patch, the check can be disabled in the config.

On Fri, Apr 1= 0, 2020 at 5:07 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:


On Thu, Apr 9, 2020 at 11:57 PM Darren Duncan <darren@darrenduncan.net>= wrote:
The patc= h looks good as much as I understand it, but this raises an important
question:

How should one best handle minority browsers that may be completely modern = but
you may not specifically know about them?=C2=A0 Such as the newer crop of b= rowsers
that emphasize stronger privacy or may have fewer identifiers?

While going on a whitelist as the patch essentially does for known good bro= wsers
is conservative, I feel that an alteration would be good.

I propose dividing the browsers/environments into 3 categories, which are <= br> recognized-supported, recognized-unsupported, and unrecognized.

So the unsupported older versions of supported browsers get a stronger mess= age
encouraging a browser switch as they are recognized as unsupported, while <= br> unrecognized browsers get a different weaker message saying they weren'= t
recognized so we can't determine if they'd work; both can point to = the list of
known supported browsers.

I do agree with this suggestion.
=C2=A0
Related to this, there could be an application toggle that affects the
unrecognized category where users can basically say, yes I understand you d= on't
recognize this browser, please hide the warning, or something like that.
Also, it probably goes without saying, but the code/templates will need to = be
structured in such a way that the warning message uses about plain as possi= ble
HTML so that if the browser doesn't support displaying the UI in genera= l it can
at least display the message.

-- Darren Duncan

On 2020-04-09 4:36 a.m., Dave Page wrote:
> Hi
>
> On Thu, Apr 9, 2020 at 12:26 AM Darren Duncan wrote:
>
>=C2=A0 =C2=A0 =C2=A0If its hard to know how many people are actually us= ing Internet Explorer:
>
>=C2=A0 =C2=A0 =C2=A0You could make the next release of pgAdmin display = a message occasionally to
>=C2=A0 =C2=A0 =C2=A0users of Internet Explorer saying that Internet Exp= lorer will no longer be
>=C2=A0 =C2=A0 =C2=A0officially supported in a future version, and when = that version comes the
>=C2=A0 =C2=A0 =C2=A0message says now no longer supported.
>
>=C2=A0 =C2=A0 =C2=A0You can then see how many people contact you about = this to express concern.
>
>
> Good idea. I've hacked up a patch to warn users if they're usi= ng a deprecated or
> unsupported browser.
>
> CCing Akshay for a review :-)
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company





--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @p= gsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL = Company
--00000000000027491705a3401cb4--