MIME-Version: 1.0
In-Reply-To: 
 <CAM5-9D8_pg1u6OxWcDPy+SxOdVf_PiQH7N57bL1=dL4KNn8suw@mail.gmail.com>
References: 
 <CAM5-9D-5Vf2XvBm-U7DQLQY2ZKepyaLHVTOHcAsGiW84=V5cSA@mail.gmail.com>
 <CA+OCxowHpsu3S+sOXMeDL=Y6f_i=vjYi_9q7Os-Hh8jYo+iPRw@mail.gmail.com>
 <CAM5-9D8_pg1u6OxWcDPy+SxOdVf_PiQH7N57bL1=dL4KNn8suw@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Tue, 20 Sep 2016 11:18:31 +0100
Message-ID: 
 <CA+OCxozTw=o-9bW2Gq0cjSrZMX=dA2hNMWg6yhfHyiqhaZUwtQ@mail.gmail.com>
Subject: Re: [pgAdmin4][Patch]: RM1627 - Objects are not
 visible after creation until press refresh button
To: Surinder Kumar <surinder.kumar@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>,
	Ashesh Vashi <ashesh.vashi@enterprisedb.com>
Content-Type: text/plain; charset=UTF-8
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

On Tue, Sep 20, 2016 at 10:22 AM, Surinder Kumar
<surinder.kumar@enterprisedb.com> wrote:
> On Mon, Sep 19, 2016 at 9:49 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> Hi
>>
>>
>> On Mon, Sep 19, 2016 at 4:23 PM, Surinder Kumar
>> <surinder.kumar@enterprisedb.com> wrote:
>> > Hi
>> >
>> > Please find patch with following fixes:
>> >
>> > 1) Newly added server-group not listing in tree view.
>> >
>> > 2) On creating a first node for collection node with no child. the
>> > created
>> > node doesn't show up under its respective parent node.
>> > - to add a node to child under its parent node. its parent node
>> > attribute
>> > must be set 'inode: true' but it always gets false for inode that
>> > doesn't
>> > add the node.
>> >
>> > Ashesh - Can you please review it?
>>
>> I tested this by adding a sequence to a database and schema that
>> didn't previously contain any. The node was not added, and in the
>> Javascript console I get:
>>
>> browser.js:1108 Failed to append
>
> This issue is taken care in updated patch, Also properly handled the case
> for 'server-group' not listing in tree view, thus removing
> 'addNodeWithNoParent' method from previous patch.
> I have tested it for most of the nodes, it works.
> Please find updated patch and review.

Works nicely - applied, thanks.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers