MIME-Version: 1.0
In-Reply-To: 
 <CA+yw=mNfEV51SFb6h1nb23mFD94D0HqRDyMqYE5XwuSy8DOvug@mail.gmail.com>
References: 
 <CA+yw=mMx=HsY2K01bQmdh6i+E4hUKJJM+KZWW_4B0AhB-O8cPw@mail.gmail.com>
	<CA+yw=mNfEV51SFb6h1nb23mFD94D0HqRDyMqYE5XwuSy8DOvug@mail.gmail.com>
Date: Thu, 25 Feb 2016 14:07:00 +0000
Message-ID: 
 <CA+OCxozUe1K9V-JF3HQ+Aj8gdEep8xhxD-GxrdkUB_k11eu55w@mail.gmail.com>
Subject: Re: PATCH: PGADMIN 4 - FTS templates node
From: Dave Page <dpage@pgadmin.org>
To: Sanket Mehta <sanket.mehta@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary=047d7bfea0b644a0aa052c98b22a
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

--047d7bfea0b644a0aa052c98b22a
Content-Type: text/plain; charset=UTF-8

Hi

On Tue, Feb 23, 2016 at 1:44 PM, Sanket Mehta <sanket.mehta@enterprisedb.com
> wrote:

> Hi,
>
> PFA the revised patch for fts template node which includes dependency and
> dependent route handling code.
> Please do review it and if found proper please do commit it.
>

- When creating a new template, errors in the dialogue are not cleared -
e.g. the "Name must not be empty" doesn't clear, and save is not enabled,
even when a name is entered.

- "Fts Templates" should be "FTS Templates" on the treeview.

- The "Init" field should be labelled "Init Function"

- The "Lexize" field should be labelled "Lexize Function"

- Selecting a schema should be optional, with the default being the current
schema.

- 4 character indents are not consistently used in SQL templates

Thanks.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--047d7bfea0b644a0aa052c98b22a
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi<br><div class=3D"gmail_extra"><br><div class=3D"gmail_q=
uote">On Tue, Feb 23, 2016 at 1:44 PM, Sanket Mehta <span dir=3D"ltr">&lt;<=
a href=3D"mailto:sanket.mehta@enterprisedb.com" target=3D"_blank">sanket.me=
hta@enterprisedb.com</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_qu=
ote" style=3D"margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-co=
lor:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir=3D"=
ltr"><div><div>Hi,<br><br></div>PFA the revised patch for fts template node=
 which includes dependency and dependent route handling code.<br></div>Plea=
se do review it and if found proper please do commit it.</div></blockquote>=
<div><br></div><div>- When creating a new template, errors in the dialogue =
are not cleared - e.g. the &quot;Name must not be empty&quot; doesn&#39;t c=
lear, and save is not enabled, even when a name is entered.</div><div><br><=
/div><div>- &quot;Fts Templates&quot; should be &quot;FTS Templates&quot; o=
n the treeview.</div><div><br></div><div>- The &quot;Init&quot; field shoul=
d be labelled &quot;Init Function&quot;</div><div><br></div><div>- The &quo=
t;Lexize&quot; field should be labelled &quot;Lexize Function&quot;</div><d=
iv><br></div><div>- Selecting a schema should be optional, with the default=
 being the current schema.</div><div><br></div><div>- 4 character indents a=
re not consistently used in SQL templates=C2=A0</div></div><br clear=3D"all=
"><div>Thanks.</div><div><br></div>-- <br><div class=3D"gmail_signature">Da=
ve Page<br>Blog: <a href=3D"http://pgsnake.blogspot.com" target=3D"_blank">=
http://pgsnake.blogspot.com</a><br>Twitter: @pgsnake<br><br>EnterpriseDB UK=
: <a href=3D"http://www.enterprisedb.com" target=3D"_blank">http://www.ente=
rprisedb.com</a><br>The Enterprise PostgreSQL Company<br></div>
</div></div>

--047d7bfea0b644a0aa052c98b22a--