MIME-Version: 1.0
In-Reply-To: 
 <CAM5-9D81MtwXQWCfx+EY7Qj5NPuSOb4g9XP8zOsy7MjsWA20Jg@mail.gmail.com>
References: 
 <CAM5-9D81MtwXQWCfx+EY7Qj5NPuSOb4g9XP8zOsy7MjsWA20Jg@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Fri, 7 Oct 2016 12:31:48 +0100
Message-ID: 
 <CA+OCxozVi43RHwNkfcCutmaCwk-JmGw1XdeqqEWtU3wQA8AmuA@mail.gmail.com>
Subject: Re: [pgAdmin4][Patch]: RM1739 - Don't show Upload
 File icon unless it is not in capabilities [Storage Manager]
To: Surinder Kumar <surinder.kumar@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: text/plain; charset=UTF-8
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

Thanks, patch applied.

On Fri, Oct 7, 2016 at 7:03 AM, Surinder Kumar
<surinder.kumar@enterprisedb.com> wrote:
> Hi,
>
> Issue:
> When clicked on upload icon while saving a file prompt user to leave page.
> It is because the icon is a button and its type is set to submit which makes
> it to prompt, instead it should be 'button'
>
> Storage Manager's menu items depends on capabilities list set by the module
> using it. If capabilities doesn't have 'upload' in it, It won't work. Upload
> button is bound to click event only when it is in capabilities.
>
> Solution:
> As upload button is being added only when it is in capabilities, so upload
> button html is removed from html file. It will not shown on UI untill it is
> in capabilities list.
>
> Please find attached patch and review.
>
>
> Thanks,
> Surinder Kumar
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers