Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iPSaz-0004r9-Im for pgadmin-hackers@arkaria.postgresql.org; Tue, 29 Oct 2019 14:35:41 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iPSay-0007VH-7H for pgadmin-hackers@arkaria.postgresql.org; Tue, 29 Oct 2019 14:35:40 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iPSax-0007V9-Nj for pgadmin-hackers@lists.postgresql.org; Tue, 29 Oct 2019 14:35:40 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1iPSau-0006Pi-TD for pgadmin-hackers@postgresql.org; Tue, 29 Oct 2019 14:35:38 +0000 Received: by mail-wm1-x342.google.com with SMTP id g7so2829218wmk.4 for ; Tue, 29 Oct 2019 07:35:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AqpIrisLRbSVhKxXevi+keq3Ca9ju/cxgcAQADF9bgM=; b=KQft5+71zzNmE0USoiISiYkfVUp/M3SqlABlBS7dBSX4Tl5PKGkyeMZADkjZf0ZZ/V pICjKv13xFb/JEsMvzEKAE9aMrT0gcez5/oIdskZi63ouGoMfG9R8lHe994T+RTnEiZy P2pL0+rAogmLyessZxe31jxeC+5Q2BYLNx6QbcOBKWW5SvqPUbLo/13jP+ixZ+xka79q kIQPYKBSei773YPvFvGwpUjbVIMKLl6YFWGc/QKHjY6+JWV+MRah61B1tk8pnIobAWcr ko1dPiqjlqcGNC/7uiSDdMVASfdEZhegZsRNyAjsmVb5rNp4L0ygkRdAbjztfkBZN+rR EcFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AqpIrisLRbSVhKxXevi+keq3Ca9ju/cxgcAQADF9bgM=; b=m1iO+pzRqbAWIqi5fwfPc64r4W2ivjC3dZjuGBz/Z9nvud/n0U5ZF+SAc6+c9eJRUd PWO7AAGhOsMD3Hi5/OQ7Vl710ol30KZJGuSGiJUdLvSaH3Ss3VaUz+i4X/A95bA61865 ndER8vBwLfsdu8H8Z8X/Qf9dlkkZPrb1xrfINdD9/aT9aMUWT1diFULKDIVGQBEvhqM1 S4DCwAEvR8/l3z82jo3cpugmjqMQ7BRwu3j4KR17qEPy4zSAp0+rGMoZskQd4N2y4p7y L3EZxk/VvlddAmlCYk2eUdGUHZhJGQz4d824xVc50LegXB0reUZHz1xgouYHamKLKf7n sZlQ== X-Gm-Message-State: APjAAAURWZEy4tzAZ9XhQjZrkNviQeqgIpuTrtaiHMGt8ovE/1mkkm5e pVKE48KV0lUvFSx+xbkSLaJgr0p9Z5TnxPM0O0D06Q== X-Google-Smtp-Source: APXvYqwBcucC1Ll9/OzywhQkiuN5YLeTY284Wms1c2BBkN4g/h0cvAkig9SFeZQ71jfDyxs3Od+uVxHf7rBHVSAvsQQ= X-Received: by 2002:a1c:80c7:: with SMTP id b190mr4562390wmd.3.1572359735449; Tue, 29 Oct 2019 07:35:35 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Tue, 29 Oct 2019 14:35:23 +0000 Message-ID: Subject: Re: [pgAdmin][RM4351] Confirm before close of properties dialog if changes not saved To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000007dafdc05960d8787" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000007dafdc05960d8787 Content-Type: text/plain; charset="UTF-8" Thanks, applied. On Tue, Oct 29, 2019 at 6:40 AM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to warn the user before closing an unsaved > properties dialog. > Additionally, I have added a preference option in Browser->Display where > the user can disable this. Default is enabled. > Docs updated. > > Kindly review. > > -- > Thanks and Regards, > Aditya Toshniwal > Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --0000000000007dafdc05960d8787 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, applied.

On Tue, Oct 29, 2019 at 6:40 AM Aditya Tos= hniwal <aditya.tosh= niwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch = to warn the user before closing an unsaved properties dialog.
Additionally,= I have added a preference option in Browser->Display where the=C2=A0use= r can disable this. Default is enabled.
Docs updated.

Kindly review.<= /div>

--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer |=C2= =A0EnterpriseDB India |=C2=A0Pune
"Don't Complain about Heat, Plant a TREE"<= /font>


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @p= gsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL = Company
--0000000000007dafdc05960d8787--