Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iQVR6-0003tw-5z for pgadmin-hackers@arkaria.postgresql.org; Fri, 01 Nov 2019 11:49:48 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iQVR4-0004l1-W9 for pgadmin-hackers@arkaria.postgresql.org; Fri, 01 Nov 2019 11:49:46 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iQVR4-0004ku-Bi for pgadmin-hackers@lists.postgresql.org; Fri, 01 Nov 2019 11:49:46 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iQVR1-0007wY-HP for pgadmin-hackers@postgresql.org; Fri, 01 Nov 2019 11:49:45 +0000 Received: by mail-wm1-x341.google.com with SMTP id 8so1809204wmo.0 for ; Fri, 01 Nov 2019 04:49:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DjNYKs0a8X0zEdIrVXUzF48CbgqvQibDBkKOec0MzsY=; b=AWgfiDhuNMwCdr/kd13aDhWqSQC/g+P7YJS6V9mAOelHr6NyoHaliAUt5yHAW4NWPP 6d4sZnam5e8X/MVQYIzHZstGhQiq+uelJmJbVwH0wRcyXTJsHP4pTKWXMI+MgtdORcr4 r6738w01tWlYgKPJyeO8iR+5vpjkEFDyo7lj0xzOie+DQrUB52YmRI1htINrLh+YGp8c ikhLk3r8efTmYG53okZsyMU4Kv1PCydnlh67PcmTUvIosTAPKgzqzHYExeuzN+61Z38j +S/DmNKtKhm+OpMxPVlK3rsyc0JFvIgftJgC7ZoetN+XgPHXWV6qECr4VdTqmH38K0Jq 1ocw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DjNYKs0a8X0zEdIrVXUzF48CbgqvQibDBkKOec0MzsY=; b=QcILWyOjpA4EqtCq/9Aa259QO6OSoWkivSYmijRJBKxAghN7vHS6fDY8Jx39+34EZW KrSz/mhgFGQsfTOe5mJyUvOQ99mhft71luKIXVOK2bzyQGtk+sg4g9hQBbzJYmu9HqFL BLGvLfElp7SgiZYQ/LUTJ/dSsCIh+VLOBEQfMyBxI1qCo8xJxGrNSSrjpKszYpS311gt vF39VRPBOApiiSVbZXh0yMJ11ghkoxm7xbn1vQkLmf+PfKWySg+BnY2kPh5TzBVlV4BQ KITDFInXYB4XFjT5mG8iF1yig7jUQJ7yIXA0yPAI4KyOGyyyx7sOAWGwDqjaTCvN5jM3 nPuw== X-Gm-Message-State: APjAAAV9dseAsMycEdVV3BGu57CWLwLC6g4oRP9UBdf5vofouo48SMjt q203O0oGy6As/rOlxQPELVjalFVG9byKLmixGX3BEg== X-Google-Smtp-Source: APXvYqzSK9FxO9RtqmO/BchwEze19XSszOgm1Om7rvIjARFB/p0fjlrerfrcLuDrE0gJbY2BYMTjJZJ4Ic0FpVmNqGA= X-Received: by 2002:a1c:80c7:: with SMTP id b190mr10177090wmd.3.1572608980810; Fri, 01 Nov 2019 04:49:40 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Fri, 1 Nov 2019 11:49:28 +0000 Message-ID: Subject: Re: [pgAdmin][RM4006] Trigger enable always/replica shown as disabled To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000ac1f950596478f49" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000ac1f950596478f49 Content-Type: text/plain; charset="UTF-8" Thanks, applied. On Thu, Oct 31, 2019 at 7:52 AM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch for Bug-cum-feature to show always/replica options > for triggers. > The "Trigger enabled" switch control is changed to select2 dropdown now, > with four options as Enable, Enable Replica, Enable Always, Disable. > Changes are done for both triggers and compound triggers(EPAS v12+). The > context menu options of Enable/Disable trigger will work as before. > Docs are updated and test cases are updated accordingly. > > Kindly review. > > -- > Thanks and Regards, > Aditya Toshniwal > Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --000000000000ac1f950596478f49 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, applied.

On Thu, Oct 31, 2019 at 7:52 AM Aditya Tos= hniwal <aditya.tosh= niwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch = for Bug-cum-feature to show always/replica options for triggers.
The "= Trigger enabled"=C2=A0switch control is changed to select2 dropdown n= ow, with four options as Enable, Enable Replica, Enable Always, Disable.
Ch= anges are done for both triggers and compound triggers(EPAS v12+). The cont= ext menu options of Enable/Disable trigger will work as before.
Docs are up= dated and test cases are updated accordingly.

Kindly review.

--
<= div>
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer |=C2=A0Enterpr= iseDB India |=C2=A0Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @p= gsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL = Company
--000000000000ac1f950596478f49--