Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bS30T-0001MZ-UI for pgadmin-hackers@arkaria.postgresql.org; Tue, 26 Jul 2016 14:06:50 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bS30T-0001iO-D4 for pgadmin-hackers@arkaria.postgresql.org; Tue, 26 Jul 2016 14:06:49 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bS30F-00010T-Vs for pgadmin-hackers@postgresql.org; Tue, 26 Jul 2016 14:06:36 +0000 Received: from mail-it0-x22a.google.com ([2607:f8b0:4001:c0b::22a]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bS30A-0007OV-N3 for pgadmin-hackers@postgresql.org; Tue, 26 Jul 2016 14:06:35 +0000 Received: by mail-it0-x22a.google.com with SMTP id f6so12414704ith.0 for ; Tue, 26 Jul 2016 07:06:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=/aruzUtodtLPv5hvjbfzs4fjHznBT6KptL3ivEKQl2M=; b=XNOI+WvmtNFRiXuJq+JmjPXFab69rhhU869k1VbYECTIvj8Eld25eUVMVuPxJCNOFh D7IRspLfVRAYD/JPxtptjJOVE4dw/RxEijx91tQzyclvVfrMRz8j6qp0z9USUpoT8jbZ YXr+o3li3fKQ53WjCk2dsMFssCFpqPqw49JVX4j7fBctaWyKE4L95wNoGrSajmdfce/7 WlsX84WTNF1rlgrM+5StuBv2KSAJmEG4gldKEn0RZWKm3FM/8i1Vlf+YABJGQ+kNeClQ yqFiv6AriiloiSrszaMAqh5nsHJUchtW/coLufuHhfBAEQp88GsY48C1Qt/DwsBWjpxd K/rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=/aruzUtodtLPv5hvjbfzs4fjHznBT6KptL3ivEKQl2M=; b=mScDAXWq8O4ZjcW5QUq2k9FzPXsdnMQQ+13DeRF9kS5T6rnwPiPQ/91lW7n3QPVKr+ hbXc476MrZeF52HDFKO7pSIJJ3NR/vUh1ZcimI/vj+Rh8FdWdATprLhr7om9lqubdlN4 duatIWWYML44pJq3jcFma6AuGiwIWyWx9a68xImvJ4ALt23dNJVsmBdXu979jPK/KUiz f7KRSH6QRnEdd+455/gSZkchLuE+oznRubBK43omD1tYwjTLyZCuHpBha4sW3kmcbcpP YCnEWv+uBorg2klAFQCwytc5xvWPHbg2uTxOJRcBjka5DmrD8dNUBZjp4grxbNevzlu5 t7Ng== X-Gm-Message-State: ALyK8tKSh5Cjt5bBsFClf4sHnpSTBHy50N3yi9IZkQ7m7TVmERIJHnc3YVHtiXIjb+tvsTdJxrb05UYwUBSebQ== X-Received: by 10.36.103.214 with SMTP id u205mr35252840itc.88.1469541988751; Tue, 26 Jul 2016 07:06:28 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.208.97 with HTTP; Tue, 26 Jul 2016 07:06:28 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Tue, 26 Jul 2016 15:06:28 +0100 Message-ID: Subject: Re: PATCH: Encoding issue with qtLiteral function (pgAdmin4) To: Murtuza Zabuawala Cc: pgadmin-hackers Content-Type: text/plain; charset=UTF-8 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org Hi On Tue, Jul 26, 2016 at 2:34 PM, Murtuza Zabuawala wrote: > Hi Dave, > > PFA updated patch to fix encoding issue, I have tested in Python2/3 and > looks like working in both environment. > > Almost all nodes are affected with this change, I tried to test & cover all > basic operations on nodes but still it requires some testing. > > This patch will cover below tickets, > RM#1307 > RM#1479 I've committed this as-is, as it fixes things nicely as far as I can see... with one exception: I couldn't create Functions with utf-8 names. Can you fix that please? Thanks. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers