MIME-Version: 1.0
In-Reply-To: 
 <CAOAJCYqQQ4MaudVaVwfcateuxum-W39HwRiEorhYP8zbqjxN0g@mail.gmail.com>
References: 
 <CAOAJCYrcxBN2J_3dWq0Cwc82fkugzUi3NKD4jKoTKRBot=ev8w@mail.gmail.com>
 <CAOAJCYpSBXcfEC5d4Sv_=jV86m1=rKUK0tMkZFhdSHkPb=XT3A@mail.gmail.com>
 <CA+OCxowW0wjpNT-o0YF1Bg9rtD6Z7sqp35ZRUgoEguVKO4OtSw@mail.gmail.com>
 <CAOAJCYr1JwYK4x2wDYw2UVAZoXC5a0FQT7Yz1Y_Wn46kzPMmQg@mail.gmail.com>
 <CA+OCxoxqahNgLmvQqqErQZL2JS0EaQwyXkgkzvkFtGNh0OKV6w@mail.gmail.com>
 <CAOAJCYqQQ4MaudVaVwfcateuxum-W39HwRiEorhYP8zbqjxN0g@mail.gmail.com>
From: Dave Page <dave.page@enterprisedb.com>
Date: Mon, 18 Jul 2016 14:55:07 +0100
Message-ID: 
 <CA+OCxozZVCwB4t6hXjMeHbBV8Fx1cm_Cg1tknjWyYxLFZNYsEQ@mail.gmail.com>
Subject: Re: pgAdmin IV : Unittest modular patch
To: Navnath Gadakh <navnath.gadakh@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>,
	Kanchan Mohitey <kanchan.mohitey@enterprisedb.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

Thanks - applied with some tweaks and changes, most notably:

- "--pkg all" is the default if no command line options are given.

- Output now goes in regression/regression.log

- Terminal output is limited to WARNINGS from the app server.

- The runner script is now python regression/runtests.py

On Mon, Jul 18, 2016 at 1:45 PM, Navnath Gadakh
<navnath.gadakh@enterprisedb.com> wrote:
> Hi Dave,
>
>   Please find the revised patch for unit tests of pgAdmin4 APIs.
>
> This patch includes-
>
> test_advance_config.json(for user it=E2=80=99s test_advance_config.json.i=
n) for
> advance test configuration for database/server(Priyanka was working on th=
is)
>
> test_config.json(for user it=E2=80=99s test_config_json.in) for basic cre=
dentials
> data for database/server
>
> From now onward we can execute test cases node wise/package wise. I have
> slightly modified the way of running the testsuite. We used the command l=
ine
> arguments(pkg) which denotes for which package testsuite going to run.
>
>
>           Run the testsuite for all packages by following command
>
>                Python regression/testsuite.py --pkg all
>
>       Here, =E2=80=98all=E2=80=99 means for all python
> packages(i.e.browser,server_groups,server,
>
>                             databases etc. which are same names in project
> directory structure)
>
>                This will find the =E2=80=98tests=E2=80=99 directory in ea=
ch package &
> execute the test cases.
>
>
>
>           Run the testsuite for single package by following command
>
>       Python regression/testsuite.py --pkg browser (this execute the tests
> in =E2=80=98browser=E2=80=99 package only)
>
>        Python regression/testsuite.py --pkg
> browser.server_groups.servers.databases (this execute the tests in
> =E2=80=98databases=E2=80=99 package only)
>
>   4.  Logger file. Which include the detailed output of the testsuite.
> Testsuite also prints the test summary on the console.
>
>     5.  Previously, we set the priority to each test case. In this patch
> priority logic is removed as there is no need to set priority.
>
>     6. Resolution of AttributeError for attribute 'APP_ROOT'(Which is
> mentioned by you in a previous email)
>
>
> Note: You might get =E2=80=98AttributeError=E2=80=99 while running this p=
atch on Python 3.4
> (I have raised this bug in RM(#1464)), But still you can run the testsuit=
e.
> It will run on Python 2.7 without error.
>
>
>
> On Fri, Jul 15, 2016 at 6:23 PM, Dave Page <dave.page@enterprisedb.com>
> wrote:
>>
>> Hi
>>
>> On Mon, Jul 11, 2016 at 2:16 PM, Navnath Gadakh
>> <navnath.gadakh@enterprisedb.com> wrote:
>>>
>>> Hi Dave,
>>> PFA updated patch for modular API test cases.
>>>
>>> On Mon, Jul 11, 2016 at 5:11 PM, Dave Page <dave.page@enterprisedb.com>
>>> wrote:
>>>>
>>>>
>>>>
>>>> On Fri, Jul 8, 2016 at 2:30 PM, Navnath Gadakh
>>>> <navnath.gadakh@enterprisedb.com> wrote:
>>>>>
>>>>>
>>>>> Hi Dave,
>>>>>
>>>>> PFA patch for modular API test cases.
>>>>>
>>>>> Kindly, review the same and let me know for any modification.
>>>>
>>>>
>>>> Please re-create the patch so that it doesn't revert various changes
>>>> made to config.py etc. over the last couple of weeks.
>>>
>>>
>>>   config.py file was not updated at my end, I have updated it in the
>>> current patch.  I have also added code related to advance test data
>>> configuration which was created by Priyanka (Seprated the test data
>>> configuration files).
>>>
>>>>
>>>> What is the patch for? Is it fixing issues in Priyanka's last patch, or
>>>> something else?
>>>> This patch is for -
>>>> 1. Now we can run testsuite node/module wise(like for browser only, for
>>>> databases only)  OR for all nodes/modules
>>>> 2. I have modified the existing functionality for testsuite and all te=
st
>>>> case classes (Made all test cases independently runnable, removed the
>>>> priority logic).
>>>
>>>
>>>
>>>     For more details please refer the file 'regression/README'.
>>
>>
>> When running all tests, I get:
>>
>> ...
>> ...
>>  <Rule '//static/<filename>' (HEAD, OPTIONS, GET) -> redirects.static>,
>>  <Rule '/backup/<filename>' (HEAD, OPTIONS, GET) -> backup.static>,
>>  <Rule '/reset/<token>' (HEAD, POST, OPTIONS, GET) ->
>> security.reset_password>,
>>  <Rule '/about/<filename>' (HEAD, OPTIONS, GET) -> about.static>])
>> Traceback (most recent call last):
>>   File "regression/testsuite.py", line 151, in <module>
>>     suite =3D get_suite(args, test_client)
>>   File "regression/testsuite.py", line 75, in get_suite
>>     TestsGeneratorRegistry.load_generators('pgadmin')
>>   File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/route.py", line 56, =
in
>> load_generators
>>     module =3D import_module(module_name)
>>   File
>> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/=
importlib/__init__.py",
>> line 37, in import_module
>>     __import__(name)
>>   File
>> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/dat=
abases/tests/test_db_add.py",
>> line 14, in <module>
>>     from regression import test_utils as utils
>>   File "/Users/dpage/git/pgadmin4/web/regression/test_utils.py", line 23,
>> in <module>
>>     def get_ids(url=3Dconfig.APP_ROOT + '/regression/parent_id.pkl'):
>> AttributeError: 'module' object has no attribute 'APP_ROOT'
>>
>> That's not overly surprising, as we don't have an APP_ROOT setting in the
>> config (nor should we - it should be calculated dynamically). Please fix,
>> and remember to test your patches against a clean copy of the git tree in
>> the future!
>>
>> Thanks!
>>
>> --
>> Dave Page
>> VP, Chief Architect, Tools & Installers
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>
>
>
>
> --
> Thanks,
> Navnath Gadakh
> Software Engineer
> EnterpriseDB Corporation
> Mobile: +91 9975389878
>
>


--=20
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake


--=20
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers