Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1etbam-0005ls-Ug for pgadmin-hackers@arkaria.postgresql.org; Wed, 07 Mar 2018 16:07:01 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1etbal-0006Vi-R7 for pgadmin-hackers@arkaria.postgresql.org; Wed, 07 Mar 2018 16:06:59 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1etbal-0006V0-Iw for pgadmin-hackers@lists.postgresql.org; Wed, 07 Mar 2018 16:06:59 +0000 Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1etbai-00027l-FP for pgadmin-hackers@postgresql.org; Wed, 07 Mar 2018 16:06:58 +0000 Received: by mail-wm0-x244.google.com with SMTP id q83so5802806wme.5 for ; Wed, 07 Mar 2018 08:06:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=G0OlQjJ+sPjMNsYHoyVbHJNWm1FmstVxH1FhkcvrJek=; b=B1yNzJceOKKfZIt6yj6ZcVJgG0/z5fc51yUhQRlZqy7H/j+krBbwN5H29hHT8dTyr8 PzaC/yFPasG9j3SndDQxc7/Hr2/AhP+o5N0bW8sG5NTn5Lp79GztcGG+CuJqFB/4ZEc+ CFkhfhu7/mO3RQF61XJVP0W7yVvsC5RGUXll4inBZiBO7/1nElk0eL+EWRTqxfXAngvt GN2+HMr/wjgE1EfKmZPdzJ61DbXax30mk2jMqhjWCuRCAUHLHy7/q92RBbt7DUWV3XFR rwzrrKFVbcRtr0cH3GfYnEKc2EVpXmMir7R19Dg4ywnGD2IN4muB5WIECyEScOwbAPfQ dabA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=G0OlQjJ+sPjMNsYHoyVbHJNWm1FmstVxH1FhkcvrJek=; b=WbkVa8yoWsjUM71MGUDZR3dBhqFs0nrKLCve8JycDQRbUVSgpuDNZJaTy5z6iiwIjk LGr6h23xHpt5gdM3+0rHR4d5RqxzC4ybvvK+EzwddT4N8HxDwQB8ZP4wFIhZztMDesh/ hRbR+FPxLWy4TtaAOJZ/ub4wZ9CrZzlMfEpJNV4/9I80yh46GwSk+O8BAImmDpug7u2X WxcydoqCJrtsH5w4bm+gohLyFnP6m89ZR6d4N923uL0/Zk8Yvl0/5g9WCJreKafKaSBU 2OkrgToKUcLiaOoCdTmkFgUdGKdwZFH1NdOpK6mgBVJPHgXizudBLIdT1emyUL2e7aDk Ak4A== X-Gm-Message-State: AElRT7FEl+kedU+fCb4mh3avj5O23ODcEmQPAiVWwGa9cJDMWE1brdOx bv589/f4ip41F3SJlerakmIOFpAQSvs/gWZWOcvt5FRq X-Google-Smtp-Source: AG47ELuX16zSbo3cMifAaLmT3z5DqnbWcCqkcO3nlHkyeOK7F9zRgdKY2flFYidKnHrWyvVTc3jqX4Ik1t831klBayc= X-Received: by 10.28.190.18 with SMTP id o18mr15324528wmf.86.1520438814750; Wed, 07 Mar 2018 08:06:54 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.109.7 with HTTP; Wed, 7 Mar 2018 08:06:54 -0800 (PST) In-Reply-To: References: From: Dave Page Date: Wed, 7 Mar 2018 16:06:54 +0000 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM #3135 - [Web based] Syntax error displayed when user try to insert data on table where primray key is in captial letters and table contains OIDS To: Khushboo Vashi Cc: Joao De Almeida Pereira , pgadmin-hackers Content-Type: multipart/alternative; boundary="f403043c3bf074c57a0566d4bf2b" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --f403043c3bf074c57a0566d4bf2b Content-Type: text/plain; charset="UTF-8" Thanks - applied. On Wed, Mar 7, 2018 at 4:30 AM, Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > > > On Tue, Mar 6, 2018 at 8:35 PM, Joao De Almeida Pereira < > jdealmeidapereira@pivotal.io> wrote: > >> Hello Khushboo, >> >> All tests pass on CI, and the code looks good. The only issue that I >> found was the line: >> os.path.dirname(os.path.realpath(__file__)) + "/../templates" >> >> that will not work on windows. >> So I updated your patch with the change and it should be ready to merge. >> >> Thanks Joao. > > Thanks >> Joao >> >> On Tue, Mar 6, 2018 at 7:33 AM Khushboo Vashi < >> khushboo.vashi@enterprisedb.com> wrote: >> >>> Hi Joao, >>> >>> Thanks for reviewing. >>> >>> On Thu, Mar 1, 2018 at 8:06 PM, Joao De Almeida Pereira < >>> jdealmeidapereira@pivotal.io> wrote: >>> >>>> Hello Kushboo, >>>> >>>> Can we add some Unit test to ensure this does not happen again? >>>> >>>> Please find the attached patch with the unit tests. >>> >>>> Thanks >>>> Joao >>>> >>>> Thanks, >>> Khushboo >>> >>>> On Thu, Mar 1, 2018 at 2:28 AM Khushboo Vashi < >>>> khushboo.vashi@enterprisedb.com> wrote: >>>> >>>>> Hi, >>>>> >>>>> Please find the attached patch to fix RM # 3135 - [Web based] Syntax >>>>> error displayed when user try to insert data on table where primray key is >>>>> in captial letters and table contains OIDS >>>>> >>>>> Thanks, >>>>> Khushboo >>>>> >>>> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --f403043c3bf074c57a0566d4bf2b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks - applied.

On Wed, Mar 7, 2018 at 4:30 AM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:

On Tue, Mar 6, 2018 at 8:35 P= M, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io>= ; wrote:
Hello Kh= ushboo,

All tests pass on CI, and the code looks good. T= he only issue that I found was the line:
=C2=A0os.path.dirname(os= .path.realpath(__file__)) + "/../templates"
that will not work on windows.=C2=A0
So I updated yo= ur patch with the change and it should be ready to merge.

Thanks Joao.
<= br>
Thanks
<= span class=3D"m_7164827823272182324HOEnZb">
Joa= o

On Tue, Mar 6, 2018 at 7:33 AM Khushb= oo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi Joao,

Thanks for reviewing.

On Thu, Mar 1, 2018 at 8:06 PM, Joao De Almeida Per= eira <jdealmeidapereira@pivotal.io> wrote:
Hello Kushboo,

<= div>Can we add some Unit test to ensure this does not happen again?

Please find the attached= patch with the unit tests.=C2=A0
Thanks
Joao

Thanks,
Khushboo=C2=A0
On Thu, Mar 1, 2018 at 2:28 AM Khushboo Vashi <khushboo.vashi@enterpr= isedb.com> wrote:
Hi,

Please find the attached patch to fix RM= # 3135 - [Web based] Syntax error displayed when user try to insert data o= n table where primray key is in captial letters and table contains OIDS

Thanks,
Khushboo
<= /div>



--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--f403043c3bf074c57a0566d4bf2b--