Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bNIWP-000054-DC for pgadmin-hackers@arkaria.postgresql.org; Wed, 13 Jul 2016 11:40:09 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bNIWN-0004k7-PY for pgadmin-hackers@arkaria.postgresql.org; Wed, 13 Jul 2016 11:40:07 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bNIWM-0004j1-UI for pgadmin-hackers@postgresql.org; Wed, 13 Jul 2016 11:40:07 +0000 Received: from mail-io0-x22d.google.com ([2607:f8b0:4001:c06::22d]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bNIWJ-0003fG-LT for pgadmin-hackers@postgresql.org; Wed, 13 Jul 2016 11:40:05 +0000 Received: by mail-io0-x22d.google.com with SMTP id b62so43390263iod.3 for ; Wed, 13 Jul 2016 04:40:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=eTIcY1md2YMTSBrf7+SjorH4PkIfW9envLFL2w0TMWk=; b=lVBiZtK7NUk1wnJAmTcsYX/z2+MiKrE5mrC1IXwCmTRTXGm8ORrh6bAuONdfYxn5Xa 0JxNk61rv3dxAUyj5hzGr16yhOijIBs9RoTG3vuGspOTZWsiDJaCsbeTx/wZEMDurR5A eqBVt/1R3q6SdCnSI8Wc6Oo8gxjBeAmgWifQy0Vzw/jpPAybTsWECCufq8IdKAdL5UQ7 1Q1WVmP5umZCCfo1FBjjJc0uL7t0V+zilso78q5DpShFsA/eKIs3udz+ev1o1S73q7j/ vJ00TMplAqaYoLntKU2jCj8qZcOBJkiFaqVxxpEhVYapiCJPbjr2lgqlvaeA74b7BZz4 vEQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=eTIcY1md2YMTSBrf7+SjorH4PkIfW9envLFL2w0TMWk=; b=PJ5XTFLBXwxz/k/fTZHZ6Wzl48fRtZDHOKpQNRBaiDsfCAf69GQT4yRshBObO1gUn7 C2guXliOVgy/qe9k0qLAuhAABCqNsESLI4J0z4PWWk0m/bEA9UmjrPHVv6MSa+hHThd/ b2//2ua25TlHuaSgQuQn9oT4VE/NDrW0IozTxFCKOMCvewyNOniAGP2Wtw8jZ/fWbFhW aMLdeQNk+EQsBBZpkLsIdeA8rzz7oh+e21W2nnQARBLDm9nXuJfBO7k9Eb/I0CPJQoNj tJLmb+N5umBNC5mEOaboTz4UFAk9r+JIrtWyettprhO/dIwPRHqJx169tR4jl6k729GB jaVg== X-Gm-Message-State: ALyK8tL/dhftysBar9C6WWeUYjOc8afxWAYWL4w6JY7tIU5qTYAImacFPjAovPxK+125HunMONUK+UMdRm+U6A== X-Received: by 10.107.205.129 with SMTP id d123mr8377950iog.70.1468410002635; Wed, 13 Jul 2016 04:40:02 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.208.97 with HTTP; Wed, 13 Jul 2016 04:40:01 -0700 (PDT) In-Reply-To: References: <70470862-26C1-4281-838E-F2C755E5C645@enterprisedb.com> <671D8CC8-C1D8-4CC1-BC32-431C496C4C5C@enterprisedb.com> From: Dave Page Date: Wed, 13 Jul 2016 12:40:01 +0100 Message-ID: Subject: Re: PATCH: Fix the issue for saving query output as CSV To: Harshal Dhumal Cc: Akshay Joshi , Murtuza Zabuawala , pgadmin-hackers Content-Type: multipart/alternative; boundary=94eb2c18a9c297b5c6053782d820 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --94eb2c18a9c297b5c6053782d820 Content-Type: text/plain; charset=UTF-8 Hi Can you rebase this please? Thanks. On Mon, Jul 11, 2016 at 9:16 AM, Harshal Dhumal < harshal.dhumal@enterprisedb.com> wrote: > Hi, > > PFA patch for RM1405. Also to allow download in runtime we will still need > patch > > sent by Neel. > > Changes: To download query result to CSV directly from server and not to > use download attr. of anchor tag () as it's not support by all of major > browsers (e.g. Safari). > Also it's not feasible to load data in html to download if result set of > query is very huge (in GBs). > > > > > > -- > *Harshal Dhumal* > *Software Engineer* > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Wed, Jun 29, 2016 at 4:53 PM, Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> >> >> On Wed, Jun 29, 2016 at 3:52 PM, Murtuza Zabuawala > enterprisedb.com> wrote: >> >>> Yes, It will not work in runtime as well but I think Neel is working for >>> fix in run time for this issue, We might able to fix it in run time but >>> issue persists in Safari unless they add support in browser itself. >>> >>> https://webkit.org/status/#feature-download-attribute >>> >>> >>> > On 29-Jun-2016, at 3:40 pm, Dave Page wrote: >>> > >>> > On Tue, Jun 28, 2016 at 10:33 AM, Murtuza Zabuawala >>> > wrote: >>> >> Yes Dave, I agree that downloading files has been supported in >>> browsers since long . >>> >> >>> >> But in general we send request & then receives files from web server >>> but in our case we are fetching our data from Backbone models & then >>> converting it to CSV format for downloading as a file at client side in >>> browser itself. >>> > >>> > If Safari doesn't support client-side saving of files, then I have to >>> > wonder if our runtime will either - both are webkit based. >>> > >>> > So I guess the next question to ask is; why don't we just generate the >>> > CSV on the server side? >>> > >>> >>> @Akshay, >>> Can you please suggest on above? >>> >> >> As we already have complete data in backgrid's full collection, so I >> have used it instead of fetching it again. >> >>> >>> > -- >>> > Dave Page >>> > Blog: http://pgsnake.blogspot.com >>> > Twitter: @pgsnake >>> > >>> > EnterpriseDB UK: http://www.enterprisedb.com >>> > The Enterprise PostgreSQL Company >>> >>> >>> >>> -- >>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>> To make changes to your subscription: >>> http://www.postgresql.org/mailpref/pgadmin-hackers >>> >> >> >> >> -- >> *Akshay Joshi* >> *Principal Software Engineer * >> >> >> >> *Phone: +91 20-3058-9517 <%2B91%2020-3058-9517>Mobile: +91 976-788-8246* >> > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --94eb2c18a9c297b5c6053782d820 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi

Can you rebase this please?

Thanks.

On Mon, Jul 11, 2016 at 9:16 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,

PFA patch = for RM1405. Also to allow download in runtime we will still need patch sent by N= eel.

Changes: To download query result to CSV directly fr= om server and not to use download attr. of anchor tag (<a>) as it'= ;s not support by all of major browsers (e.g. Safari).
Also it's not= feasible to load data in html to download if result set of query is very h= uge (in GBs).




= --=C2=A0
Harshal Dhumal
Software Engineer=

EnterpriseDB India:=C2=A0http://www.enterprisedb.com
The En= terprise PostgreSQL Company
<= /div>

On Wed, Jun 29, 2016 at 4:53 PM, Akshay Josh= i <akshay.joshi@enterprisedb.com> wrote:

=
On Wed, Jun 29, 2016 at 3:52 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wro= te:
Yes, It will not work in runtime as w= ell but I think Neel is working for fix in run time for this issue, We migh= t able to fix it in run time but issue persists in Safari unless they add s= upport in browser itself.

https://webkit.org/status/#feature-download-att= ribute


> On 29-Jun-2016, at 3:40 pm, Dave Page <dpage@pgadmin.org> wrote:
>
> On Tue, Jun 28, 2016 at 10:33 AM, Murtuza Zabuawala
> <murtuza.zabuawala@enterprisedb.com> wrote:
>> Yes Dave, I agree that downloading files has been supported in bro= wsers since long .
>>
>> But in general we send request & then receives files from web = server but in our case we are fetching our data from Backbone models & = then converting it to CSV format for downloading as a file at client side i= n browser itself.
>
> If Safari doesn't support client-side saving of files, then I have= to
> wonder if our runtime will either - both are webkit based.
>
> So I guess the next question to ask is; why don't we just generate= the
> CSV on the server side?
>

@Akshay,
Can you please suggest on above?

=C2=A0 =C2=A0As we already have complete data in backgrid's full collection, so I have used it instead of fetching it again. =C2=A0 = =C2=A0

> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company



--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=


--
Akshay Joshi
Principal Software Enginee= r=C2=A0

=

+91 20-3058-9517
Mobile: +91 976-788-8246




--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--94eb2c18a9c297b5c6053782d820--