Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sKCpf-008olP-4A for pgadmin-hackers@arkaria.postgresql.org; Thu, 20 Jun 2024 08:07:47 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1sKCoe-001yh7-Mf for pgadmin-hackers@arkaria.postgresql.org; Thu, 20 Jun 2024 08:06:45 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sKCoe-001ygz-Fe for pgadmin-hackers@lists.postgresql.org; Thu, 20 Jun 2024 08:06:45 +0000 Received: from mail-lf1-x134.google.com ([2a00:1450:4864:20::134]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1sKCoY-002DOW-4A for pgadmin-hackers@postgresql.org; Thu, 20 Jun 2024 08:06:44 +0000 Received: by mail-lf1-x134.google.com with SMTP id 2adb3069b0e04-52cc129c78fso506427e87.2 for ; Thu, 20 Jun 2024 01:06:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; t=1718870796; x=1719475596; darn=postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=UQusFLayCpMZawXCpXkx+USf0TFHslgBkiKcVh6rhmo=; b=LfSJJmJXsVyhPsU0x6B6SNWcTsOI1s0qJnSstvUZ9nD70LKda4B8xBTCKKx/unIi2I OaKdmKe5FPG8zuCY+uICV0awb67qldwf228ExY1W6atXLWVVlYROKmtIO7WRguxgm+6i pum3bu6I2BLSHaWEhg2E+QvpmS9qO4GtAEttyQ1VhLUn8JrN8ZII12bepV6JTlREslnK g78woCvvuepqUa/G8a9vHz1/9uhaIYjwgHDJqPowENpdqd8cn2ZKXHnQB7xEuaes117n X95j+q5E51mMDlQc5bsDDCn8Gd7lMCa9lXlMjVYAjcXB3pWtBMjur5Do/DOjyBaQhFju B4aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718870796; x=1719475596; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UQusFLayCpMZawXCpXkx+USf0TFHslgBkiKcVh6rhmo=; b=UkmXPHqW+0eCW7VzswPwGPD7k/KiEs3PJeoQYV8sp7+FWH99scFXqmG3WvSFPj5wnL qhMqHOSvwncBSCw5h9glk/1GekrqdJVfeVFA7gwYcNZdMaz0W1I349RJxWHdrQ63SoXF YrI+SmVplTr64+j3FcWwqOKQUkW4ub9qXeGRQX1a75XoPPxFBR7y+lIManCuOrC1/WGC TaXG4J8uXgxTd85yT7M9TvBFFfBzAAxkUMs4USVN6Ugg2sfICHtwpH8xkK5SQeKs1Cnu DwnebWWzAxYBLQBDMPrtD4rl0Ju1vKLQfAwexbPJ8hX17Jg6nM9jBm0OAo1XxchkE/PK +O0w== X-Gm-Message-State: AOJu0YyHrZxdu7FM3lvO4SSV18ITKyoBbDCBB0K+81HhYd3nkvw8u7CC 3vFkYdrv69maxnGn3IbpaTuQHhcejxcRzS0T6v46ggro3mise9DCZDbBUqz7Y65yy1/wlF9LLW9 I9X1qRc+QuX7iGGY4ommQBr9MnSqk7Q7uM/uY X-Google-Smtp-Source: AGHT+IEM0vysSpSoPTlINyCLds9KvjS5n67bN+Xo3+S/E2zEBGZtfeViEmjKPF9zAz3Dovl1U0NUUHDoIYTznk79wAM= X-Received: by 2002:ac2:5e91:0:b0:52c:b199:940b with SMTP id 2adb3069b0e04-52ccaa62a3emr2832805e87.32.1718870795727; Thu, 20 Jun 2024 01:06:35 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Thu, 20 Jun 2024 09:06:25 +0100 Message-ID: Subject: Re: Query tool data grid - Infinite scroll vs Pagination To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000031d004061b4dcbf4" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --00000000000031d004061b4dcbf4 Content-Type: text/plain; charset="UTF-8" Hi On Wed, 19 Jun 2024 at 13:42, Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > Query tool data grid currently pulls the data on load basis in batches. > For example, it will initially load only 1000 rows and once a user scrolls > to the 1000th row, it will fetch the next batch of 1000. > Many users who want access in between rows or last row struggle to do it > as the user has to scroll and scroll. If someone grabs the scroller and > pulls it down still it will be a good UX and the scrollbar may jump. One > reported here - https://github.com/pgadmin-org/pgadmin4/issues/1780 > One more aspect to this is the in memory data of the query tool which keep > on increasing on each scroll, it affects the performance. > > I propose we should use pagination instead of infinite scroll with the > following advantages: > 1. Users can jump to any page they want. > 2. Users can change the page size on the grid directly. > 3. Memory will be used only for visible rows so performance improvement. > 4. Predictable UI, no jumping scrollbars. > > Let me know what you think. > I think there are definite benefits, but there is the downside of having to scroll and click to browse results. Personally I'm fine with that, but I think you should probably poll pgadmin-support for opinions from more users. -- Dave Page pgAdmin: https://www.pgadmin.org PostgreSQL: https://www.postgresql.org EDB: https://www.enterprisedb.com --00000000000031d004061b4dcbf4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

On Wed, 19 Jun 2024 at 13:42, Aditya Toshniwal <= aditya.toshniwal@enter= prisedb.com> wrote:
Hi Hackers,

Query tool data grid currently pulls the data on load basis in ba= tches. For example, it will initially load only 1000 rows and once a user s= crolls to the 1000th row, it will fetch the next batch of 1000.
Many users who want access in betwe= en rows or last row struggle to do it as the user has to scroll and scroll.= If someone grabs the scroller and pulls it down still it will be a good UX= and the scrollbar may jump. One reported here -=C2=A0https://github= .com/pgadmin-org/pgadmin4/issues/1780
One more aspect to this is the in memory data of the= query tool which keep on increasing on each scroll, it affects the perform= ance.

I propose we should use pagination in= stead of infinite scroll with the following advantages:
1. Users can jump to any page they want.
2. Users can change the pa= ge size on the grid directly.
3. Memory will be used only for visible rows so performance improveme= nt.
4. Predictable UI, n= o jumping scrollbars.
Let me know what=C2= =A0you think.


<= /div>
I think there are definite benefits, but there is the downside of= having to scroll and click to browse results. Personally I'm fine with= that, but I think you should probably poll pgadmin-support for opinions fr= om more users.

-= -
--00000000000031d004061b4dcbf4--