Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fQ7VD-0003mY-N2 for pgadmin-hackers@arkaria.postgresql.org; Tue, 05 Jun 2018 08:39:40 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fQ7VC-0006MC-7e for pgadmin-hackers@arkaria.postgresql.org; Tue, 05 Jun 2018 08:39:38 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fQ7VB-0006LN-GR for pgadmin-hackers@lists.postgresql.org; Tue, 05 Jun 2018 08:39:38 +0000 Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fQ7V6-0007er-Hn for pgadmin-hackers@postgresql.org; Tue, 05 Jun 2018 08:39:36 +0000 Received: by mail-wm0-x244.google.com with SMTP id e16-v6so3244630wmd.0 for ; Tue, 05 Jun 2018 01:39:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=44X6fZ7sUIYAeGifLtEls3sKgwFxwLI2qOn3ozxMDxA=; b=J5/w/IUklMDkhpbNiMrrSh84xrUYkTAm++LkIxoj636ngTGVkJfn9HlaKWB7y/2s95 iLPrlYiUuazT3YpWH7TqubY8rTzjOsyP4b708kqAQ/c3DsZxjOefgbzFIOlX787NZtmZ +U9PSTpQ525seuqLaVHlkHc1kLOUAQmQccbKrASPcaSFX02hsJzSE6Dl1QfPtd1nY0SS 8vy7Gpj/lcGG97w9aXn8mp+rpbk5ksGf0hIviQ4DH+8TP01aUNyBEf15zG1dT2PbVGIY 3+A0kpx361ugnJ+IjrGInmiSn+kleMqVCQ0g/gRJiesMCoZXRXMLOLVN0Wv2w+lhW8Oo Vvdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=44X6fZ7sUIYAeGifLtEls3sKgwFxwLI2qOn3ozxMDxA=; b=Ek5yFKE8IjjTj6H63KKRPBQzlCEyAvKVVnFNBrsB86fKQuU6iNbUsbq6rexeNe9bdK sRqWLSg2XtM4gbrBCDk1jLJ/vzSBqqy5Q7k3jOO+C1WceVWRSi0jJVagOIRhQeodtFg1 TRaG+P0qrgU+eOTyjkF6iFnC8A2myXqcq0QR1y3e1wcNRE4hT9GRp5I8t46hcyG4kdJa f/9KfaF4Y5Ke+5C0gLAmNS5bLQ/p4OeRA2wIg3FBJgRDz4/fcUrAq+nh8IWq2e6M1JjC 0fVXsprt3zOZ8h9VdYQqAYxO4iNf6AtL54JNf9m4UrrwwRvcfQcxjCQHirhp1tTNQ/r5 5i8Q== X-Gm-Message-State: APt69E16lX3deIdcFwR8hdxgmuODh8bhtZU33NbRV3Ponbxbl4vLg1dj xo1lUR8byBTb63bQK22nJ7EcemUMv0hQIii5PqNWEA== X-Google-Smtp-Source: ADUXVKI0SpWs9dRnCEPXg2RNYn51ZXX0Q9tDpcy5/PZV/2MdgavM+QbVAuj4Xzr5p9j9Gw3tb6y6s0L8W6JRcQbuw6Q= X-Received: by 2002:a1c:b7d4:: with SMTP id h203-v6mr10935825wmf.161.1528187970787; Tue, 05 Jun 2018 01:39:30 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a1c:2907:0:0:0:0:0 with HTTP; Tue, 5 Jun 2018 01:39:30 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Tue, 5 Jun 2018 09:39:30 +0100 Message-ID: Subject: Re: [pgadmin4][Patch]: Test cases for the backup module To: Khushboo Vashi Cc: Joao De Almeida Pereira , Victoria Henry , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000262505056de0fda0" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000262505056de0fda0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Jun 5, 2018 at 9:37 AM, Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > > > On Tue, Jun 5, 2018 at 1:36 PM, Dave Page wrote: > >> Hi >> >> On Tue, Jun 5, 2018 at 4:39 AM, Khushboo Vashi < >> khushboo.vashi@enterprisedb.com> wrote: >> >>> >>> >>> On Mon, Jun 4, 2018 at 8:41 PM, Joao De Almeida Pereira < >>> jdealmeidapereira@pivotal.io> wrote: >>> >>>> Hi Khushboo, >>>> >>>> Some tests are failing in greenplum: >>>> https://gpdb-dev.bosh.pivotalci.info/teams/pgadmin/pipelines >>>> /pgadmin-patch/jobs/run-tests/builds/108 >>>> The piece of code responsible for the error is: >>>> >>>> if server['default_binary_paths'] is not None: >>>> test_utils.set_preference(server['default_binary_paths']) >>>> >>>> config.DEFAULT_BINARY_PATHS =3D { >>>> "pg": str(server['default_binary_paths']['pg']), >>>> "ppas": str(server['default_binary_paths']['ppas']), >>>> "gpdb": "" >>>> } >>>> >>>> >>>> Can you send me the test_config.json file? The above code sets the >>> paths to the SQLite database and through the logs couldn't figure out t= he >>> exact failure. >>> >> >> It seems clear from the code shown that it's not setting the binary path= s >> for gpdb database servers. Shouldn't it be something like: >> >> config.DEFAULT_BINARY_PATHS =3D { >> "pg": str(server['default_binary_paths']['pg']), >> "ppas": str(server['default_binary_paths']['ppas']), >> "gpdb": str(server['default_binary_paths']['gpdb']) >> } >> >> Without this code, the test cases should work as I already set paths > through below code. > > test_utils.set_preference(server['default_binary_paths']) > > In that case, why is the code above required at all? > >> >>> test_backup_utils.py file name is misleading, these are not tests, are >>>> helpers. >>>> =E2=80=8B >>>> >>>> >>>> Thanks >>>> Victoria & Joao >>>> >>>> On Mon, Jun 4, 2018 at 1:36 AM Khushboo Vashi < >>>> khushboo.vashi@enterprisedb.com> wrote: >>>> >>>>> >>>>> >>>>> On Sat, Jun 2, 2018 at 3:01 AM, Dave Page wrote: >>>>> >>>>>> Hi >>>>>> >>>>>> This looks good, except that it's leaving the test_restore_database >>>>>> behind. Can we clean that up please? >>>>>> >>>>>> PFA updated patch. >>>>> >>>>>> Thanks. >>>>>> >>>>>> On Fri, Jun 1, 2018 at 7:06 AM, Khushboo Vashi < >>>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi Victoria, >>>>>>> >>>>>>> Thanks for reviewing the patch. >>>>>>> The tests were failing due to the latest commit >>>>>>> #2b4605a9d390cb44e5dfe9967c3adf2b28d04f1f - Ensure >>>>>>> backup/restore/maintenance work via SSH tunnels. Fixes #3355 >>>>>>> >>>>>>> I have fixed the issues and attached the updated patch. >>>>>>> >>>>>>> Thanks, >>>>>>> Khushboo >>>>>>> >>>>>>> On Thu, May 31, 2018 at 10:00 PM, Victoria Henry >>>>>>> wrote: >>>>>>> >>>>>>>> Hi there, >>>>>>>> >>>>>>>> We've been noticing some issues with the tests on both our CI and >>>>>>>> local Mac workstations. >>>>>>>> >>>>>>>> 1. When the following code blocks are invoked - we get plenty >>>>>>>> of app.context() issues. It must not be valid when running >>>>>>>> tests. >>>>>>>> >>>>>>>> =E2=80=8B >>>>>>>> >>>>>>>> from pgadmin.utils.driver import get_driver >>>>>>>> driver =3D get_driver(PG_DEFAULT_DRIVER) >>>>>>>> manager =3D driver.connection_manager(self.sid) >>>>>>>> >>>>>>>> host =3D manager.local_bind_host if manager.use_ssh_tunnel else s.= host >>>>>>>> port =3D manager.local_bind_port if manager.use_ssh_tunnel else s.= port >>>>>>>> >>>>>>>> 2. When we finally enable >>>>>>>> >>>>>>>> "default_binary_paths": { >>>>>>>> >>>>>>>> in our test_config, we get more failing tests that look like: >>>>>>>> >>>>>>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>>>>>>> FAIL: runTest (pgadmin.tools.restore.tests.test_restore_create_job= _unit_test.RestoreCreateJobTest) >>>>>>>> When restore object with option - Miscellaneous >>>>>>>> ------------------------------------------------------------------= ---- >>>>>>>> Traceback (most recent call last): >>>>>>>> File "/Users/pivotal/.pyenv/versions/3.6.5/lib/python3.6/unittes= t/mock.py", line 1179, in patched >>>>>>>> return func(*args, **keywargs) >>>>>>>> File "/Users/pivotal/workspace/pgadmin4/web/pgadmin/tools/restor= e/tests/test_restore_create_job_unit_test.py", line 295, in runTest >>>>>>>> self.assertEquals(response.status_code, 200) >>>>>>>> AssertionError: 410 !=3D 200 >>>>>>>> >>>>>>>> And >>>>>>>> >>>>>>>> When restore object with the sections options ... 2018-05-31 12:24= :42,988: ERROR pgadmin: illegal environment variable name >>>>>>>> Traceback (most recent call last): >>>>>>>> File "/Users/pivotal/workspace/pgadmin4/web/pgadmin/tools/restor= e/__init__.py", line 352, in create_restore_job >>>>>>>> manager.export_password_env(p.id) >>>>>>>> File "/Users/pivotal/workspace/pgadmin4/web/pgadmin/utils/driver= /psycopg2/server_manager.py", line 365, in export_password_env >>>>>>>> os.environ[str(env)] =3D password >>>>>>>> File "/Users/pivotal/.pyenv/versions/3.6.5/lib/python3.6/os.py",= line 675, in __setitem__ >>>>>>>> self.putenv(key, value) >>>>>>>> ValueError: illegal environment variable name >>>>>>>> FAIL >>>>>>>> >>>>>>>> =E2=80=8B >>>>>>>> >>>>>>>> Sincerely, >>>>>>>> >>>>>>>> Victoria && Anthony >>>>>>>> >>>>>>>> On Thu, May 31, 2018 at 1:16 AM Khushboo Vashi < >>>>>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>>>>> >>>>>>>>> Hi, >>>>>>>>> >>>>>>>>> Please find the attached updated patch with the fixes. >>>>>>>>> The test cases were only failing on MAC not on Linux. >>>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> Khushboo >>>>>>>>> >>>>>>>>> On Wed, May 30, 2018 at 10:13 AM, Khushboo Vashi < >>>>>>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On Wed, May 30, 2018 at 1:05 AM, Dave Page >>>>>>>>>> wrote: >>>>>>>>>> >>>>>>>>>>> Hi >>>>>>>>>>> >>>>>>>>>>> On Mon, May 28, 2018 at 8:09 AM, Khushboo Vashi < >>>>>>>>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>>>>>>>> >>>>>>>>>>>> Hi, >>>>>>>>>>>> >>>>>>>>>>>> please find the attached updated patch for the test cases of >>>>>>>>>>>> Backup, Restore and Maintenance modules which includes: >>>>>>>>>>>> >>>>>>>>>>>> 1. Unit test cases >>>>>>>>>>>> 2. End to end regression test cases >>>>>>>>>>>> 3. Feature test cases >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> Thanks. I've yet to be able to run the feature tests >>>>>>>>>>> successfully. Here's what I've found so far: >>>>>>>>>>> >>>>>>>>>>> 1) DEFAULT_BINARY_PATHS should be default_binary_paths in the >>>>>>>>>>> JSON config file. >>>>>>>>>>> >>>>>>>>>>> Will do. >>>>>>>>>> >>>>>>>>>>> 2) I've hit screensize related issues: >>>>>>>>>>> >>>>>>>>>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>>>>>>>>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>>>>>>>>>> >>>>>>>>>>> ERROR: runTest (pgadmin.feature_tests.pg_util >>>>>>>>>>> ities_maintenance_test.PGUtilitiesMaintenanceFeatureTest) >>>>>>>>>>> >>>>>>>>>>> Test for PG maintenance: database >>>>>>>>>>> >>>>>>>>>>> ------------------------------------------------------------ >>>>>>>>>>> ---------- >>>>>>>>>>> >>>>>>>>>>> Traceback (most recent call last): >>>>>>>>>>> >>>>>>>>>>> File "/Users/dpage/git/pgadmin4/web >>>>>>>>>>> /pgadmin/feature_tests/pg_utilities_maintenance_test.py", line >>>>>>>>>>> 56, in runTest >>>>>>>>>>> >>>>>>>>>>> self._open_maintenance_dialogue() >>>>>>>>>>> >>>>>>>>>>> File "/Users/dpage/git/pgadmin4/web >>>>>>>>>>> /pgadmin/feature_tests/pg_utilities_maintenance_test.py", line >>>>>>>>>>> 75, in _open_maintenance_dialogue >>>>>>>>>>> >>>>>>>>>>> "*[.=3D'" + self.table_name + "']/../*[@class=3D'aciTreeIte= m'" >>>>>>>>>>> >>>>>>>>>>> File "/Users/dpage/.virtualenvs/pga >>>>>>>>>>> dmin4/lib/python2.7/site-packages/selenium/webdriver/remote/web= element.py", >>>>>>>>>>> line 80, in click >>>>>>>>>>> >>>>>>>>>>> self._execute(Command.CLICK_ELEMENT) >>>>>>>>>>> >>>>>>>>>>> File "/Users/dpage/.virtualenvs/pga >>>>>>>>>>> dmin4/lib/python2.7/site-packages/selenium/webdriver/remote/web= element.py", >>>>>>>>>>> line 628, in _execute >>>>>>>>>>> >>>>>>>>>>> return self._parent.execute(command, params) >>>>>>>>>>> >>>>>>>>>>> File "/Users/dpage/.virtualenvs/pga >>>>>>>>>>> dmin4/lib/python2.7/site-packages/selenium/webdriver/remote/web= driver.py", >>>>>>>>>>> line 312, in execute >>>>>>>>>>> >>>>>>>>>>> self.error_handler.check_response(response) >>>>>>>>>>> >>>>>>>>>>> File "/Users/dpage/.virtualenvs/pga >>>>>>>>>>> dmin4/lib/python2.7/site-packages/selenium/webdriver/remote/err= orhandler.py", >>>>>>>>>>> line 242, in check_response >>>>>>>>>>> >>>>>>>>>>> raise exception_class(message, screen, stacktrace) >>>>>>>>>>> >>>>>>>>>>> WebDriverException: Message: unknown error: Element >>>>>>>>>> class=3D"aciTreeItem">... is not clickable at point (223= , 604). Other >>>>>>>>>>> element would receive the click:
>>>>>>>>>> wcPanelBackground wcScrollableX wcScrollableY" style=3D"left: 0= px; right: >>>>>>>>>>> 0px; bottom: 0px;">...
>>>>>>>>>>> >>>>>>>>>>> (Session info: chrome=3D66.0.3359.181) >>>>>>>>>>> >>>>>>>>>>> (Driver info: chromedriver=3D2.38.552518 >>>>>>>>>>> (183d19265345f54ce39cbb94cf81ba5f15905011),platform=3DMac OS X >>>>>>>>>>> 10.12.6 x86_64) >>>>>>>>>>> >>>>>>>>>>> 3) One time the test did start, but then I saw this failure: >>>>>>>>>>> >>>>>>>>>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>>>>>>>>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>>>>>>>>>> >>>>>>>>>>> ERROR: runTest (pgadmin.feature_tests.pg_util >>>>>>>>>>> ities_backup_restore_test.PGUtilitiesBackupFeatureTest) >>>>>>>>>>> >>>>>>>>>>> Test for PG utilities - Backup and Restore >>>>>>>>>>> >>>>>>>>>>> ------------------------------------------------------------ >>>>>>>>>>> ---------- >>>>>>>>>>> >>>>>>>>>>> Traceback (most recent call last): >>>>>>>>>>> >>>>>>>>>>> File "/Users/dpage/git/pgadmin4/web >>>>>>>>>>> /pgadmin/feature_tests/pg_utilities_backup_restore_test.py", >>>>>>>>>>> line 93, in runTest >>>>>>>>>>> >>>>>>>>>>> self.page.fill_input_by_field_name("file", >>>>>>>>>>> "test_backup_file") >>>>>>>>>>> >>>>>>>>>>> File "/Users/dpage/git/pgadmin4/web >>>>>>>>>>> /regression/feature_utils/pgadmin_page.py", line 211, in >>>>>>>>>>> fill_input_by_field_name >>>>>>>>>>> >>>>>>>>>>> self.wait_for_input_field_content(field_name, field_content= ) >>>>>>>>>>> >>>>>>>>>>> File "/Users/dpage/git/pgadmin4/web >>>>>>>>>>> /regression/feature_utils/pgadmin_page.py", line 251, in >>>>>>>>>>> wait_for_input_field_content >>>>>>>>>>> >>>>>>>>>>> "field to contain '" + str(content) + "'", >>>>>>>>>>> input_field_has_content >>>>>>>>>>> >>>>>>>>>>> File "/Users/dpage/git/pgadmin4/web >>>>>>>>>>> /regression/feature_utils/pgadmin_page.py", line 337, in >>>>>>>>>>> _wait_for >>>>>>>>>>> >>>>>>>>>>> "Timed out waiting for " + waiting_for_message >>>>>>>>>>> >>>>>>>>>>> File "/Users/dpage/.virtualenvs/pga >>>>>>>>>>> dmin4/lib/python2.7/site-packages/selenium/webdriver/support/wa= it.py", >>>>>>>>>>> line 80, in until >>>>>>>>>>> >>>>>>>>>>> raise TimeoutException(message, screen, stacktrace) >>>>>>>>>>> >>>>>>>>>>> TimeoutException: Message: Timed out waiting for field to >>>>>>>>>>> contain 'test_backup_file' >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> (with screenshot attached) >>>>>>>>>>> >>>>>>>>>>> Thanks. >>>>>>>>>>> >>>>>>>>>>> I have ran the feature tests with multiple servers many times >>>>>>>>>> but didn't get a single failure. >>>>>>>>>> I have asked Akshay to run on his machine, let see what he gets. >>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Thanks, >>>>>>>>>>>> Khushboo >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> On Wed, Apr 25, 2018 at 9:40 PM, Joao De Almeida Pereira < >>>>>>>>>>>> jdealmeidapereira@pivotal.io> wrote: >>>>>>>>>>>> >>>>>>>>>>>>> Hi Khushboo, >>>>>>>>>>>>> >>>>>>>>>>>>> We reviewed the patch and it is very nice to see some more >>>>>>>>>>>>> coverage in this area. Good job :D >>>>>>>>>>>>> >>>>>>>>>>>>> We passed the tests through our CI the feature tests are not >>>>>>>>>>>>> passing, but the linter fails: >>>>>>>>>>>>> >>>>>>>>>>>>> ./pgadmin/feature_tests/pg_utilities_backup_test.py:37: [E501= ] line too long (91 > 79 characters) >>>>>>>>>>>>> >>>>>>>>>>>>> ./pgadmin/feature_tests/pg_utilities_backup_test.py:53: [E501= ] line too long (104 > 79 characters) >>>>>>>>>>>>> >>>>>>>>>>>>> ./pgadmin/feature_tests/pg_utilities_backup_test.py:59: [E501= ] line too long (85 > 79 characters) >>>>>>>>>>>>> >>>>>>>>>>>>> ./pgadmin/feature_tests/pg_utilities_backup_test.py:62: [E501= ] line too long (96 > 79 characters) >>>>>>>>>>>>> >>>>>>>>>>>>> ./pgadmin/feature_tests/pg_utilities_backup_test.py:63: [E501= ] line too long (91 > 79 characters) >>>>>>>>>>>>> >>>>>>>>>>>>> ./pgadmin/feature_tests/pg_utilities_backup_test.py:70: [E501= ] line too long (118 > 79 characters) >>>>>>>>>>>>> >>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_backup_message.py:37: [E121= ] continuation line under-indented for hanging indent >>>>>>>>>>>>> >>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_backup_message.py:48: [E122= ] continuation line missing indentation or outdented >>>>>>>>>>>>> >>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_backup_message.py:49: [E251= ] unexpected spaces around keyword / parameter equals >>>>>>>>>>>>> >>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_backup_message.py:49: [E251= ] unexpected spaces around keyword / parameter equals >>>>>>>>>>>>> >>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_backup_message.py:51: [E501= ] line too long (91 > 79 characters) >>>>>>>>>>>>> >>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_backup_message.py:52: [E501= ] line too long (94 > 79 characters) >>>>>>>>>>>>> >>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_backup_message.py:53: [E501= ] line too long (108 > 79 characters) >>>>>>>>>>>>> >>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_backup_message.py:81: [E501= ] line too long (113 > 79 characters) >>>>>>>>>>>>> >>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_backup_message.py:82: [E501= ] line too long (94 > 79 characters) >>>>>>>>>>>>> >>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_backup_message.py:83: [E501= ] line too long (108 > 79 characters) >>>>>>>>>>>>> >>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_backup_message.py:111: [E50= 1] line too long (100 > 79 characters) >>>>>>>>>>>>> >>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_backup_message.py:113: [E50= 1] line too long (94 > 79 characters) >>>>>>>>>>>>> >>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_backup_message.py:114: [E50= 1] line too long (108 > 79 characters) >>>>>>>>>>>>> >>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_backup_message.py:147: [E50= 1] line too long (93 > 79 characters) >>>>>>>>>>>>> >>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_batch_process.py:40: [E121]= continuation line under-indented for hanging indent >>>>>>>>>>>>> >>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_batch_process.py:51: [E122]= continuation line missing indentation or outdented >>>>>>>>>>>>> >>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_batch_process.py:135: [E501= ] line too long (80 > 79 characters) >>>>>>>>>>>>> >>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_batch_process.py:137: [E501= ] line too long (83 > 79 characters) >>>>>>>>>>>>> >>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_batch_process.py:138: [E122= ] continuation line missing indentation or outdented >>>>>>>>>>>>> >>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_batch_process.py:139: [E122= ] continuation line missing indentation or outdented >>>>>>>>>>>>> >>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_batch_process.py:140: [E122= ] continuation line missing indentation or outdented >>>>>>>>>>>>> >>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_batch_process.py:191: [E501= ] line too long (81 > 79 characters) >>>>>>>>>>>>> >>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_batch_process.py:203: [E501= ] line too long (80 > 79 characters) >>>>>>>>>>>>> >>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_batch_process.py:204: [E128= ] continuation line under-indented for visual indent >>>>>>>>>>>>> >>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_batch_process.py:204: [E501= ] line too long (94 > 79 characters) >>>>>>>>>>>>> >>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_batch_process.py:205: [E128= ] continuation line under-indented for visual indent >>>>>>>>>>>>> >>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_batch_process.py:205: [E501= ] line too long (94 > 79 characters) >>>>>>>>>>>>> >>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_batch_process.py:216: [W391= ] blank line at end of file >>>>>>>>>>>>> >>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_create_backup_job.py:296: [= E501] line too long (97 > 79 characters) >>>>>>>>>>>>> >>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_create_backup_job.py:317: [= E303] too many blank lines (2) >>>>>>>>>>>>> >>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_create_backup_job.py:336: [= E501] line too long (84 > 79 characters) >>>>>>>>>>>>> >>>>>>>>>>>>> ./pgadmin/tools/backup/tests/test_create_backup_job.py:371: [= W391] blank line at end of file >>>>>>>>>>>>> >>>>>>>>>>>>> 2 E121 continuation line under-indented for hanging ind= ent >>>>>>>>>>>>> >>>>>>>>>>>>> 5 E122 continuation line missing indentation or outdent= ed >>>>>>>>>>>>> >>>>>>>>>>>>> 2 E128 continuation line under-indented for visual inde= nt >>>>>>>>>>>>> >>>>>>>>>>>>> 2 E251 unexpected spaces around keyword / parameter equ= als >>>>>>>>>>>>> >>>>>>>>>>>>> 1 E303 too many blank lines (2) >>>>>>>>>>>>> >>>>>>>>>>>>> 24 E501 line too long (91 > 79 characters) >>>>>>>>>>>>> >>>>>>>>>>>>> 2 W391 blank line at end of file >>>>>>>>>>>>> >>>>>>>>>>>>> 38 >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> For the feature tests, we realized we had to update the >>>>>>>>>>>>> configuration, and we did that, but we get the following erro= r attached. We >>>>>>>>>>>>> spent some time trying to understand the problem but we were = not successful. >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> Codewise: >>>>>>>>>>>>> - We just found some One Letter Variables in the code... >>>>>>>>>>>>> - Looks like there is a bug report in this area of the code >>>>>>>>>>>>> and we do not have coverage for it: https://redmine.postgresq= l >>>>>>>>>>>>> .org/issues/3232 >>>>>>>>>>>>> Looks like in some of the unit tests we only have happy pat= h >>>>>>>>>>>>> tests, maybe we should see if there are any sad paths that al= so need >>>>>>>>>>>>> coverage. >>>>>>>>>>>>> >>>>>>>>>>>>> The configuration change, maybe need to be updated. When we >>>>>>>>>>>>> install multiple versions of postgres the binaries live in >>>>>>>>>>>>> `/usr/lib/postgresql/{{db_version}}/bin`, which makes us >>>>>>>>>>>>> think that this configuration should live near the server con= figuration, >>>>>>>>>>>>> maybe? Also to maintain coherency on the naming maybe we shou= ld make it all >>>>>>>>>>>>> lower case. >>>>>>>>>>>>> Just as an aside, you can add the gpdb configuration as well >>>>>>>>>>>>> in you patch. >>>>>>>>>>>>> >>>>>>>>>>>>> Thanks >>>>>>>>>>>>> Victoria & Joao >>>>>>>>>>>>> >>>>>>>>>>>>> On Wed, Apr 25, 2018 at 5:20 AM Khushboo Vashi < >>>>>>>>>>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>>>>>>>>>> >>>>>>>>>>>>>> Hi, >>>>>>>>>>>>>> >>>>>>>>>>>>>> Please find the attached patch which covers test cases for >>>>>>>>>>>>>> the backup module (RM #3206). >>>>>>>>>>>>>> >>>>>>>>>>>>>> 1. Unit test cases >>>>>>>>>>>>>> 2. End to end regression test cases >>>>>>>>>>>>>> 3. Feature test cases >>>>>>>>>>>>>> >>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>> Khushboo >>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> Dave Page >>>>>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>>>>> Twitter: @pgsnake >>>>>>>>>>> >>>>>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>>>>>> The Enterprise PostgreSQL Company >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Dave Page >>>>>> Blog: http://pgsnake.blogspot.com >>>>>> Twitter: @pgsnake >>>>>> >>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>> >>>>> >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > --=20 Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --000000000000262505056de0fda0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Tue, Jun 5, 2018 at 9:37 AM, Khushboo Vashi <khushboo= .vashi@enterprisedb.com> wrote:


On Tue, Jun 5, 2018 at 1:36 PM, Dave Page <dpage= @pgadmin.org> wrote:
Hi

On Tue, Jun 5, 2018 at 4:39 AM, Khushboo Vash= i <khushboo.vashi@enterprisedb.com> wrote= :


On Mon, Jun 4, 2018 at 8:41 P= M, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io>= ; wrote:
H= i Khushboo,

Some tests are failing in greenplum:
The piece of code responsible = for the error is:
if server['default_binary_paths'] is not None:
    test_utils.set_preference(s=
erver['default_binary_paths&=
#39;])

    config.DEFAULT_BINARY_PATHS =3D {
        "pg": str(server['default_binary_paths']['pg']),
        "ppas": str(server['defau=
lt_binary_paths'][=
9;ppas']),
        "gpdb": &=
quot;"
    }
Can you send me the test_config= .json file?=C2=A0 The above code sets the paths to the SQLite database and = through the logs couldn't figure out the exact failure.=C2=A0

It seems clear from t= he code shown that it's not setting the binary paths for gpdb database = servers. Shouldn't it be something like:

    config=
.DEFAULT_BINARY_PATHS =3D {
        "pg": str(=
server['default_binary_paths=
']['pg']),
        "ppas&=
quot;: str(server['default_binary_paths']['ppas']),
        "gpdb&qu=
ot;: str(server['default_binary_paths']['gpdb'])
    }
Without this code, the test cases should work as I already set=C2= =A0 paths through below code.
    test_utils.set_preference(server['default_binary_paths'])
<= div class=3D"gmail_extra">
<= /blockquote>

= In that case, why is the code above required at all?

=C2=A0
=C2=A0<= /div>
=

test_backup_utils.py fi= le name is misleading, these are not tests, are helpers.

=E2=80=8B
=


Thanks
Victoria &a= mp; Joao

On Mon, Jun 4, 2018 at 1:36 AM Khushboo Vashi <khushboo.vashi@enter= prisedb.com> wrote:


On Sat, Jun 2, 2018 at 3:01 AM, Dave Page <dpage@pgadmin.org> wrote:
Hi

This looks good, except that it's leaving the test_restore_data= base behind. Can we clean that up please?

PFA updated patch.=C2=A0
Thanks.

On Fri, Jun 1,= 2018 at 7:06 AM, Khushboo Vashi <khushboo.vashi@enterprised= b.com> wrote:
Hi Victoria,

Thanks for reviewing the patch.
The tests were failing due to the latest commit #2b4605a9d390cb44e5= dfe9967c3adf2b28d04f1f=C2=A0 - Ensure backup/restore/maintenance work = via SSH tunnels. Fixes #3355

I have fixed the issu= es and attached the updated patch.

Thanks,
Khushboo=C2=A0

On Thu, May 31, 2018 at 10:00 PM, Victoria Henry <vhenry@pivotal= .io> wrote:
Hi there,

We've been noticing some issues with the= tests on both our CI and local Mac workstations.
  1. When the following code blocks are invoked -= we get plenty of app.context() issues. It must not= be valid when running tests.
=E2=80=8B
= 
from pgadmin.utils.driver import get_driver
driver =3D get_driver(PG_DEFAULT_DR=
IVER)
manager =3D driver.connection_manager(self.sid)

host =3D manager.local_bind_host if manager.use_ssh_tunnel else s.host
port =3D manager.local=
_bind_port if manager.use_ssh_=
tunnel else s.port=C2=A0
=
2. When we finally enable=C2=A0
"default_binary_=
paths": {
in our test_config, we get more failing tests that look like:
= 
=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
FAIL: runTest (pgadmin.tools.restore.tests.test_restore_create_job_uni=
t_test.RestoreCreateJobTest)
When restore object with option - Miscellaneous
-----------------------------------------------------------------=
-----
Traceback (most recent call last):
  File "/Users/pivotal/.pyenv/versions/3.6.5/lib/python3.6/unitte=
st/mock.py", line 1179, in patched
    return func(*args, **keywargs)
  File "/Users/pivotal/workspace/pgadmin4/web/pgadmin/tools/resto=
re/tests/test_restore_create_job_unit_test.py", line 295, in=
 runTest
    self.assertEquals(response.status_code, 200)
AssertionError: 410 !=3D 200

And

When restore object =
with the sections options ... 2018-05-31 12:24:42,988: ERROR    pgadmin:   =
 illegal environment variable name
Traceback (most recent call last):
  File "/Users/pivotal/workspace/pgadmin4/web/pgadmin/tools/resto=
re/__init__.py", line 352, in create_restore_job
    manager.export_password_env(p=
.id)
  File "/Users/pivotal/workspace/pgadmin4/web/pgadmin/utils/drive=
r/psycopg2/server_manager.py", line 365, in export_password_env
    os.environ[str(env)] =3D password
  File "/Users/pivotal/.pyenv/versions/3.6.5/lib/python3.6/os.py&=
quot;, line 675, in __setitem__
    self.putenv(key, value)
ValueError: illegal environment variable name
FAIL
=E2=80=8B
=

Sincerely,

Vi= ctoria && Anthony

On Thu, May 31, 2018 at 1= :16 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
=
Hi,

Please find the attached updated patch with the fixes.
The test= cases were only failing on MAC not on Linux.

Than= ks,
Khushboo

On Wed, May 30, 2018 at 10:13 AM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:

On Wed, May 30, 2018 at 1:05 AM, Dave Pa= ge <dpage@pgadmin.org> wrote:
Hi

On Mon, May 28, 2018 at 8:09 AM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

please find the attached updated patch for the test cases of Backup, Res= tore and Maintenance modules which includes:

1. Unit test cases
2. End to end regression test cases=C2=A0
3. = Feature test cases

Thanks. I've yet to be able to run the feature tests successful= ly. Here's what I've found so far:

1) DEFA= ULT_BINARY_PATHS should be default_binary_paths in the JSON config file.

Will do.=C2=A0=
2) I've hit screensize related iss= ues:

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D

ERROR: runTest (pgadmin.feature_tes= ts.pg_utilities_maintenance_test.PGUtilitiesMaintenanceFeatureTes= t)

Test for PG maintenance: database

------------------------------= ----------------------------------------

Traceback (most recent call last):<= /span>

=C2=A0 File "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/pg_utilities_maintenance_test.py", line = 56, in runTest

=C2=A0 =C2=A0 self._open_maintenance_dialogue= ()

=C2=A0 File "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/pg_utilities_maintenance_test.py", line = 75, in _open_maintenance_dialogue

=C2=A0 =C2=A0 "*[.=3D'" + self.table= _name + "']/../*[@class=3D'aciTreeItem'"

=C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/web= element.py", line 80, in click

=C2=A0 =C2=A0 self._execute(Command.CLICK_ELE= MENT)

=C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/web= element.py", line 628, in _execute

=C2=A0 =C2=A0 return self._parent.execute(command,= params)

=C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/web= driver.py", line 312, in execute

=C2=A0 =C2=A0 self.error_handler.check_respon= se(response)

=C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/err= orhandler.py", line 242, in check_response

=C2=A0 =C2=A0 raise exception_class(message, scree= n, stacktrace)

WebDriverException: Message: unknow= n error: Element <span class=3D"aciTreeItem">...</span&g= t; is not clickable at point (223, 604). Other element would receive the cl= ick: <div class=3D"wcFrameCenter wcPanelBackground wcScrollableX wc= ScrollableY" style=3D"left: 0px; right: 0px; bottom: 0px;"&g= t;...</div>

=C2=A0 (Session info: chrome=3D66.0.3359.181)

=C2=A0 (Driver info: chromedriver=3D2.38.552518 (1= 83d19265345f54ce39cbb94cf81ba5f15905011),platform=3DMac OS X 10.12.6 x= 86_64)


3) One time the test did start, but then I saw this failure:=

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D

ERROR: runTest (pgadmin.feature_tes= ts.pg_utilities_backup_restore_test.PGUtilitiesBackupFeatureTest)=

Test for PG utilities - Backup and = Restore

------------------------------= ----------------------------------------

Traceback (most recent call last):<= /span>

=C2=A0 File "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/pg_utilities_backup_restore_test.py", li= ne 93, in runTest

=C2=A0 =C2=A0 self.page.fill_input_by_field_n= ame("file", "test_backup_file")

=C2=A0 File "/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py", line 211, in fill_i= nput_by_field_name

=C2=A0 =C2=A0 self.wait_for_input_field_conte= nt(field_name, field_content)

=C2=A0 File "/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py", line 251, in wait_f= or_input_field_content

=C2=A0 =C2=A0 "field to contain '" += str(content) + "'", input_field_has_content

=C2=A0 File "/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py", line 337, in _wait_= for

=C2=A0 =C2=A0 "Timed out waiting for " += waiting_for_message

=C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/support/wa= it.py", line 80, in until

=C2=A0 =C2=A0 raise TimeoutException(message, scre= en, stacktrace)

TimeoutException: Message: Timed ou= t waiting for field to contain 'test_backup_file'



(with screenshot attached)

Thanks.<= /div>

I have ran the feature tests with multiple servers many time= s but didn't get a single failure.
I have asked Akshay to run= on his machine, let see what he gets.
=


=C2=A0

Thanks,
Khushboo
<= br>



On Wed, Apr 25, 2018 at 9:40 PM, Joao De Almeida Pereira = <jdealmeidapereira@pivotal.io> wrote:
Hi Khushboo,

We = reviewed the patch and it is very nice to see some more coverage in this ar= ea. Good job :D

We passed the tests through our CI= the feature tests are not passing, but the linter fails:
./pgadmin/feature_tests/pg_utilities_ba=
ckup_test.py:37: [E501] line too long (91 > 79 characters)

./pgadmin/feature_tests/pg_utilities_backup_test.py:53: [E501] line t=
oo long (104 > 79 characters)

./pgadmin/feature_tests/pg_utilities_backup_test.py:59: [E501] line t=
oo long (85 > 79 characters)

./pgadmin/feature_tests/pg_utilities_backup_test.py:62: [E501] line t=
oo long (96 > 79 characters)

./pgadmin/feature_tests/pg_utilities_backup_test.py:63: [E501] line t=
oo long (91 > 79 characters)

./pgadmin/feature_tests/pg_utilities_backup_test.py:70: [E501] line t=
oo long (118 > 79 characters)

./pgadmin/tools/backup/tests/test_backup_message.py:37: [E121] contin=
uation line under-indented for hanging indent

./pgadmin/tools/backup/tests/test_backup_message.py:48: [E122] contin=
uation line missing indentation or outdented

./pgadmin/tools/backup/tests/test_backup_message.py:49: [E251] unexpe=
cted spaces around keyword / parameter equals

./pgadmin/tools/backup/tests/test_backup_message.py:49: [E251] unexpe=
cted spaces around keyword / parameter equals

./pgadmin/tools/backup/tests/test_backup_message.py:51: [E501] line t=
oo long (91 > 79 characters)

./pgadmin/tools/backup/tests/test_backup_message.py:52: [E501] line t=
oo long (94 > 79 characters)

./pgadmin/tools/backup/tests/test_backup_message.py:53: [E501] line t=
oo long (108 > 79 characters)

./pgadmin/tools/backup/tests/test_backup_message.py:81: [E501] line t=
oo long (113 > 79 characters)

./pgadmin/tools/backup/tests/test_backup_message.py:82: [E501] line t=
oo long (94 > 79 characters)

./pgadmin/tools/backup/tests/test_backup_message.py:83: [E501] line t=
oo long (108 > 79 characters)

./pgadmin/tools/backup/tests/test_backup_message.py:111: [E501] line =
too long (100 > 79 characters)

./pgadmin/tools/backup/tests/test_backup_message.py:113: [E501] line =
too long (94 > 79 characters)

./pgadmin/tools/backup/tests/test_backup_message.py:114: [E501] line =
too long (108 > 79 characters)

./pgadmin/tools/backup/tests/test_backup_message.py:147: [E501] line =
too long (93 > 79 characters)

./pgadmin/tools/backup/tests/test_batch_process.py:40: [E121] continu=
ation line under-indented for hanging indent

./pgadmin/tools/backup/tests/test_batch_process.py:51: [E122] continu=
ation line missing indentation or outdented

./pgadmin/tools/backup/tests/test_batch_process.py:135: [E501] line t=
oo long (80 > 79 characters)

./pgadmin/tools/backup/tests/test_batch_process.py:137: [E501] line t=
oo long (83 > 79 characters)

./pgadmin/tools/backup/tests/test_batch_process.py:138: [E122] contin=
uation line missing indentation or outdented

./pgadmin/tools/backup/tests/test_batch_process.py:139: [E122] contin=
uation line missing indentation or outdented

./pgadmin/tools/backup/tests/test_batch_process.py:140: [E122] contin=
uation line missing indentation or outdented

./pgadmin/tools/backup/tests/test_batch_process.py:191: [E501] line t=
oo long (81 > 79 characters)

./pgadmin/tools/backup/tests/test_batch_process.py:203: [E501] line t=
oo long (80 > 79 characters)

./pgadmin/tools/backup/tests/test_batch_process.py:204: [E128] contin=
uation line under-indented for visual indent

./pgadmin/tools/backup/tests/test_batch_process.py:204: [E501] line t=
oo long (94 > 79 characters)

./pgadmin/tools/backup/tests/test_batch_process.py:205: [E128] contin=
uation line under-indented for visual indent

./pgadmin/tools/backup/tests/test_batch_process.py:205: [E501] line t=
oo long (94 > 79 characters)

./pgadmin/tools/backup/tests/test_batch_process.py:216: [W391] blank =
line at end of file

./pgadmin/tools/backup/tests/test_create_backup_job.py:296: [E501] li=
ne too long (97 > 79 characters)

./pgadmin/tools/backup/tests/test_create_backup_job.py:317: [E303] to=
o many blank lines (2)

./pgadmin/tools/backup/tests/test_create_backup_job.py:336: [E501] li=
ne too long (84 > 79 characters)

./pgadmin/tools/backup/tests/test_create_backup_job.py:371: [W391] bl=
ank line at end of file

2       E121 continuation line under-indented for hanging indent

5       E122 continuation line missing indentation or outdented

2       E128 continuation line under-indented for visual indent

2       E251 unexpected spaces around keyword / parameter equals

1       E303 too many blank lines (2)

24      E501 line too long (91 > 79 characters)

2       W391 blank line at end of file

38

For the feature tests,= we realized we had to update the configuration, and we did that, but we ge= t the following error attached. We spent some time trying to understand the= problem but we were not successful.


Codewise:
- We just found some One Letter Variables in the code= ...
- Looks like there is a bug report in this area of the code a= nd we do not have coverage for it:=C2=A0https://redmine.postgresql.org/i= ssues/3232
=C2=A0 Looks like in some of the unit tests we onl= y have happy path tests, maybe we should see if there are any sad paths tha= t also need coverage.

The configuration change, ma= ybe need to be updated. When we install multiple versions of postgres the b= inaries live in `/usr/lib/postgresql/{{db_version}}/bin`, which makes = us think that this configuration should live near the server configuration,= maybe? Also to maintain coherency on the naming maybe we should make it al= l lower case.
Just as an aside, you can add the gpdb configuratio= n as well in you patch.

Thanks
Victoria = & Joao

<= div class=3D"gmail_quote">
On Wed, Apr 25, 2018 at 5:20 AM = Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px= #ccc solid;padding-left:1ex">
Hi,

Pleas= e find the attached patch which covers test cases for the backup module (RM= #3206).

1. Unit test cases
2. End to en= d regression test cases=C2=A0
3. Feature test cases
Thanks,
Khushboo




--
Dave Page
Blog: http://pgsnake.blogspot.com=
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Ent= erprise PostgreSQL Company






--
=
Dave Page
Blog: http://pgsnake.blogspot.com<= /a>
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Ente= rprise PostgreSQL Company


=


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseD= B UK: http://www.= enterprisedb.com
The Enterprise PostgreSQL Company




--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--000000000000262505056de0fda0--