Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iPTT0-00073J-JN for pgadmin-hackers@arkaria.postgresql.org; Tue, 29 Oct 2019 15:31:30 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iPTSx-0004a0-VX for pgadmin-hackers@arkaria.postgresql.org; Tue, 29 Oct 2019 15:31:27 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iPTSx-0004Zs-EK for pgadmin-hackers@lists.postgresql.org; Tue, 29 Oct 2019 15:31:27 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iPTSt-0001da-If for pgadmin-hackers@postgresql.org; Tue, 29 Oct 2019 15:31:26 +0000 Received: by mail-wm1-x342.google.com with SMTP id r141so2871696wme.4 for ; Tue, 29 Oct 2019 08:31:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9GD1MD2ymaqODisccd03BdZ/brCaYYePjtRr/4zj4K0=; b=Mt+WYzKtOQw0vWEmw9YQzwz8m0SGXZdWGZfB/PpYzvW5TzmtQUa6vP+y4FDWctvEjL MuQtkp+RuwMfq2yTVMnCf+hrYmsqQpDcCDUbQnaa/CyetKydbiEKpbwYILYUiTHATU12 PiqvBv9STXMnR+CVJhaDinfKUi81Hs6bUmtmTGBn32oj5rrfkE45yNQWP2WcfSVuFMg8 yLBciBjTd+DMqw+ugooXu8WcEaWfdv2AzthjtA4qsEkfoiDL4RgBu3CckHwUpKivQ1Hn 5OEsvVHFb/4oS0voXp57qI8ZMIIxRFaJgSswb8DzlBbGwGGU7RaH2h+IrPoXAG9vMs5d XJfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9GD1MD2ymaqODisccd03BdZ/brCaYYePjtRr/4zj4K0=; b=MCrFbcuMXhO57THQuVmcVROpPUAT3wko5sVo9Ih25EaAWiqmgXqVMC8dVfoNB+l/1h zhkPiPEsoDtomzF/sNPOxuMODvJx0ThPw9LX7LrnwJZWbvv/BsFQOJY1xiMMCDlH7gYe BXGc7Dwsd4r72kjNB1nj/FgEBiPBll1wdSP2W26mDs0+c/DdXRe8cH19xu8PKyLhP6Sc S8fc0uWaeCSpZ1EX3uhJTAH5Q//ePFN8uqgLR6tQl3FnIO1se4IR7+9M3g21gI4FM5jI KB389JjoxzyIpe6jqKPSpbTp5uomQvuqyNj7pf/h3MN/NKEUbbnzcNANXB8RnmH5OS+B 4Zcw== X-Gm-Message-State: APjAAAVj/sZ8I/s8Wmyo4rX8L2KkDB4RfjwaWwCJ9Sgk3l5M6iQITz31 nm9CnXL8P5zOOqWUOSSo2t/M0LEDmNpZQh85ZmYZb4qe6fY= X-Google-Smtp-Source: APXvYqwQJRKfy+Vl/cl8bSon1f48TCZxPs48Pxk+sYpRQ9m7vL+sdE/Y72v6MZA4SUQpo5kc/SGBecrlpMEgvOXxcls= X-Received: by 2002:a7b:ce99:: with SMTP id q25mr5036135wmj.115.1572363082711; Tue, 29 Oct 2019 08:31:22 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Tue, 29 Oct 2019 15:31:11 +0000 Message-ID: Subject: Re: [pgAdmin][RM4351] Confirm before close of properties dialog if changes not saved To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000000f72d05960e4fe0" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000000f72d05960e4fe0 Content-Type: text/plain; charset="UTF-8" Hi I just found an, umm, embarrassing issue with this. It asks for the cancel confirmation even when pressing the OK button :-o Can you fix that ASAP please? On Tue, Oct 29, 2019 at 2:35 PM Dave Page wrote: > Thanks, applied. > > On Tue, Oct 29, 2019 at 6:40 AM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to warn the user before closing an unsaved >> properties dialog. >> Additionally, I have added a preference option in Browser->Display where >> the user can disable this. Default is enabled. >> Docs updated. >> >> Kindly review. >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Sr. Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --00000000000000f72d05960e4fe0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

I just found = an, umm, embarrassing issue with this. It asks for the cancel confirmation = even when pressing the OK button :-o

Can you fix t= hat ASAP please?

On Tue, Oct 29, 2019 at 2:35 PM Dave Page <dpage@pgadmin.org> wrote:
Thanks, app= lied.

On Tue, Oct 29, 2019 at 6:40 AM Aditya Toshniwal <aditya.toshniwal@ente= rprisedb.com> wrote:
= Hi Hackers,

Attached is the patch to warn t= he user before closing an unsaved properties dialog.
Additionally, I have added a preference option= in Browser->Display where the=C2=A0user can disable this. Default is en= abled.
Docs updated.

Kindly review.

--
<= div>
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don'= t Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB= UK: http://www.e= nterprisedb.com
The Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @p= gsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL = Company
--00000000000000f72d05960e4fe0--