Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bkpxX-0003WS-4n for pgadmin-hackers@arkaria.postgresql.org; Fri, 16 Sep 2016 10:01:27 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bkpxW-0005mU-M9 for pgadmin-hackers@arkaria.postgresql.org; Fri, 16 Sep 2016 10:01:26 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bkpxJ-0005YG-J3 for pgadmin-hackers@postgresql.org; Fri, 16 Sep 2016 10:01:13 +0000 Received: from mail-it0-x233.google.com ([2607:f8b0:4001:c0b::233]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bkpxF-0002O7-IG for pgadmin-hackers@postgresql.org; Fri, 16 Sep 2016 10:01:12 +0000 Received: by mail-it0-x233.google.com with SMTP id 186so12599422itf.0 for ; Fri, 16 Sep 2016 03:01:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=rNirRmDCWP5K7kKmWW6DMZzfcHUtDWwiQKbFJFOAZxk=; b=mJEc17kQJfvLNj8niTOPh/MkYaKpUJIN38hZV7aI+RZhz7nwS781uJfXhXw84yYxBR ntwMJfV3b59KcGT0iPPP9hyxcqC66Wldix1oLVATYrfW/2YMK3zdYSQ1VjAghbJTquiH DAOYkBu1F18jyPkd332XPG2FsbnjpOaHPFb+Xkj5gZhiQw0ukEf/mjgWgR+tSRnAzyTi 5AXSpuLlL0SMiECqdoflA33cZz4HEF9AxmACez/Tf7RIY6eZEWZvuVZtI0PHpsKC4ZVG CmeQh72UNFWiuMgLvjCR3M6Qx10CA6SgFl3mTlA9IHjfv8Jp6IPm3JQ/2SMNnGWJipI/ vIUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=rNirRmDCWP5K7kKmWW6DMZzfcHUtDWwiQKbFJFOAZxk=; b=Y8My9J5x7rPdpXDKAU/LC0pMPXtZh6rOG1EMY5fzjV8jEwkYcDNjxhDSe/IjToNpyD n8+GoJn0dt0cFTR7RzJ7PZlkivOOIZ6LFm8Eq1uTphgOjrrL4qQ1bN2AfaTTEjQKlCvr P6gVeujnYlaLfJQXq+KfN9QB650GKXYQgtn2xM8OVuDYiTIKhS4wddbLwDQw8CzS34bg Ynz7K+pYHMInu7mAdp1UNBzhNZzB6cgmEFeUmGicnZj/TBpN4iIaylOnKQtKWuuC1vca HEdmxJYP29n3LLiJxEUpGwsVeNZrKGH8/A1iWB9E7I0ZeWnHw9pGu36gETIxVQ/nirTZ lmLw== X-Gm-Message-State: AE9vXwNics+S6gd65T9D/OAk0Ct/GjEYy+2JKuxWffTyPaStwTojybk8syQ1BGZnQmmKc0RDuTAF/GKx3gWe2w== X-Received: by 10.36.60.131 with SMTP id m125mr4589768ita.4.1474020066984; Fri, 16 Sep 2016 03:01:06 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.1.203 with HTTP; Fri, 16 Sep 2016 03:01:06 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Fri, 16 Sep 2016 11:01:06 +0100 Message-ID: Subject: Re: PATCH: To fix the performance of delete operation (pgAdmin4) To: Murtuza Zabuawala Cc: pgadmin-hackers Content-Type: text/plain; charset=UTF-8 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org Can you rebase this please? Thanks. On Thu, Sep 15, 2016 at 11:08 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the issue of slow performance while deleting rows from > grid. > RM#1696 > > Issue: > As per logic implemented for Backgrid, we were deleting individual rows, > means If user selects 100 rows to delete then we were rendering sql template > 100 times to generate sql for each individual rows and then execute all 100 > delete statements one by one due to which we were getting poor performance. > > Please review. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers