MIME-Version: 1.0
In-Reply-To: <1476016037-17290-1-git-send-email-aklhfex@gmail.com>
References: <1476016037-17290-1-git-send-email-aklhfex@gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Mon, 10 Oct 2016 09:33:34 +0100
Message-ID: 
 <CA+OCxozdes15q2Hd0SBZOpax581uFYnRwUJiGwcP2YeU_oJqbA@mail.gmail.com>
Subject: Re: [PATCH 1/2] Fix link to code_review in submitting_patches.rst
To: Chris Mayo <aklhfex@gmail.com>
Cc: "pgadmin-hackers@postgresql.org" <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary=001a11475068a27634053e7e9d8a
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

--001a11475068a27634053e7e9d8a
Content-Type: text/plain; charset=UTF-8

Thanks, patch applied.

BTW, please send any future patches as attachments rather than inline, as I
had to apply this manually as it got munged in the email body.

Thanks!

On Sunday, October 9, 2016, Chris Mayo <aklhfex@gmail.com> wrote:

> Signed-off-by: Chris Mayo <aklhfex@gmail.com <javascript:;>>
> ---
>  docs/en_US/submitting_patches.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/docs/en_US/submitting_patches.rst b/docs/en_US/submitting_
> patches.rst
> index b4bbebe..9f8ab42 100644
> --- a/docs/en_US/submitting_patches.rst
> +++ b/docs/en_US/submitting_patches.rst
> @@ -29,7 +29,7 @@ might run::
>  to create a patch between your development branch and the public master
> branch.
>
>  Once you have your patch, check it thoroughly to ensure it meets the
> pgAdmin
> -:doc:`coding_standards`, and review it against the :doc:`code-review' to
> minimise
> +:doc:`coding_standards`, and review it against the :doc:`code_review` to
> minimise
>  the chances of it being rejected. Once you're happy with your work, mail
> it to the
>  `mailing list <mailto:pgadmin-hackers@postgresql.org <javascript:;>>`.
> Please ensure you
>  include a full description of what the patch does, as well as the
> rationale for
> --
> 2.7.3
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org
> <javascript:;>)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--001a11475068a27634053e7e9d8a
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Thanks, patch applied.<div><br></div><div>BTW, please send any future patch=
es as attachments rather than inline, as I had to apply this manually as it=
 got munged in the email body.</div><div><br></div><div>Thanks!<br><br>On S=
unday, October 9, 2016, Chris Mayo &lt;<a href=3D"mailto:aklhfex@gmail.com"=
>aklhfex@gmail.com</a>&gt; wrote:<br><blockquote class=3D"gmail_quote" styl=
e=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Signed-=
off-by: Chris Mayo &lt;<a href=3D"javascript:;" onclick=3D"_e(event, &#39;c=
vml&#39;, &#39;aklhfex@gmail.com&#39;)">aklhfex@gmail.com</a>&gt;<br>
---<br>
=C2=A0docs/en_US/submitting_patches.<wbr>rst | 2 +-<br>
=C2=A01 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/docs/en_US/submitting_<wbr>patches.rst b/docs/en_US/submitting=
_<wbr>patches.rst<br>
index b4bbebe..9f8ab42 100644<br>
--- a/docs/en_US/submitting_<wbr>patches.rst<br>
+++ b/docs/en_US/submitting_<wbr>patches.rst<br>
@@ -29,7 +29,7 @@ might run::<br>
=C2=A0to create a patch between your development branch and the public mast=
er branch.<br>
<br>
=C2=A0Once you have your patch, check it thoroughly to ensure it meets the =
pgAdmin<br>
-:doc:`coding_standards`, and review it against the :doc:`code-review&#39; =
to minimise<br>
+:doc:`coding_standards`, and review it against the :doc:`code_review` to m=
inimise<br>
=C2=A0the chances of it being rejected. Once you&#39;re happy with your wor=
k, mail it to the<br>
=C2=A0`mailing list &lt;mailto:<a href=3D"javascript:;" onclick=3D"_e(event=
, &#39;cvml&#39;, &#39;pgadmin-hackers@postgresql.org&#39;)">pgadmin-hacker=
s@postgresql.org</a>&gt;`. Please ensure you<br>
=C2=A0include a full description of what the patch does, as well as the rat=
ionale for<br>
--<br>
2.7.3<br>
<br>
<br>
<br>
--<br>
Sent via pgadmin-hackers mailing list (<a href=3D"javascript:;" onclick=3D"=
_e(event, &#39;cvml&#39;, &#39;pgadmin-hackers@postgresql.org&#39;)">pgadmi=
n-hackers@postgresql.org</a>)<br>
To make changes to your subscription:<br>
<a href=3D"http://www.postgresql.org/mailpref/pgadmin-hackers" target=3D"_b=
lank">http://www.postgresql.org/<wbr>mailpref/pgadmin-hackers</a><br>
</blockquote></div><br><br>-- <br>Dave Page<br>Blog: <a href=3D"http://pgsn=
ake.blogspot.com" target=3D"_blank">http://pgsnake.blogspot.com</a><br>Twit=
ter: @pgsnake<br><br>EnterpriseDB UK: <a href=3D"http://www.enterprisedb.co=
m" target=3D"_blank">http://www.enterprisedb.com</a><br>The Enterprise Post=
greSQL Company<br><br>

--001a11475068a27634053e7e9d8a--