Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cX9OO-0008Op-BG for pgadmin-hackers@arkaria.postgresql.org; Fri, 27 Jan 2017 16:28:52 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1cX9ON-00052o-R8 for pgadmin-hackers@arkaria.postgresql.org; Fri, 27 Jan 2017 16:28:51 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cX9ON-00052h-FY for pgadmin-hackers@postgresql.org; Fri, 27 Jan 2017 16:28:51 +0000 Received: from mail-io0-x236.google.com ([2607:f8b0:4001:c06::236]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1cX9OF-0005ml-AX for pgadmin-hackers@postgresql.org; Fri, 27 Jan 2017 16:28:50 +0000 Received: by mail-io0-x236.google.com with SMTP id j18so64297050ioe.2 for ; Fri, 27 Jan 2017 08:28:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=jQm4hWbJi4MKX0tVBXfQS02BkCiMNhNetbUVSV+wz6A=; b=VZ+OiIBq3Vctv3+ZxRJU1GfsMumUmBHtbauIbN2XHcyvf0NhChxxa/ROd0JZEnYkyo 9TwPj1JdkwvoWOlAJq2ezWRhxxurSnOXm4SwRdiUXui/SDn1kyiogjVa4OsnTZovrNnx xEGHcz3Um0yI4SjOcDOtrT7mRUWdJgRGZOj+4C1/GTWuPGq03P6GaM/ZqQnRIK38Ia1l 4UisVABErm27OOju9dhc3kQaZXyKgIE5Y3XotzZOOY/9hU9ZwBB5IWFQolTJDV18ioFJ //XZoQN0SXopTA1jDKoLhjaUkBtFIr7lP7KB4D/AmddyrpyjOvcbR6zozycnnrrAOU7s qmVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=jQm4hWbJi4MKX0tVBXfQS02BkCiMNhNetbUVSV+wz6A=; b=i+v7yM7iMi0QXt4btEiA1VPF2SAFXqSQNZyklNY0qGP9M0OBtm8KirrXSGDr9LXgFu yG2npQBygCyFtOwoi2uhzoBO+yVdwx4WEIG7sSEZK3Kpz/q8nhfomJ8p/J/o1hY+nQ4e w+oeJqVlF8sT6Qonj3dOk0wJPIvacVQKvQTFGP+npxbovPvaJqyFRiXM1wmLdyFGFZTp 6Wdz4OxI5ofnBQbiKgOsGjV842aVSadV8mHaros2GGDAxVxrEpMnpLau6Ft6m3vwWCl7 u412I1RDjxLz+Dlt0wI5R//DBIKEciA7o+aCbmB8IIQcG0iu0eeb5zEJ4asootCdi5N8 +PZg== X-Gm-Message-State: AIkVDXIhOYODm+5v5cUfC2nJQQg8VLObnxisFzabXyeAXG1l9p5HNdsRvb/MAOXT92YMFhcxaQ68dqgn13rVnQ== X-Received: by 10.107.18.230 with SMTP id 99mr7436816ios.45.1485534521935; Fri, 27 Jan 2017 08:28:41 -0800 (PST) MIME-Version: 1.0 Received: by 10.64.224.198 with HTTP; Fri, 27 Jan 2017 08:28:41 -0800 (PST) In-Reply-To: References: From: Dave Page Date: Fri, 27 Jan 2017 16:28:41 +0000 Message-ID: Subject: Re: Acceptance Tests against a browser (WIP) To: George Gelashvili Cc: Atira Odhner , pgadmin-hackers Content-Type: text/plain; charset=UTF-8 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org On Fri, Jan 27, 2017 at 4:11 PM, Dave Page wrote: > On Thu, Jan 26, 2017 at 10:40 PM, George Gelashvili > wrote: >> instead of that patch, please use this no-zombies version that kills the >> started process group instead of pid-only. > > Very cool :-). The only minor annoyance for me is that my Mac pops up > a message asking me if I want pgAdmin to accept connections, but > there's nothing you can do about that of course. > > At this point I think there are a couple of things left to do; > > - Add more tests! > > - Add command line options to runtests.py to allow users to run either > the existing tests or the acceptance tests (or both, which should be > the default). Of course, it should still be possible to just run any > single test. Please add: - Proper cleanup. I just noticed the tests have left an "acceptable_test_db" database behind. Thanks. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers