Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ezLQ2-0000If-3B for pgadmin-hackers@arkaria.postgresql.org; Fri, 23 Mar 2018 12:03:38 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ezLQ1-00055f-1O for pgadmin-hackers@arkaria.postgresql.org; Fri, 23 Mar 2018 12:03:37 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ezLQ0-00055P-R8 for pgadmin-hackers@lists.postgresql.org; Fri, 23 Mar 2018 12:03:36 +0000 Received: from mail-wm0-x22e.google.com ([2a00:1450:400c:c09::22e]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ezLPw-0005aX-De for pgadmin-hackers@postgresql.org; Fri, 23 Mar 2018 12:03:36 +0000 Received: by mail-wm0-x22e.google.com with SMTP id l16so3091783wmh.3 for ; Fri, 23 Mar 2018 05:03:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=rEoWSFVZEZlT7HVu7eANo7goDqiMV13M/kixbiQkWA0=; b=weMFj7YpyDI1qmIO+pDmFFjQ9mscjRHnDtFLF/XlzXqc2Ye/qVTYZWcPDeAo+IM7TN tL2UKACXw5Xw74afOpE4DRw99C/xJgW8bDFpBHNHZ7ok+dNKY9bv4H1ElaSek/bYKNvh ul+QJafBoIlEbYdvzELBzeKvYB5+0ZGl1xCaVs7SDJYHG1gb5vDCSmFgJ6ZI+schHIIp tRP0p3e89Tsx/kLlRzYRKDf/jeCVUnAgjT4YEhzPa3VKn4JV+kIyFKpSeisW3ssYp/Wo Tg6jwVMg0w58mGVfczgpmNjes7Jch2pWi+VA6obqkykQhWdfW0k93T21j+XPt+lOO2g5 kzRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=rEoWSFVZEZlT7HVu7eANo7goDqiMV13M/kixbiQkWA0=; b=Ti67CwjY3UHicwY9jcDj7VNEtITz1AT4pdxEq57FtvMEYvmoemwihmdm3Wb3beH0Td 576fE0T44A9QcszbP89WBkOkM+GuQ9xuqEVf3rehPqlgtYtJfFTuvtsp0lj8X2eFVti5 SCsML84y7rtGr2aaKQa2BY82Am7zYl/kdBOPee7A+/WslnAlLTSNGdyvInTbZS+00/I4 16y7QMNxEEtoKFSWfB41m2YgurIyRDf3Pb9epCxvPn5UI3vfniOGUFeBjndxDs9CDtZl yq7C24hOz7SRT7EwcO5Rqcb7UzzXuCqOt4MUIDjSIKLWyGJujmBGdomD5NaT7feMaNGG XA2A== X-Gm-Message-State: AElRT7Fls0RSZDV2WTeRtKL+Yvqrd1AX84LV3KPXBjJYcmTldywWTtpU /cCSFEGkhugvHyOOpAdh/2fjXdG3FAdE03uqMktNEA== X-Google-Smtp-Source: AG47ELsEQWRmT/6w3mCiFTjFy4NpG9Z68uivj24eobPhl4vGpIOq8j1MFj51EhW2h8oHltN/Nb+EwpE4SSrieP6XIJk= X-Received: by 10.28.91.65 with SMTP id p62mr3722225wmb.140.1521806611736; Fri, 23 Mar 2018 05:03:31 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.69.220 with HTTP; Fri, 23 Mar 2018 05:03:31 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Fri, 23 Mar 2018 12:03:31 +0000 Message-ID: Subject: Re: v3.0 release on hold To: Ashesh Vashi Cc: Khushboo Vashi , pgadmin-hackers , Akshay Joshi , Murtuza Zabuawala , Syed Fahar Abbas , =?UTF-8?B?RGV2cmltIEfDnE5Ew5xa?= Content-Type: multipart/alternative; boundary="001a1144161a8294890568133627" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a1144161a8294890568133627 Content-Type: text/plain; charset="UTF-8" On Fri, Mar 23, 2018 at 11:27 AM, Ashesh Vashi < ashesh.vashi@enterprisedb.com> wrote: > On Fri, Mar 23, 2018 at 3:21 PM, Dave Page wrote: > >> >> >> On Fri, Mar 23, 2018 at 5:43 AM, Khushboo Vashi < >> khushboo.vashi@enterprisedb.com> wrote: >> >>> >>> >>> On Thu, Mar 22, 2018 at 3:42 PM, Dave Page wrote: >>> >>>> >>>> >>>> On Thu, Mar 22, 2018 at 9:58 AM, Khushboo Vashi < >>>> khushboo.vashi@enterprisedb.com> wrote: >>>> >>>>> >>>>> >>>>> On Thu, Mar 22, 2018 at 3:20 PM, Dave Page wrote: >>>>> >>>>>> Hi >>>>>> >>>>>> On Thu, Mar 22, 2018 at 9:25 AM, Khushboo Vashi < >>>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi Dave, >>>>>>> >>>>>>> On Wed, Mar 21, 2018 at 9:05 PM, Dave Page >>>>>>> wrote: >>>>>>> >>>>>>>> We've run into a number of unexpected issues with the v3.0 release >>>>>>>> that I think we need to resolve before moving forwards. For the time being, >>>>>>>> only patches critical to fix these issues should be committed. >>>>>>>> >>>>>>>> I'll try to look at 1, though I do have another deadline I need to >>>>>>>> meet. >>>>>>>> Akshay, can you look at 2 please? >>>>>>>> Fahar is already looking at 3. >>>>>>>> Khushboo, can you look at 4 please? >>>>>>>> >>>>>>>> Thanks all. >>>>>>>> >>>>>>>> 1) There is no longer a system tray in Gnome 3.26 and later, and >>>>>>>> thus the runtime won't initialise in Fedora 27 and later. We need an >>>>>>>> alternative for this, either a tray replacement that the RPM can depend on, >>>>>>>> or better yet, support whatever it is Gnome expect such apps to use these >>>>>>>> days. >>>>>>>> >>>>>>>> 2) Starting a second instance of the app bundle on Mac doesn't >>>>>>>> always open a new pgAdmin window as it should. It works fine in the >>>>>>>> debugger, or if you start the app with a command like: >>>>>>>> "/Applications/pgAdmin\ 4.app/Contents/MacOS/pgAdmin4". It doesn't >>>>>>>> work if you double-click the appbundle or use a command like "open >>>>>>>> /Applications/pgAdmin\ 4.app" >>>>>>>> >>>>>>>> 3) Fahar saw a crash on Windows 7. I couldn't reproduce this on my >>>>>>>> copy, but apparently his is a fresh installation. >>>>>>>> >>>>>>>> 4) On my Windows 7 machine, after running a backup I get no status >>>>>>>> window, and see the following in the logs: >>>>>>>> >>>>>>>> >>>>>>> We have tried to reproduce this issue on Windows 7 and Windows 8, >>>>>>> but couldn't reproduce it, It is working fine on both the environments. >>>>>>> Can you please provide the options which you have selected while >>>>>>> taking a backup? >>>>>>> >>>>>> >>>>>> They were all the default options - I just selected a database, >>>>>> right-clicked to select backup, and entered a filename. >>>>>> >>>>>> >>>>> With the default options, it is working fine. >>>>> >>>> >>>> Can you see any way in which the exception below could conceivably >>>> happen? Perhaps if run on a system that has process logs from an older >>>> version of pgAdmin? >>>> >>>> >>> Not sure as this issue was fixed by Ashesh 1 year back as per git logs. >>> >> >> Well the VM I was testing in did have some process logs from over a year >> ago. Removing them, and truncating the process table in the sqlite DB seems >> to have resolved the issue. >> >> So, I think that's something to watch for if people have backup issues >> and have used older versions of pgAdmin... >> > Should we have a job to purge them on a timely basis? (Of course - > configurable) > Hmm, not sure if it's worth it. We should make sure that future changes in that code can cope with older format logs and DB entries though. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a1144161a8294890568133627 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Fri, Mar 23, 2018 at 11:27 AM, Ashesh Vashi <ashesh.vas= hi@enterprisedb.com> wrote:
On Fri, Mar 23, 2018 at 3:21 PM, Dave Page <dpage@pgad= min.org> wrote:


O= n Fri, Mar 23, 2018 at 5:43 AM, Khushboo Vashi <khushboo.vas= hi@enterprisedb.com> wrote:


On Thu, Mar 22, 2018 at 3:42 PM, Dave Page <dpage@pgadmin.= org> wrote:


On Th= u, Mar 22, 2018 at 9:58 AM, Khushboo Vashi <khushboo.vashi@e= nterprisedb.com> wrote:


On Thu, Mar 22, 2018 at 3:20 PM, Dave Page &l= t;dpage@pgadmin.org<= /a>> wrote:
Hi=

On Thu,= Mar 22, 2018 at 9:25 AM, Khushboo Vashi <khushboo.vashi@ent= erprisedb.com> wrote:
=
Hi D= ave,

<= span>On Wed, Mar 21, 2018 at 9:05 PM, Dave Page <dpage@pgadmin.org>= wrote:
We've run into a number of unexpected issues with the v3.0 release = that I think we need to resolve before moving forwards. For the time being,= only patches critical to fix these issues should be committed.

I'll try to look at 1, though I do have another deadline I need= to meet.=C2=A0
Akshay, can you look at 2 please?
Fahar= is already looking at 3.
Khushboo, can you look at 4 please?

Thanks all.

1) There is no l= onger a system tray in Gnome 3.26 and later, and thus the runtime won't= initialise in Fedora 27 and later. We need an alternative for this, either= a tray replacement that the RPM can depend on, or better yet, support what= ever it is Gnome expect such apps to use these days.

2) Starting a second instance of the app bundle on Mac doesn't alway= s open a new pgAdmin window as it should. It works fine in the debugger, or= if you start the app with a command like: "/Applications/pgAdmin\ 4.a= pp/Contents/MacOS/pgAdmin4". It doesn't work if you double-cl= ick the appbundle or use a command like "open /Applications/pgAdmin\ 4= .app"

3) Fahar saw a crash on Windows 7. I co= uldn't reproduce this on my copy, but apparently his is a fresh install= ation.

4) On my Windows 7 machine, after running a= backup I get no status window, and see the following in the logs:


We hav= e tried to reproduce this issue on Windows 7 and Windows 8, but couldn'= t reproduce it, It is working fine on both the environments.
Can = you please provide the options which you have selected while taking a backu= p?

They were= all the default options - I just selected a database, right-clicked to sel= ect backup, and entered a filename.
=C2=A0
With the default options, it is working fine.=C2=A0

Can you see any= =C2=A0 way in which the exception below could conceivably happen? Perhaps i= f run on a system that has process logs from an older version of pgAdmin?
=C2=A0
Not sure as this issue was fixed by Ashesh 1 year back as per = git logs.

We= ll the VM I was testing in did have some process logs from over a year ago.= Removing them, and truncating the process table in the sqlite DB seems to = have resolved the issue.

So, I think that's so= mething to watch for if people have backup issues and have used older versi= ons of pgAdmin...
Shou= ld we have a job to purge them on a timely basis? (Of course - configurab= le)

Hmm, not sure i= f it's worth it. We should make sure that future changes in that code c= an cope with older format logs and DB entries though.=C2=A0

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

Ent= erpriseDB UK: htt= p://www.enterprisedb.com
The Enterprise PostgreSQL Company
--001a1144161a8294890568133627--