Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1haGEO-0003UO-U8 for pgadmin-hackers@arkaria.postgresql.org; Mon, 10 Jun 2019 09:04:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1haGEN-0005GA-Db for pgadmin-hackers@arkaria.postgresql.org; Mon, 10 Jun 2019 09:04:43 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1haGEM-00057C-P6 for pgadmin-hackers@lists.postgresql.org; Mon, 10 Jun 2019 09:04:43 +0000 Received: from mail-io1-xd43.google.com ([2607:f8b0:4864:20::d43]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1haGEJ-0003su-LY for pgadmin-hackers@postgresql.org; Mon, 10 Jun 2019 09:04:41 +0000 Received: by mail-io1-xd43.google.com with SMTP id w25so6266406ioc.8 for ; Mon, 10 Jun 2019 02:04:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dwJGSxxIKayzgOYUR8iEqBcvWndWw3sg9dHjXpvYM4M=; b=mEmE7zN74lCwu69SbCo+NK/LRg3bBRdmYGOETjfrdw7nokfAO9s378AwCSdLNT3aGu abLnoV/+gr4D3/TVnVOTWw7JJs9Lpb3tca7gmy0GvlQngfkIvMt8UBMtS7Ra+V2DNbBT ScYbAjhwFiNb5ZpB3EX/UUGG0p0qhTV8JqDCsxCJtNsMgrhg2qRQUPriOSSIQd3ydCye tWfIZgd1kYRYRhGYy2W4NU9GgQ1t6L4rhWGw+vY/J+LuVf+9pUlJyOvBNPVOVKU2Iun8 Ll9oi4X8ywExBATN1y8kL0y3Hv4+Hr9TZJxb+Ba3jI4CPLNvmrdGmxZOFSoeKWnk95+W 8K5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dwJGSxxIKayzgOYUR8iEqBcvWndWw3sg9dHjXpvYM4M=; b=S6t2mq89vC36a3Xo7SIqHQBqBs/R1wAkMbpyCWkjQy2MGxgGrikNlUNjKqL3SLEa9G dKQwcw6rOkGYD3ZoRlbvjl3DIiIl7sKGctx17UncNO11WIFjvbT/GH+5C6/oXF8Mc19z Kb5CbjX096IVOLMB5F/0bbLeUvM9cYWpnlkZQWCG5qyiw+zKrO+Kt5s22fyDsLz32vGK /jYzadpKEOAEun/SXhCLbr7S/dMKvo6md9avy6LQVheeZfRPIFT+BPPPLTdjouiOvFF9 4tUs4NrHiuVQmnnxFoLPWs03mTswoGW0pBL0k4lh594rU4j+xrGKs56RgPlxIbBETq2Q 4aEg== X-Gm-Message-State: APjAAAUwCwZhbgKq+NIiZPPLZ8BWg4toWw/RaO/kqJrLNWeVTIicqlkD Qd68QFwCBRJWM0EIkJcmuS9PXDAkkJqKp2sF2DfwGg== X-Google-Smtp-Source: APXvYqz1s7DkryRb32sKVHLr1EEW1GvwITPMjHAdn4o7mNbMyX8HOdu7PUsR+Dk0ZxqajA4j4FgbqbwOHCYwNCoad4o= X-Received: by 2002:a5d:9456:: with SMTP id x22mr16639139ior.71.1560157478494; Mon, 10 Jun 2019 02:04:38 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Mon, 10 Jun 2019 10:04:27 +0100 Message-ID: Subject: Re: [pgAdmin][RM4310] User can not connect to the Master Password with Enter button To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000004cb70d058af47821" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000004cb70d058af47821 Content-Type: text/plain; charset="UTF-8" Hi On Wed, Jun 5, 2019 at 1:39 PM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi, > > On Wed, Jun 5, 2019 at 4:48 PM Dave Page wrote: > >> Hi >> >> On Wed, Jun 5, 2019 at 8:14 AM Aditya Toshniwal < >> aditya.toshniwal@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the patch to fix an issue where using browser autofills in >>> alertify dialogs triggers the help page button (#4317). >>> A workaround was added to master password dialog to avoid this, but that >>> in turn disabled the 'OK' button tigger on pressing enter button. This is >>> also fixed with this patch.(#4310) >>> >> >> This isn't quite right. When the browser auto-fills the password, the OK >> button remains disabled. I can hit enter though - however, I shouldn't be >> able to do that when the OK button is disabled (being the default button on >> the dialogue, it should respond to enter, unless another control which also >> accepts enter has focus (e.g. a multiline text area). >> > The autofilled password appears as set, but it is actually not set to > textbox unless you enter/click in the dropdown. We get the DOM element > value as blank even if it appears filled. This is how chromium autofill > behaves. Upon hitting enter the autofill value is set to the textbox and OK > button is enabled. > >> >> The OK button should be enabled - probably all the time, as the user >> could have entered a blank password, and most systems won't prevent a user >> from trying to use such a password. >> > I have made the changes to allow blank master password, plus enabling OK > button always. Attached is the updated patch. > I think you've slightly mis-understood what I was trying to say. - We should not allow a blank password. - We should not disable the OK button at all. My analogy was focussed on the fact that most systems never disable OK buttons on login dialogues, as some of those systems (but not all of course) may allow blank passwords. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --0000000000004cb70d058af47821 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

On Wed, Jun 5, 2019 at 1:39 PM Aditya Toshniwal <= ;aditya.toshniwal@ente= rprisedb.com> wrote:
Hi,

On Wed, Jun 5, 2019 at 4:48 PM Dave Page <dpage@pgadmin.org>= ; wrote:
Hi

On Wed, Jun 5, 2019 at 8:14 AM Aditya Toshniwal <aditya.tos= hniwal@enterprisedb.com> wrote:
Hi Hackers,

At= tached is the patch to fix an issue where using browser autofills in alerti= fy dialogs triggers the help page button (#4317).
A workaround was added to master password dialog = to avoid this, but that in turn disabled the 'OK' button tigger on = pressing enter button. This is also fixed with this patch.(#4310)

This isn't quite right. When the bro= wser auto-fills the password, the OK button remains disabled. I can hit ent= er though - however, I shouldn't be able to do that when the OK button = is disabled (being the default button on the dialogue, it should respond to= enter, unless another control which also accepts enter has focus (e.g. a m= ultiline text area).
The autofilled password= =C2=A0appears as set,= but it is actually not=C2=A0set to textbox unless you enter/click in the dropdown. We get the DO= M element value as blank even if it appears filled. This is how chromium au= tofill behaves. Upon hitting enter the autofill value is set to the textbox= and OK button is enabled.

<= /div>
The OK button should be enabled - probably all the time, as the u= ser could have entered a blank password, and most systems won't prevent= a user from trying to use such a password.
<= div style=3D"font-family:verdana,sans-serif">I have made the changes to all= ow blank master password, plus enabling OK button always. Attached is the u= pdated patch.

I think you= 've slightly mis-understood what I was trying to say.

- We should not allow a blank password.
- We should not d= isable the OK button at all.

My analogy was focuss= ed on the fact that most systems never disable OK buttons on login dialogue= s, as some of those systems (but not all of course) may allow blank passwor= ds.
=C2=A0
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

Enterp= riseDB UK: http:/= /www.enterprisedb.com
The Enterprise PostgreSQL Company
--0000000000004cb70d058af47821--