Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l05uv-0000Y9-Dz for pgadmin-hackers@arkaria.postgresql.org; Thu, 14 Jan 2021 16:56:13 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1l05ut-0007My-Kc for pgadmin-hackers@arkaria.postgresql.org; Thu, 14 Jan 2021 16:56:11 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l05ut-0007Mr-Et for pgadmin-hackers@lists.postgresql.org; Thu, 14 Jan 2021 16:56:11 +0000 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1l05uo-0006uJ-BD for pgadmin-hackers@postgresql.org; Thu, 14 Jan 2021 16:56:10 +0000 Received: by mail-ej1-x62c.google.com with SMTP id jx16so9164473ejb.10 for ; Thu, 14 Jan 2021 08:56:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1URcsCSHMA/FRUDe9+pd6C5ZY2I426vlhGDNhHpxsrA=; b=JyOjUMqbWWMVc97j/uF3x2LMhiMEJuAH3siiVC/azwZXIm7CynkmI3zak7aQ0PKXBs HqQhlFqb0zdcqTEb88f9rpSfKSFdB3hlu752SI9tAtd0cqg/FDzXn+CAB33/iIrBc2B/ ngKKMUcfw7zOQ+PFrlAlERrvnNzakLWVHHWOBqDFLfBB9uV9lPmZrMmVCSmW8eABXsDo zyRRVaAmuHuV3ieADzNke1HFophbzdL3Z2ii6P7z7uF5r9j3ztm3klgr6HAfqLrjwX7+ zlAKYFYftMXmAivJ0BZmbJ4+5st3uL6HXeR8HlF4esVs8VIx8d0vksXfXD/LHvDQW3TX W3Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1URcsCSHMA/FRUDe9+pd6C5ZY2I426vlhGDNhHpxsrA=; b=naPLdhZyMKs+w8OgcuywhgPQntlQtvGEGu7KKfcuI75ayI+9lwHLCkpyRGygegxUSo kxZSWrIituDg330oBjL2FiIoHCWnUFj5otjRncry9anOm2fgO9k1tlRuY+HaSsfONzrA mCnZtAvVNJv31bqDnIOtcz44LRMZSgzfjvGuVFwcTUNfqWUO+c+QcHaXrI3MOY2E58IJ y5ZlSqiGTEnhc98sgkWD9vUzGk+cGrUxhuADBK8mi3tHntoOCldVCW1br6QJEFlzRo8w I3zf2npdQjleUCSVK4PS1dX4UwN6rl+Et2cXNkwcgH/6ytZH5oEnAwF+NEN1IcyC/XT1 xydQ== X-Gm-Message-State: AOAM531BIwT+97fReHibhUUONhWZKj8ST6E6xo52UEDmx3x1TQkS4zju LqA9qgZ6gxfyWPuLFch2DHwWgm3hu2BoTBlTvWoHqbbpH+PwIA== X-Google-Smtp-Source: ABdhPJwcfMuPm2clwGyk0FaU8VK/Fj77qpwZtSm+zGDLJYicFDxUsECBCllnhOLjeCyynn0MIXUuf/B4YeyAtxHQ2po= X-Received: by 2002:a17:906:2c1a:: with SMTP id e26mr5996789ejh.412.1610643364779; Thu, 14 Jan 2021 08:56:04 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Thu, 14 Jan 2021 16:55:54 +0000 Message-ID: Subject: Re: Quick search for menu items & help articles To: Pramod Ahire Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000009e27de05b8df21d5" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000009e27de05b8df21d5 Content-Type: text/plain; charset="UTF-8" Hi On Thu, Jan 14, 2021 at 4:48 PM Pramod Ahire wrote: > Hi Team, > > > > Please find the attached designs & patch that contains complete > functionality except below to do for quick search. > > > > To Do: > > > > - Unit test cases are not that sufficient to cover complete code, but > will be working in background to cover up those one > - In pgadmin, for disabled menu items we need to add info that will > describe why menu has disabled & how it will be enabled. Either another way > to enable all of them & show respective reason in popup that menu is > disabled for. > > > > Please do let me know if I missed anything or suggestion of yours. > Looks very good. I haven't done an extensive code review/test, but two things spring to mind immediately: 1) I think the search box should be the top item on the Help menu. I do not think it should be on the far end of the menu bar, as it looks too much like it will search for data (think of search on a website). 2) Do we need another loading icon? Surely there's one in the source tree already that we can use? -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EDB: http://www.enterprisedb.com --0000000000009e27de05b8df21d5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

On Thu, Jan 14, 2021 at 4:48 PM Pramod = Ahire <pramod.ahire@ent= erprisedb.com> wrote:

Hi Team,=C2=A0

=C2= =A0<= /p>

Please find the attached designs & patch that = contains complete functionality except below to do for quick search.=

=C2=A0<= /u>

To Do:=C2=A0

=C2=A0<= /span>

  • Unit test cases are not that sufficient to cover complete code, = but will be working in background to cover up those one
  • In pgadmin, for disabled menu items we need to add info that will descr= ibe why menu has disabled & how it will be enabled. Either another way = to enable all of them & show respective reason in popup that menu is di= sabled for.=C2=A0

=C2=A0

Please do let me know if I missed anything or suggestion of your= s.


Looks very good. = I haven't done an extensive code review/test, but two things spring to = mind immediately:

1) I think the search box should= be the top item on the Help menu. I do not think it should be on the far e= nd of the menu bar, as it looks too much like it will search for data (thin= k of search on a website).

2) Do we need another l= oading icon? Surely there's one in the source tree already that we can = use?=C2=A0

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: = @pgsnake

EDB: http://www.enterprisedb.com

--0000000000009e27de05b8df21d5--