MIME-Version: 1.0
References: 
 <CAO+oWtBxAaDxdPOkcf=bTU0D6sDogX_az4SgN-5zKZt-9G=2xQ@mail.gmail.com>
In-Reply-To: 
 <CAO+oWtBxAaDxdPOkcf=bTU0D6sDogX_az4SgN-5zKZt-9G=2xQ@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Thu, 18 Apr 2024 09:54:00 +0100
Message-ID: 
 <CA+OCxozieNmgfoGFq0G0Mxy+bu2Ct6hK9goZA3xtVJm9EaK6HA@mail.gmail.com>
Subject: Re: Regarding feature #6841
To: Anil Sahoo <anil.sahoo@enterprisedb.com>
Cc: pgadmin-hackers@postgresql.org
Content-Type: multipart/alternative; boundary="00000000000077a79706165b1d8f"
Archived-At: 
 <https://www.postgresql.org/message-id/CA%2BOCxozieNmgfoGFq0G0Mxy%2Bbu2Ct6hK9goZA3xtVJm9EaK6HA%40mail.gmail.com>
Precedence: bulk

--00000000000077a79706165b1d8f
Content-Type: text/plain; charset="UTF-8"

Hi

On Wed, 17 Apr 2024 at 15:08, Anil Sahoo <anil.sahoo@enterprisedb.com>
wrote:

> Hi Hackers,
>
> This feature is about executing a query at the cursor position. And that
> query can be a one line or multiline. I have assigned a play icon button
> and F5 as the keyboard shortcut for the Execute Query feature, and for
> Execute Script, Playlist icon button and Alt+F5(Others),Option+F5(Mac) as
> keyboard shortcut.
>
> As now the query can run at cursor position, so for user convenience I am
> showing the current query just beside the Data Output toolbar. And on hover
> of the text, it will show the whole query as a tooltip. This query text
> will be available for both Execute Script and Execute Query.
>
> I have made the UI change for the feature #6841
> <https://github.com/pgadmin-org/pgadmin4/issues/6841>.
>
> Please provide your suggestions and feedback if these changes look okay to
> you.
>

How is this parsing the query to figure out the correct text to send to the
server? For example, I notice you have no semi-colons on many of the
queries in your test; is it breaking on newlines? What if there's a newline
(or multiple of them) in the query string? How does it cope with an
anonymous block containing multiple queries, or a pl/whatever function
definition that might contain queries within its text? Or a view definition?

-- 
Dave Page
pgAdmin: https://www.pgadmin.org
PostgreSQL: https://www.postgresql.org
EDB: https://www.enterprisedb.com

--00000000000077a79706165b1d8f
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hi</div><br><div class=3D"gmail_quote"><div dir=3D"lt=
r" class=3D"gmail_attr">On Wed, 17 Apr 2024 at 15:08, Anil Sahoo &lt;<a hre=
f=3D"mailto:anil.sahoo@enterprisedb.com">anil.sahoo@enterprisedb.com</a>&gt=
; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px=
 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:=
rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr">Hi Hackers,<div><br></d=
iv><div>This feature is about executing a query=C2=A0at the=C2=A0cursor pos=
ition. And that query can be a one=C2=A0line or multiline. I have assigned =
a play icon button and F5 as the keyboard shortcut for the Execute Query fe=
ature, and for Execute Script, Playlist icon button and Alt+F5(Others),Opti=
on+F5(Mac) as keyboard shortcut.</div><div><br></div><div>As now the query =
can run at cursor position, so for user convenience I am showing the curren=
t query just beside the Data=C2=A0Output toolbar. And on hover of the text,=
 it will show the whole query as a tooltip. This query text will be availab=
le for both Execute Script and Execute Query.</div><div><br></div><div>I ha=
ve made the UI change for the feature <a href=3D"https://github.com/pgadmin=
-org/pgadmin4/issues/6841" target=3D"_blank">#6841</a>.=C2=A0</div><div><br=
></div><div>Please provide your suggestions and feedback if these changes l=
ook okay to you.</div></div></blockquote><div><br></div><div>How is this pa=
rsing the query to figure out the correct text to send to the server? For e=
xample, I notice you have no semi-colons=C2=A0on many of the queries in you=
r test; is it breaking on newlines? What if there&#39;s a newline (or multi=
ple of them) in the query string? How does it cope with an anonymous block =
containing multiple queries, or a pl/whatever function definition that migh=
t contain queries within its text? Or a view definition?</div><div>=C2=A0</=
div></div><span class=3D"gmail_signature_prefix">-- </span><br><div dir=3D"=
ltr" class=3D"gmail_signature"><div dir=3D"ltr">Dave Page<div>pgAdmin: <a h=
ref=3D"https://www.pgadmin.org" target=3D"_blank">https://www.pgadmin.org</=
a></div><div>PostgreSQL: <a href=3D"https://www.postgresql.org" target=3D"_=
blank">https://www.postgresql.org</a><br><div>EDB:=C2=A0<a href=3D"https://=
www.enterprisedb.com" target=3D"_blank">https://www.enterprisedb.com</a></d=
iv><div><br></div></div></div></div></div>

--00000000000077a79706165b1d8f--