MIME-Version: 1.0
In-Reply-To: 
 <CAFOhELfx_KfUmFc+McR+maHJgLfsi+z+CMfnn3VPgdv539XtuQ@mail.gmail.com>
References: <474340384.127.1520431275754.JavaMail.jenkins@jenkins.pgadmin.org>
 <CA+OCxoxrPgB_mv_-50z9d2hj7iHQyeMJGhXtEkGfFMYf4_Ep+w@mail.gmail.com>
 <CAFOhELfx_KfUmFc+McR+maHJgLfsi+z+CMfnn3VPgdv539XtuQ@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Wed, 7 Mar 2018 15:53:00 +0000
Message-ID: 
 <CA+OCxoziegBKj165ysM86fWL3m1CFN5+hnVBDjx3D9eeFHH6=Q@mail.gmail.com>
Subject: Re: Build failed in Jenkins: pgadmin4-master-python33 #507
To: Khushboo Vashi <khushboo.vashi@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="001a11444b44c81f9a0566d48d4b"
Precedence: bulk

--001a11444b44c81f9a0566d48d4b
Content-Type: text/plain; charset="UTF-8"

Hi

On Wed, Mar 7, 2018 at 3:10 PM, Khushboo Vashi <
khushboo.vashi@enterprisedb.com> wrote:

> Hi Dave,
>
> On Wed, Mar 7, 2018 at 7:34 PM, Dave Page <dpage@pgadmin.org> wrote:
>
>> Khushboo, can you look at this ASAP please? It passed tests on my
>> machine, but Jenkins isn't happy.
>>
>> I have tried to reproduce the issue with many combination but couldn't
> reproduce it.
> With the help of logs, I have tried to fix it. Can you please check this
> fix is helpful or not?
>

On my laptop I now get:

======================================================================
ERROR: runTest
(pgadmin.tools.sqleditor.tests.test_poll_query_tool.TestPollQueryTool)
When query tool polling returns messages with result data-set
----------------------------------------------------------------------
Traceback (most recent call last):
  File
"/Users/dpage/git/pgadmin4/web/pgadmin/tools/sqleditor/tests/test_poll_query_tool.py",
line 104, in runTest
    response_data['data']['additional_messages'])
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py",
line 802, in assertIn
    if member not in container:
TypeError: argument of type 'NoneType' is not iterable

----------------------------------------------------------------------

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--001a11444b44c81f9a0566d48d4b
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi<br><div class=3D"gmail_extra"><br><div class=3D"gmail_q=
uote">On Wed, Mar 7, 2018 at 3:10 PM, Khushboo Vashi <span dir=3D"ltr">&lt;=
<a href=3D"mailto:khushboo.vashi@enterprisedb.com" target=3D"_blank">khushb=
oo.vashi@enterprisedb.com</a>&gt;</span> wrote:<br><blockquote class=3D"gma=
il_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,2=
04,204);padding-left:1ex"><div dir=3D"ltr">Hi Dave,<br><div class=3D"gmail_=
extra"><br><div class=3D"gmail_quote"><span class=3D"gmail-">On Wed, Mar 7,=
 2018 at 7:34 PM, Dave Page <span dir=3D"ltr">&lt;<a href=3D"mailto:dpage@p=
gadmin.org" target=3D"_blank">dpage@pgadmin.org</a>&gt;</span> wrote:<br><b=
lockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-le=
ft:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr">Khushboo, =
can you look at this ASAP please? It passed tests on my machine, but Jenkin=
s isn&#39;t happy.<div><br></div></div></blockquote></span><div>I have trie=
d to reproduce the issue with many combination but couldn&#39;t reproduce i=
t.</div><div>With the help of logs, I have tried to fix it. Can you please =
check this fix is helpful or not?=C2=A0</div></div></div></div></blockquote=
><div><br></div><div>On my laptop I now get:</div><div><br></div><div>=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D</div><div>ERROR: =
runTest (pgadmin.tools.sqleditor.tests.test_poll_query_tool.TestPollQueryTo=
ol)</div><div>When query tool polling returns messages with result data-set=
</div><div>----------------------------------------------------------------=
------</div><div>Traceback (most recent call last):</div><div>=C2=A0 File &=
quot;/Users/dpage/git/pgadmin4/web/pgadmin/tools/sqleditor/tests/test_poll_=
query_tool.py&quot;, line 104, in runTest</div><div>=C2=A0 =C2=A0 response_=
data[&#39;data&#39;][&#39;additional_messages&#39;])</div><div>=C2=A0 File =
&quot;/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.=
7/unittest/case.py&quot;, line 802, in assertIn</div><div>=C2=A0 =C2=A0 if =
member not in container:</div><div>TypeError: argument of type &#39;NoneTyp=
e&#39; is not iterable</div><div><br></div><div>---------------------------=
-------------------------------------------=C2=A0</div></div><div><br></div=
>-- <br><div class=3D"gmail_signature">Dave Page<br>Blog: <a href=3D"http:/=
/pgsnake.blogspot.com" target=3D"_blank">http://pgsnake.blogspot.com</a><br=
>Twitter: @pgsnake<br><br>EnterpriseDB UK: <a href=3D"http://www.enterprise=
db.com" target=3D"_blank">http://www.enterprisedb.com</a><br>The Enterprise=
 PostgreSQL Company<br></div>
</div></div>

--001a11444b44c81f9a0566d48d4b--