MIME-Version: 1.0
In-Reply-To: 
 <CAM5-9D8ii0U9tn=rNgxbCfQLM48Gsk42h2Sp8grTumi+Juk75w@mail.gmail.com>
References: 
 <CAM5-9D8sNyL=Y0DMmM5gPCvYhy0dPiyxjjqddwZEgAoPhWG3kw@mail.gmail.com>
 <CA+OCxoyW1Y5C3CdHZC1rzzzhuARdWFJM6U5cRDZtU5QqmfmaMA@mail.gmail.com>
 <CAM5-9D8ii0U9tn=rNgxbCfQLM48Gsk42h2Sp8grTumi+Juk75w@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Tue, 18 Oct 2016 11:40:02 +0100
Message-ID: 
 <CA+OCxozixe1sDVx6WuOddWsbYYpfctxxkwmXd2r9s2-h8nVftw@mail.gmail.com>
Subject: Re: [pgAdmin4][Patch]: Listing of files/folders not
 sorted alphabetically in Storage Manager
To: Surinder Kumar <surinder.kumar@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: text/plain; charset=UTF-8
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

Thanks, applied.

On Mon, Oct 17, 2016 at 8:32 AM, Surinder Kumar
<surinder.kumar@enterprisedb.com> wrote:
> Hi Dave,
>
> As we have already been using natural sort in pgAdmin4 for sorting browser
> tree nodes. So I have used the same for sorting Storage Manager's
> filesystem.
> Please find updated patch and let me know for comments.
>
> On Fri, Oct 7, 2016 at 5:10 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> Hi
>>
>> The patch fixes the filename length issue, but does not seem to
>> resolve the sorting. Please see the attached screenshot.
>>
>> On Fri, Oct 7, 2016 at 8:48 AM, Surinder Kumar
>> <surinder.kumar@enterprisedb.com> wrote:
>> > Hi,
>> >
>> > Issues fixed:
>> > 1) Listing of files/folders not sorted alphabetically.
>> > 2) Some file names are truncated despite the fact that there is plenty
>> > of
>> > room to be displayed.
>> >
>> > Not Fixed:
>> > In Table mode, clicking on Name bar makes no difference.
>> > As discussed with Ashesh we are not implementing it now. It requires a
>> > lot
>> > of changes with current implementation.
>> >
>> > Please find attached patch and review.
>> >
>> > Thanks,
>> > Surinder Kumar
>> >
>> >
>> > --
>> > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> > To make changes to your subscription:
>> > http://www.postgresql.org/mailpref/pgadmin-hackers
>> >
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers