Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aqnOc-00040L-7G for pgadmin-hackers@arkaria.postgresql.org; Thu, 14 Apr 2016 19:57:46 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1aqnOb-0006Xm-5y for pgadmin-hackers@arkaria.postgresql.org; Thu, 14 Apr 2016 19:57:45 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1aqnON-0006JL-W1 for pgadmin-hackers@postgresql.org; Thu, 14 Apr 2016 19:57:32 +0000 Received: from mail-io0-x22d.google.com ([2607:f8b0:4001:c06::22d]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1aqnOL-0004Fg-8V for pgadmin-hackers@postgresql.org; Thu, 14 Apr 2016 19:57:30 +0000 Received: by mail-io0-x22d.google.com with SMTP id u185so114755010iod.3 for ; Thu, 14 Apr 2016 12:57:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=qsCHXKd0P13S08PQTG1veZ8LySvg9DB36v75LqoUUPo=; b=LEmdULm/QqIBkc8uAERVw8XWeBQSg5d2JVcH+Y8qArDYRqTqbHtBwi0/4Z4DPDRGUs CEmz4ZIQFwE09yx/s+nSlGDIiFf2M/GDdy/HRQ5OolhRRaS9DhD2ePlLyy10BEq1X3Ai Eb48y4i47/v1e2GdK9SQNah1FuA7aNe7havhUTYkBX/CQEQAIKJ7x0yPb7+T6Esg3QcE pzQpsj8OW9k9imz9zfHahwNHfmZVmOHEK5orw6inc3BcCOqtKnONPhhfR3i6lsezGjsO UGITT2RCEsDiymZniOPl3fuVBN0B66qEZfWM5lkX5JF4Jw73kVdBVcz42GdFD9aEDX5u TKjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=qsCHXKd0P13S08PQTG1veZ8LySvg9DB36v75LqoUUPo=; b=VpquAWqtoYmu0OzNxpwj4G1rhmny5pdc/cVc6t/bqqZIGzZHLTtKQxpR0JfUoFxkwk g+yFkMK9kfIC8RrafVlsCoVAGbotcANBP/DN1ufq6V1jwhkr8Kqjt69KWNhh8y5bWfHp 9wwE7Zodnvu4EDYn1D8o+A9wXa7xR6FcIL+AKYfoTjZR12rdGO0RYmdn2a1vXqb9l8W2 ku/I6BEEhimA9CL8S0/dj0Qq/wjok0BX5BBHb9eB4OyZzFd/WtTsQhCGAQga2Hc+GIBH boFVWhBprNd7aqiWHrJONAtDNdjDMuG1drMF7HtYZWvWKm0OT55tXaEGpWl56NAZ0MuS 5Omw== X-Gm-Message-State: AOPr4FUIdiGErwOUPinVFc//545xO+LNajAtihelDrxs7zgwdsqi1H5XuV8S8B29xhvIKGXc/SZWq8InFEbOWw== MIME-Version: 1.0 X-Received: by 10.107.12.224 with SMTP id 93mr19266916iom.70.1460663848447; Thu, 14 Apr 2016 12:57:28 -0700 (PDT) Received: by 10.64.105.131 with HTTP; Thu, 14 Apr 2016 12:57:28 -0700 (PDT) In-Reply-To: References: Date: Thu, 14 Apr 2016 20:57:28 +0100 Message-ID: Subject: Re: PATCH: FTS Dictionary From: Dave Page To: Sanket Mehta Cc: pgadmin-hackers Content-Type: text/plain; charset=UTF-8 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org On Thu, Apr 14, 2016 at 3:41 PM, Sanket Mehta wrote: > Hi, > > PFA patch for FTS Dictionaries. > Please do review it and let me know in case of any issues. Thanks - committed with a few cosmetic changes, and a couple of minor issues to resolve: 1) The template is not shown in properties views if it is not in a system schema (because of the way you are dealing with schema names etc). Please also check how the existing code will behave, if there is a template in the public schema with the same name as one in pg_catalog. 2) Please strip the quotes from the options before displaying them. I'll create a card for this. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers