Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d3l5M-0003hk-DM for pgadmin-hackers@arkaria.postgresql.org; Thu, 27 Apr 2017 15:12:00 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1d3l5L-0003Mo-Tr for pgadmin-hackers@arkaria.postgresql.org; Thu, 27 Apr 2017 15:11:59 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d3l5L-0003Mf-G6 for pgadmin-hackers@postgresql.org; Thu, 27 Apr 2017 15:11:59 +0000 Received: from mail-io0-x22b.google.com ([2607:f8b0:4001:c06::22b]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1d3l5I-0002gA-Iy for pgadmin-hackers@postgresql.org; Thu, 27 Apr 2017 15:11:58 +0000 Received: by mail-io0-x22b.google.com with SMTP id r16so24698676ioi.2 for ; Thu, 27 Apr 2017 08:11:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=aGNJrNq04dHP0WA341lJinhguYEcCp1pKzqO4YcIjQk=; b=pTftxbmkLviOFVVTi8sdh/BCmKNU8iwoYuHFWK9+CF4AU0dyv6n0jgm4/gmBgdYDmu uYNSi88xOx22pN5jnEvOlH/59pqwyygZ6lCAYDuImuc70asxS5JACij2okNUUvRMG/h9 JtoBW7agZWtXrSy5HcmbGU1DYCzM57/t3TluYxu1vPjqRdfn401axY0Zkog/Oy5RmmKt 7zsum6JLLA3UbmZWtDgF2g7jijn8Yq+rPAsRtqAGmnxurAeSSuqs+Pln8cKszzkUvyZt qVSfpHVVpRW4nhhvIpKdDPoTi8r/avG434T7WNVQvrWx13GoscDfG9fGz5mEuugzTmBM 1PoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=aGNJrNq04dHP0WA341lJinhguYEcCp1pKzqO4YcIjQk=; b=CY2qfErWefVsTaP2HZbEQZUxmAImYPzxKZXLQuQDbLjsGWOtHcQRsewGqQQPhRcSK1 J/o9m62KY7dyCLfa5ejPvGq/D5ZdxH28JDZAHMz517nY59qs2WTL6ZGDOP6+OdjLxXsj WHHxkB7LDqnBrvqZkbZoNH9G8AgLyMMlZ/WW71RKiCbWgrAzBqqfLZ0PswHuEDcaTnup aw8nmO+Y/UDb2jH1CWroAYSzfAZfCRTSncMHr1xqCVMIbWoxGMf31Z/5gWGvydB+h4hB 0VZlvg7xZfAOHU/oL42yJFHWuY0CaP9ANH8HqflQvG/kSPr2TUFBc/99CWCxR4ryzIu6 pcpA== X-Gm-Message-State: AN3rC/7gzwN2VO1LJ/GcfWREyAs/WPr4+hygy9+E3X0I67BU6FXWezRV Bc17tLR8DPZqWAuRtCropdkkQrTrHii8 X-Received: by 10.107.46.86 with SMTP id i83mr5237752ioo.84.1493305915137; Thu, 27 Apr 2017 08:11:55 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.174.167 with HTTP; Thu, 27 Apr 2017 08:11:54 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Thu, 27 Apr 2017 16:11:54 +0100 Message-ID: Subject: Re: Declarative partitioning in pgAdmin4 To: Robert Eckhardt Cc: Akshay Joshi , Shirley Wang , pgadmin-hackers Content-Type: multipart/alternative; boundary=001a1137949e9d0092054e2760ed X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1137949e9d0092054e2760ed Content-Type: text/plain; charset=UTF-8 On Thu, Apr 27, 2017 at 3:18 PM, Robert Eckhardt wrote: > > > On Thu, Apr 27, 2017 at 7:01 AM, Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Hi Dave >> >> As per discussion I have changed the logic of showing partitioned table >> in browser tree. Attached is the screenshot. >> Let me know your thoughts. >> > > Greenplum has had declarative partitioning for quite some time, I haven't > spent much time diving into the Postgres implementation specifically, > however, we have had some pain and I would suggest a little bit of thought > behind this. > > The issues we consistently face: > > - The huge (often thousands sometimes tens of thousands) number of > partitions makes rendering all of the partitions painfully slow and > frequently not useful. > > Perhaps, though I doubt that number would be common in Postgres. The problem though, is that there are both stats and sub-objects (indexes and triggers for example) that are part of the child partitions, not the parent - and they may differ from partition to partition. I don't see that we have any choice but to display them so users can work with them. > > - When end users are interested in looking at their partitions they > frequently don't want all of them displayed mindlessly > - They are looking at a subset of partitions > - Partitions are typically grouped around their inheritance > properties. > > How might you propose grouping them (based on the way they work in Postgres)? -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a1137949e9d0092054e2760ed Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On Thu, Apr 27, 2017 at 3:18 PM, Robert Eckhardt <= reckhardt@pivotal= .io> wrote:


On Thu, Apr 27, 2017 at 7:01 AM, Akshay Joshi <<= a href=3D"mailto:akshay.joshi@enterprisedb.com" target=3D"_blank">akshay.jo= shi@enterprisedb.com> wrote:
Hi Dave

= As per discussion I have changed the logic of showing partitioned table in = browser tree. Attached is the screenshot.=C2=A0
Let me know your = thoughts. =C2=A0=C2=A0

G= reenplum has had declarative partitioning for quite some time, I haven'= t spent much time diving into the Postgres implementation specifically, how= ever, we have had some pain and I would suggest a little bit of thought beh= ind this.=C2=A0

The issues we consistently face:
  • The huge (often thousands sometimes tens of thousands) num= ber of partitions makes rendering all of the partitions painfully slow and = frequently not useful.
P= erhaps, though I doubt that number would be common in Postgres. The problem= though, is that there are both stats and sub-objects (indexes and triggers= for example) that are part of the child partitions, not the parent - and t= hey may differ from partition to partition. I don't see that we have an= y choice but to display them so users can work with them.
  • When end users are interested in looking at= their partitions they frequently don't want all of them displayed mind= lessly=C2=A0
    • They are looking at a subset of partitions
    • Partitions are typically grouped around their inheritance properties.=C2= =A0
How might you p= ropose grouping them (based on the way they work in Postgres)?=C2=A0


--
Dave Page
Blog: http://pgsnake.blogspot.comTwitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterpris= e PostgreSQL Company
--001a1137949e9d0092054e2760ed--