Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bUDY3-0000OV-Ov for pgadmin-hackers@arkaria.postgresql.org; Mon, 01 Aug 2016 13:46:27 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bUDY3-0000N0-72 for pgadmin-hackers@arkaria.postgresql.org; Mon, 01 Aug 2016 13:46:27 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bUDXq-00008N-BQ for pgadmin-hackers@postgresql.org; Mon, 01 Aug 2016 13:46:14 +0000 Received: from mail-it0-x22c.google.com ([2607:f8b0:4001:c0b::22c]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bUDXn-00005o-2v for pgadmin-hackers@postgresql.org; Mon, 01 Aug 2016 13:46:12 +0000 Received: by mail-it0-x22c.google.com with SMTP id j8so38421603itb.1 for ; Mon, 01 Aug 2016 06:46:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=1gVNGK86t/V1TOjo6ca1W2gulIVGHvQBzEXKmUFJrTQ=; b=KW8XCxMIdkMJwsY2EWg0VUkh9gPugI6rFtgakI60k6qMVU02NHEQ5lKx1ftd3XJTS0 4bnQpAhQaJGSsCUJLQMk+UbSBDIKRIsQA7c2P2N6X2UBT+PlVM43OVWZA1eHRb0QOJpN z7tlBvwXw6c12MNKqDSPGfyFbXWdZaRauo9Kx94S6gn3FiOkdg7gD6/1pVVozRAZHLvT M875EBBh4rj69SeuCJ3pyPo2MDYQOFbIXyg8/XPuRjHbf/ySu+4BuVyeifQBUfTcZvm0 ahyfvOgGdX/uYyFon15ro6uaQsE856Fecrlz24mKmrgH33Y7JZPY+CMTUhluv/2sv2tA wQ4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=1gVNGK86t/V1TOjo6ca1W2gulIVGHvQBzEXKmUFJrTQ=; b=U07Gsg/aVo9MvUallCHuwU2C+TNPQ7fQD3b4px2RY2/+G6QAsPbYJlDhon99DahvB0 zj3zBQKx05fIQ8hqJOQfU/tcyr8zpXUeICFyAjr7gDbN20XLqq/hFFM71M0Vw0P2fG39 TTYUwyuIfeVbyQHoxdnJCjmWl4q8A9pdWgefWn1FzZ2qvx1ah7g9QVMQy5CrBIVBlvsL y6AvfVzLInbXohPZkuWBgbdelXbZr00XnIJU4OICRPIr3OL2ZfEq9LkopPhpmVzJCM1U Qs97q40xh0zn81ILroXtbeAXOEIH89JA/E2bDd3X1XdjvxkgQLKt5rKZHxVBa24ecvpE 0RNQ== X-Gm-Message-State: AEkoous5ZxR8WAHGc74ipByepZVHROX2X6d+qu+gdo6+YBgKjQJC0wgjWfacqCf+s/IgFJIp89fheQpnalGcmg== X-Received: by 10.36.117.79 with SMTP id y76mr13004055itc.35.1470059169609; Mon, 01 Aug 2016 06:46:09 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.208.97 with HTTP; Mon, 1 Aug 2016 06:46:08 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Mon, 1 Aug 2016 14:46:08 +0100 Message-ID: Subject: Re: PATCH: Encoding issue with qtLiteral function (pgAdmin4) To: Murtuza Zabuawala Cc: pgadmin-hackers Content-Type: text/plain; charset=UTF-8 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org On Mon, Aug 1, 2016 at 2:33 PM, Murtuza Zabuawala wrote: > Hi Dave, > > We have to added it because postgres format_type() function do not provide > us type with 'public' schema prefix to it, due to which wrong SQL's are > getting generated. > Rest other types are pre fixed with their respective schema as required. OK, so: # If schema is not pg_catalog & then add schema if row['nspname'] == 'public': rtn_type = row['nspname'] + "." + row['typname'] else: rtn_type = row['typname'] ? != pg_catalog is redundant with == public. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers