MIME-Version: 1.0
In-Reply-To: 
 <CAKKotZQ7tGDP8BR63pqYzpKi=8TfXZ02p+CMQzWvOqL3tZRZvA@mail.gmail.com>
References: 
 <CAKKotZSda6+wgyzckDJPXKK3dc8U-UXho9hmaaBp+LwZzdnhaQ@mail.gmail.com>
	<CA+OCxoxNx3ghQZ+YnWeNpyVs_BaJE+yL7C6H-PUFh6ddpr061Q@mail.gmail.com>
	<CA+OCxozEyaxygwg4KKNWKjKcLw=a-s6R64Tij9Z2JSVzzEKLrg@mail.gmail.com>
	<CAKKotZTGn2aUnkrotK5u=9hh+nD4gUC9mvKWo2FcDVuEhH5oyA@mail.gmail.com>
	<CA+OCxoyeSbbyKFm236agok7DNr4iRt16On9Kea+Z3tUj_iXa_g@mail.gmail.com>
	<CAKKotZQVJPRkHKzhix+s9zc+QnwUfWfOj+sVFfk6c7abKuyECg@mail.gmail.com>
	<CA+OCxowYVt2V-sr5YQm-YDxhmNiam-4iSudNSmydu_e2_T3eMA@mail.gmail.com>
	<CAKKotZSrb=YrxbaasHQF9DXA-roFmzmA7cVC3tVPMdhYwL58cw@mail.gmail.com>
	<CA+OCxoz_rEVOMa1nfJxH16-ZB6YXozm-DAAV8HOE5EORqAwQLQ@mail.gmail.com>
	<CAKKotZTFTsZ2fHwMQem6v9prw8Un_qa8SqRmSanvU5eMXmTW8A@mail.gmail.com>
	<CA+OCxowAevPwtNb1O6Shx1NndTjNJYPBd_ie-xnk4Hw4j-nKqA@mail.gmail.com>
	<CA+OCxoxyCifnk7KT9ZZGBNYtH6gjCoJ7j8tUwSoBxzgAtCPZFA@mail.gmail.com>
	<CAKKotZQ7tGDP8BR63pqYzpKi=8TfXZ02p+CMQzWvOqL3tZRZvA@mail.gmail.com>
Date: Wed, 13 Apr 2016 13:48:46 +0100
Message-ID: 
 <CA+OCxozkSRx_Wp1r5wvPuG9neAvgDJ1rBvTCsAEAravbBAhvsw@mail.gmail.com>
Subject: Re: PATCH: Added Node Type & Catalog objects [pgAdmin4]
From: Dave Page <dpage@pgadmin.org>
To: Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: text/plain; charset=UTF-8
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

Hi

I'm seeing some more issues now, some related to new functionality:

- Please don't include the descriptive header for shell types in create.sql.

- Shell types can (and should) have owner/comments set if specified.

- The Type dropdown should just say "Shell" for shell types (no
additional text).

- Privileges and labels grids should be disabled for shell types.

- When I select External type, I see the following error (and a 500
error in the browser console):

2016-04-13 13:44:49,953: ERROR pgadmin: Failed to execute query
(execute_2darray) for the server #1 - DB:pem (Query-id: 4020898):
Error Message:ERROR:  syntax error at or near "and"
LINE 2:     CASE WHEN length(nspname) > 0 AND and length(nspname) !=...

- Length/Precision and scale are not shown in the dialogue for existing types.

Thanks.


On Fri, Apr 8, 2016 at 2:52 PM, Murtuza Zabuawala
<murtuza.zabuawala@enterprisedb.com> wrote:
> Hi Dave,
>
> Please find updated patches to fix all the mentioned issues.
>
> There are three patches,
> 1) One for fixing rendering issue when selecting type
> 2) Added utility function to fetch full type name with length & precision
> 3) Added new Shell type for External types.
>
>
> Regards,
> Murtuza
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Thu, Apr 7, 2016 at 5:06 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> Hi Murtuza
>>
>> On Tue, Mar 22, 2016 at 9:22 AM, Dave Page <dpage@pgadmin.org> wrote:
>> > Hi
>> >
>> > On Tue, Mar 22, 2016 at 8:14 AM, Murtuza Zabuawala
>> > <murtuza.zabuawala@enterprisedb.com> wrote:
>> >> Hi Dave,
>> >>
>> >> We can create new external type using below method, By running all of
>> >> below
>> >> queries at the same time , we can not create separate external type by
>> >> only
>> >> using create type statement.
>> >>
>> >> So as per my discussion with Ashesh, We should not allow user to create
>> >> external type in pgAdmin4 but only show definition in edit mode.
>> >
>> > Hmm, would it not make sense to allow the user to create the shell
>> > type as well (perhaps, with a new type of "SHELL")? Then they could do
>> > what is needed (and that should be easy, as it's just CREATE TYPE
>> > foo;)
>> >
>> > For example:
>> >
>> > CREATE TYPE box;
>> >
>> > CREATE FUNCTION my_box_in_function(cstring) RETURNS box AS ... ;
>> > CREATE FUNCTION my_box_out_function(box) RETURNS cstring AS ... ;
>> >
>> > CREATE TYPE box (
>> >     INTERNALLENGTH = 16,
>> >     INPUT = my_box_in_function,
>> >     OUTPUT = my_box_out_function
>> > );
>> >
>> > CREATE TABLE myboxes (
>> >     id integer,
>> >     description box
>> > );
>>
>> In the interests of making progress, I've committed the most recent
>> patch, with a number of minor changes most significantly, the Postgres
>> docs and system catalogs seem to have different ideas about what to
>> call length, precision and scale. pgAdmin 3 followed the catalogs and
>> used length and precision, however I've updated pgAdmin 4 to use
>> "Length/precision" and "Scale" which is inline with the Postgres docs.
>> That's only in the UI though - the code follows the catalogs.
>>
>> There are still a couple of issues - please provide fixes ASAP:
>>
>> 1) If you create a composite type that contains a sized type (e.g.
>> numeric(5, 4), the precision and scale are not shown if you later open
>> the properties dialogue, or in the reverse engineered SQL.
>>
>> E.g. what pgAdmin3 shows as:
>>
>> CREATE TYPE pem.blergh AS
>>    (c1 text COLLATE pg_catalog."C",
>>     c2 numeric(5));
>>
>> Is shown by pgAdmin4 as:
>>
>> CREATE TYPE pem.blergh AS
>>     (c1 text COLLATE pg_catalog."C", c2 numeric);
>>
>> (adding the \n's would be good too).
>>
>> 2) If you select a different type of type in create mode, the new
>> options are shown below those for the previously selected type,
>> instead of replacing them. Please see the attached screenshot.
>>
>> 3) I would still like us to support External types. I believe the
>> simple option here is to re-add the code you had previously, and to
>> add a new type of type called "SHELL" as discussed in my previous
>> email above. The user would then be able to create a SHELL type, add
>> the required functions, then come back and create the EXTERNAL type.
>>
>> I'll add cards to our internal kanban chart for these issues.
>>
>> Thanks.
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers