Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b8qUo-0001Qu-VW for pgadmin-hackers@arkaria.postgresql.org; Fri, 03 Jun 2016 14:54:47 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1b8qUo-0001j8-IH for pgadmin-hackers@arkaria.postgresql.org; Fri, 03 Jun 2016 14:54:46 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1b8qUb-0001V1-2n for pgadmin-hackers@postgresql.org; Fri, 03 Jun 2016 14:54:33 +0000 Received: from mail-io0-x230.google.com ([2607:f8b0:4001:c06::230]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1b8qUW-0007pd-8j for pgadmin-hackers@postgresql.org; Fri, 03 Jun 2016 14:54:32 +0000 Received: by mail-io0-x230.google.com with SMTP id k19so63361156ioi.3 for ; Fri, 03 Jun 2016 07:54:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=5C5m2Gf9JTMrJ9f+1qBL7wZPFNcehgCLvZaVKgMuhS8=; b=EBGwKUWV4ylBtRfC7L+HRreYmoUcTJ9Gt+yXTkL3csJaUPoDcOC18z8jLe8Scu0zon 0XDKmGvWOA1dEv/5T29nsSDHiG5AmQpY1XHNgj63W4KgOfw5kSyozRNoneIuuFuCdix/ IN+BUdJyVNT07aX2RPmzZLsL7qqnqrnrCdUJLxGhk11LjlQeu0MOZmdXU3s3RV9djgDq 67MPRd5Qsb6nLYebrq4K/dDx8TCmjaFEyeye7qOGdFLCK13jjPuUpRH1fMQs+FCiQNWY BEtS0Wo4gfY6W9+LHzO8etaoZ9kUB4hSKx19kFl6KtC88BxrwPFZpGOKUNahdvj5DCAd DGAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=5C5m2Gf9JTMrJ9f+1qBL7wZPFNcehgCLvZaVKgMuhS8=; b=YY1FqRCd5+WkYQua74IC1w1rkSCmwEtfThIpaIWUWGyJMoHeX4bh0Q2DQDaXNyRyLX DUTR1HdDrNag9J3JbCenUkQ9T+fLBVjBaDks/WVZCA4q+DOatX9Rp0KxFgCTpcs4k4ls 1rz/SRsS2J+8hvB/EbtGmO43yXTJvVV1ZTpGOOpy2ZzWa0TSMcSUTLqNz+75vV5KJ+Yg 1MvxLr0Muff5RPOqrjD4sbluBHfg4dfgLo9eT8F50TC8OfGIZL3/SPJpL9vqzqXRpFt9 xjjFRIBTtgfO1xs5QUnkMMRRFneWyPDhz2Me+vVumnImUkZXWNdcq205ncybMeqJ3EmS iF6Q== X-Gm-Message-State: ALyK8tLlTIV/C37wiYOY8uRB8vmAGtHUpE8jXOCCy+JzV+56s98340oJkbn9IqUYqlSs8mBsOJ1hUF0CuczSxw== X-Received: by 10.107.3.89 with SMTP id 86mr5523279iod.156.1464965666209; Fri, 03 Jun 2016 07:54:26 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.236.101 with HTTP; Fri, 3 Jun 2016 07:54:25 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Fri, 3 Jun 2016 15:54:25 +0100 Message-ID: Subject: Re: Patch for pgAdmin4 RPM package To: Sandeep Thakkar Cc: pgadmin-hackers , Hamid Quddus , =?UTF-8?B?RGV2cmltIEfDnE5Ew5xa?= Content-Type: multipart/alternative; boundary=001a113fc00224b6ed053460e603 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a113fc00224b6ed053460e603 Content-Type: text/plain; charset=UTF-8 My point is that the runtime uses the platform supplied Python interpreter, which presumably knows where to search for packages. Mind you, I suppose the issue there is that it wouldn't be able to distinguish between v1 and v2 then... I don't have a major issue with your suggested code - I just want to make sure we need it. On Fri, Jun 3, 2016 at 3:39 PM, Sandeep Thakkar < sandeep.thakkar@enterprisedb.com> wrote: > Do you mean to say when a python app is launched, it imports some modules > automatically and in that sense it knows about where it's site-packages > are? May be, but how the pgAdmin4 runtime will know where the Web App is > installed? > > The changes that I have done to the runtime is to let it know the path of > the Web App which is present in > "/site-packages/pgadmin4-web-v1/pgAdmin4.py" The changes done are not to > set the PythonPath like we did for appbundle because I thought it is not > needed and it will automatically load the modules from the site-packages, > but it is to set the ApplicationPath. > > I missed something? or misunderstood something? > > On Fri, Jun 3, 2016 at 7:39 PM, Dave Page wrote: > >> Hi, >> >> Well, I have to wonder why we need the changes to the runtime? We're >> linking the runtime with the same build of Python that's already on the >> system - doesn't it know where it's site-packages are already? I could see >> us needing this is we were using a distro-independent build of Python and >> wanted to find the OS site-packages location, but we're not. >> >> >> On Fri, Jun 3, 2016 at 10:15 AM, Sandeep Thakkar < >> sandeep.thakkar@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> how about changes in the pgadmin4 source code for conf.py and >>> Server.cpp? Looks okay? >>> >>> On Fri, Jun 3, 2016 at 2:41 PM, Sandeep Thakkar < >>> sandeep.thakkar@enterprisedb.com> wrote: >>> >>>> Thanks Dave. >>>> >>>> On Fri, Jun 3, 2016 at 2:08 PM, Dave Page wrote: >>>> >>>>> Hi >>>>> >>>>> On Thu, Jun 2, 2016 at 4:23 PM, Sandeep Thakkar >>>>> wrote: >>>>> > Hi Devrim, Hi Dave, >>>>> > >>>>> > I have updated the patch. The earlier patch may fail because of app >>>>> bundle >>>>> > commit in git. >>>>> > >>>>> > For testing, you may define the source tarball location as : >>>>> > Source0: >>>>> > >>>>> http://bugatti.pn.in.enterprisedb.com/temp/pgadmin4/%{name}-v%{version}.tar.gz >>>>> > >>>>> > Known issue that I'm still working on: >>>>> > 1. web rpm has a dependency on doc. But, even if I install doc, the >>>>> web >>>>> > still complains. Here is the scenario: >>>>> > [root@localhost tmp]# rpm -ivh >>>>> > dist/noarch/pgadmin4-web-1.0_dev-1.rhel7.noarch.rpm >>>>> > error: Failed dependencies: >>>>> > pgadmin4-doc = 1.0_dev is needed by >>>>> pgadmin4-web-1.0_dev-1.rhel7.noarch >>>>> > ... ( trimmed the python dependencies list here...) >>>>> > >>>>> > [root@localhost tmp]# rpm -ivh >>>>> > dist/noarch/pgadmin4-docs-1.0_dev-1.rhel7.noarch.rpm >>>>> > Preparing... >>>>> ################################# >>>>> > [100%] >>>>> > Updating / installing... >>>>> > 1:pgadmin4-docs-1.0_dev-1.rhel7 >>>>> ################################# >>>>> > [100%] >>>>> > >>>>> > >>>>> > [root@localhost tmp]# yum list | grep pgadmin4-docs >>>>> > pgadmin4-docs.noarch 1.0_dev-1.rhel7 >>>>> > installed >>>>> > >>>>> > >>>>> > [root@localhost tmp]# rpm -ivh >>>>> > dist/noarch/pgadmin4-web-1.0_dev-1.rhel7.noarch.rpm >>>>> > error: Failed dependencies: >>>>> > pgadmin4-doc = 1.0_dev is needed by >>>>> pgadmin4-web-1.0_dev-1.rhel7.noarch >>>>> >>>>> You have a typo - the Requires line is for pgadmin4-doc, but the RPM >>>>> is pgadmin4-docs. >>>>> >>>>> Oh, right. >>>> >>>> >>>>> Other review comments: >>>>> >>>>> - We have multiple identical pgadmin4.spec.in's in the patch. We need >>>>> to get that down to a single file. >>>>> >>>>> - In fact, why do we need a directory for each distro at all? As far >>>>> as I can see, the only difference is the $DIST definition, which is >>>>> surely something we can get programmatically very easily. It seems to >>>>> me we could reduce this all to 3 files - Makefile, README and >>>>> pgadmin4.spec.in >>>>> >>>>> Agree. I copied the structure from somewhere thinking this is good to >>>> have more OS specific changes. >>>> >>>> >>>>> - make rpm has a dependency on make prep. This has 2 issues as far as >>>>> I can see: >>>>> >>>>> - It does a git pull, which is bad. If I'm making an RPM from within >>>>> the source tree, I want it for the current source. The git pull only >>>>> makes sense for external builds, i.e. in a much larger automated build >>>>> system. >>>>> >>>>> - It goes and grabs the source code and patches from the FTP site. >>>>> Again, this is not what I want for an "in-tree" build. I want to use >>>>> the source code as I have it now. >>>>> >>>>> Okay. got it. Will remove downloading the tarballs and build the >>>> cloned source. >>>> >>>> >>>>> -- >>>>> Dave Page >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>> >>>> >>>> >>>> -- >>>> Sandeep Thakkar >>>> >>>> >>> >>> >>> -- >>> Sandeep Thakkar >>> Lead Software Engineer >>> >>> >>> Phone: +91.20.30589505 >>> >>> Website: www.enterprisedb.com >>> EnterpriseDB Blog: http://blogs.enterprisedb.com/ >>> Follow us on Twitter: http://www.twitter.com/enterprisedb >>> >>> This e-mail message (and any attachment) is intended for the use of the >>> individual or entity to whom it is addressed. This message contains >>> information from EnterpriseDB Corporation that may be privileged, >>> confidential, or exempt from disclosure under applicable law. If you are >>> not the intended recipient or authorized to receive this for the intended >>> recipient, any use, dissemination, distribution, retention, archiving, or >>> copying of this communication is strictly prohibited. If you have received >>> this e-mail in error, please notify the sender immediately by reply e-mail >>> and delete this message. >>> >> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > > -- > Sandeep Thakkar > Lead Software Engineer > > > Phone: +91.20.30589505 > > Website: www.enterprisedb.com > EnterpriseDB Blog: http://blogs.enterprisedb.com/ > Follow us on Twitter: http://www.twitter.com/enterprisedb > > This e-mail message (and any attachment) is intended for the use of the > individual or entity to whom it is addressed. This message contains > information from EnterpriseDB Corporation that may be privileged, > confidential, or exempt from disclosure under applicable law. If you are > not the intended recipient or authorized to receive this for the intended > recipient, any use, dissemination, distribution, retention, archiving, or > copying of this communication is strictly prohibited. If you have received > this e-mail in error, please notify the sender immediately by reply e-mail > and delete this message. > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a113fc00224b6ed053460e603 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
My point is that the runtime uses the platform supplied Py= thon interpreter, which presumably knows where to search for packages. Mind= you, I suppose the issue there is that it wouldn't be able to distingu= ish between v1 and v2 then...

I don't have a major i= ssue with your suggested code - I just want to make sure we need it.

On Fri, Jun 3, = 2016 at 3:39 PM, Sandeep Thakkar <sandeep.thakkar@enterpris= edb.com> wrote:
Do you mean to say when a python app is launched, it imports some mod= ules automatically and in that sense it knows about where it's site-pac= kages are? May be, but how the pgAdmin4 runtime will know where the Web App= is installed?=C2=A0

The changes that I have done to the= runtime is to let it know the path of the Web App which is present in &quo= t;/site-packages/pgadmin4-web-v1/pgAdmin4.py" The changes done are not= to set the PythonPath like we did for appbundle because I thought it is no= t needed and it will automatically load the modules from the site-packages,= but it is to set the ApplicationPath.

I missed so= mething? or misunderstood something?=C2=A0

On Fri, Jun= 3, 2016 at 7:39 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi,

Wel= l, I have to wonder why we need the changes to the runtime? We're linki= ng the runtime with the same build of Python that's already on the syst= em - doesn't it know where it's site-packages are already? I could = see us needing this is we were using a distro-independent build of Python a= nd wanted to find the OS site-packages location, but we're not.


On Fri, Jun 3, 2016 at 10:15 AM, Sandeep Thakkar <sandeep.thakkar@enterprisedb.com> wrote:
Hi Dave,=C2=A0

how abou= t changes in the pgadmin4 source code for conf.py and Server.cpp? Looks oka= y?

On Fri, Jun 3, 2016 at 2:41 PM, Sandeep Thakkar &l= t;san= deep.thakkar@enterprisedb.com> wrote:
Thanks Dave.=C2=A0

On Fri, Jun 3, 2016 at 2:08 PM, = Dave Page <dpage@pgadmin.org> wrote:
Hi

On Thu, Jun 2, 2016 at 4:23 PM, Sandeep Thakkar
<s= andeep.thakkar@enterprisedb.com> wrote:
> Hi Devrim, Hi Dave,
>
> I have updated the patch. The earlier patch may fail because of app bu= ndle
> commit in git.
>
> For testing, you may define the source tarball location as :
> Source0:
> http://bu= gatti.pn.in.enterprisedb.com/temp/pgadmin4/%{name}-v%{version}.tar.gz >
> Known issue that I'm still working on:
> 1. web rpm has a dependency on doc. But, even if I install doc, the we= b
> still complains. Here is the scenario:
> [root@localhost tmp]# rpm -ivh
> dist/noarch/pgadmin4-web-1.0_dev-1.rhel7.noarch.rpm
> error: Failed dependencies:
> pgadmin4-doc =3D 1.0_dev is needed by pgadmin4-web-1.0_dev-1.rhel7.noa= rch
> ... ( trimmed the python dependencies list here...)
>
> [root@localhost tmp]# rpm -ivh
> dist/noarch/pgadmin4-docs-1.0_dev-1.rhel7.noarch.rpm
> Preparing...=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 #################################
> [100%]
> Updating / installing...
>=C2=A0 =C2=A0 1:pgadmin4-docs-1.0_dev-1.rhel7=C2=A0 =C2=A0 ############= #####################
> [100%]
>
>
> [root@localhost tmp]# yum list | grep pgadmin4-docs
> pgadmin4-docs.noarch=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 1.0_dev-1.rhel7
> installed
>
>
> [root@localhost tmp]# rpm -ivh
> dist/noarch/pgadmin4-web-1.0_dev-1.rhel7.noarch.rpm
> error: Failed dependencies:
> pgadmin4-doc =3D 1.0_dev is needed by pgadmin4-web-1.0_dev-1.rhel7.noa= rch

You have a typo - the Requires line is for pgadmin4-doc, but th= e RPM
is pgadmin4-docs.

Oh, right.
=C2=A0
Other review comments:

- We have multiple identical pgadmin4.spec.in's in the patch. We need=
to get that down to a single file.

- In fact, why do we need a directory for each distro at all? As far
as I can see, the only difference is the $DIST definition, which is
surely something we can get programmatically very easily. It seems to
me we could reduce this all to 3 files - Makefile, README and
pg= admin4.spec.in

Agree. I copied the structure from somewhere t= hinking this is good to have more OS specific changes.
=C2= =A0
- make rpm has a dependency on make prep. This has 2 issues as far as I can= see:

=C2=A0 - It does a git pull, which is bad. If I'm making an RPM from wi= thin
the source tree, I want it for the current source. The git pull only
makes sense for external builds, i.e. in a much larger automated build
system.

=C2=A0 - It goes and grabs the source code and patches from the FTP site. Again, this is not what I want for an "in-tree" build. I want to = use
the source code as I have it now.

Okay. got it. Will remov= e downloading the tarballs and build the cloned source.
=C2= =A0
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Sandeep Thakkar




-= -
Sandeep Thakkar
Lead Software Engineer


Phone: +91.20.30589505

Website: www.enterprisedb.com
EnterpriseDB Blog: http://blogs.enterprisedb.com/
Follow us on Twitter: http://www.t= witter.com/enterprisedb

This e-mail message (and any attachment)= is intended for the use of the individual or entity to whom it is addresse= d. This message contains information from EnterpriseDB Corporation that may= be privileged, confidential, or exempt from disclosure under applicable la= w. If you are not the intended recipient or authorized to receive this for = the intended recipient, any use, dissemination, distribution, retention, ar= chiving, or copying of this communication is strictly prohibited. If you ha= ve received this e-mail in error, please notify the sender immediately by r= eply e-mail and delete this message.



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @= pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL= Company



--
Sandeep = Thakkar
Lead Software Engineer
<= br>
Phone: +91.20.30589505

Website: www.enterprisedb.com
EnterpriseDB = Blog: http://b= logs.enterprisedb.com/
Follow us on Twitter: http://www.twitter.com/enterpris= edb

This e-mail message (and any attachment) is intended for the= use of the individual or entity to whom it is addressed. This message cont= ains information from EnterpriseDB Corporation that may be privileged, conf= idential, or exempt from disclosure under applicable law. If you are not th= e intended recipient or authorized to receive this for the intended recipie= nt, any use, dissemination, distribution, retention, archiving, or copying = of this communication is strictly prohibited. If you have received this e-m= ail in error, please notify the sender immediately by reply e-mail and dele= te this message.



--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--001a113fc00224b6ed053460e603--