Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fQ8SK-0008Vc-15 for pgadmin-hackers@arkaria.postgresql.org; Tue, 05 Jun 2018 09:40:44 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fQ8SI-00044k-PZ for pgadmin-hackers@arkaria.postgresql.org; Tue, 05 Jun 2018 09:40:42 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fQ8SI-00044a-G5 for pgadmin-hackers@lists.postgresql.org; Tue, 05 Jun 2018 09:40:42 +0000 Received: from mail-wr0-x241.google.com ([2a00:1450:400c:c0c::241]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fQ8SE-0002jf-H1 for pgadmin-hackers@postgresql.org; Tue, 05 Jun 2018 09:40:42 +0000 Received: by mail-wr0-x241.google.com with SMTP id w7-v6so1646232wrn.6 for ; Tue, 05 Jun 2018 02:40:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=idL2EXAN75PhFNW8IUwz42LVWV4TtrCTD8yqg5WFlwE=; b=kOfHnI3OWZYyLpsVBBDsSbQ/scEW3eBR8Wyfo299nCjK+Rf2AtCm8I1WOYmA2D58I1 kTAVqxZl754s8o2G5jGfzUSgGxgPQ55VmwygM/dHsSYQkji9wij5Ga/p2EBI7ykvbwsf SMv1GeWAaKfa5f5iAScFj+dyQ7aDdcUziICHKe9EZ39vvjdrMvFtmML+82Hq3WFHMyEJ dBngxRjTs4S/yc06ZgOf66izUV0fwQ5c1i9VQ9JUNMf4SFp/0XvhSOx6WDCm08Ka8od+ JNwg1GGwAivcAnkpoxTEP7XGChlkbkwXtkPbzIYQBeTsBMnY6rSD446QBIunMgZw4pig ww0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=idL2EXAN75PhFNW8IUwz42LVWV4TtrCTD8yqg5WFlwE=; b=kEoiDqBAXrd7ociZgexzarRPhL2papfpPARt8mECi6vSC9fmyqmttkNeFvZI+GRxOK pW3zIzHSAsDozdR41o0hkIqTfkQWv8Mw+Nhjp7/EprI6ree4Td3Wf9TI4klsqwcxP1zx CJZ6r4B8ghdeejzGD6CtjsR5lAeiWut/OZJ+bvSVNb7cI2YTN7dYBL373OzY2kn/P/EP zK5UtTKFd6SLthmVKOnN93wdca+FStkt+WHBSUF9ovNoWeWYBhB7FwRNNziN1lxWOl9b DBRawzG1bhXvrKtTf4sJmI0fJ5deI2PqaURqq2bln3P0UMvHh8+IOM7eqh0+Z0V/aatb KVXA== X-Gm-Message-State: ALKqPwd3q+sc1PB3zMjBOCCMwL8aFXNq051Cn7dcYtLzZaHnpFrsvj31 E28rNaYFRjayVXK8S1s6hOWeamjCA4z40fmvY8L5mQ== X-Google-Smtp-Source: ADUXVKI42MmlS8vzxcFkDeN2/wgXnY8R08do5YKMsqCndyf1aQcMLepEO4QtOtxEukmX9dN1INPURkxpbZh8+RsROLo= X-Received: by 2002:adf:8211:: with SMTP id 17-v6mr18549822wrb.144.1528191636000; Tue, 05 Jun 2018 02:40:36 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a1c:2907:0:0:0:0:0 with HTTP; Tue, 5 Jun 2018 02:40:35 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Tue, 5 Jun 2018 10:40:35 +0100 Message-ID: Subject: Re: pgAgent 4.0 patch To: Ashesh Vashi Cc: pgadmin-hackers , Syed Fahar Abbas , Paresh More Content-Type: multipart/alternative; boundary="0000000000009ce21f056de1d796" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000009ce21f056de1d796 Content-Type: text/plain; charset="UTF-8" Thanks, committed with those changes. Paresh; can you please create some pgAgent 4.0 installers (PG not EPAS Bitrock installers) from git head for Fahar to test? Once he's happy with them, I'll tag and build the community packages. Thanks! On Tue, Jun 5, 2018 at 5:07 AM, Ashesh Vashi wrote: > On Mon, Jun 4, 2018 at 10:04 PM, Dave Page wrote: > >> Hi >> >> Can you review the attached please Ashesh? >> > Hi Dave, > > Due to the wrong pattern in '.gitignore', it was ignoring the new file > 'sql/pgagent--3.4--4.0.sql'. > We should ignore only the '*.sql' in the root directory. > Something like this. > > *$ git diff .gitignore* > *diff --git a/.gitignore b/.gitignore* > *index 9883354..40fe7a9 100644* > *--- a/.gitignore* > *+++ b/.gitignore* > *@@ -6,7 +6,12 @@ CPackSourceConfig.cmake* > * Makefile* > * cmake_install.cmake* > * install_manifest.txt* > *-pgagent* > *+# Ignore 'pgagent' & 'pgagent.control' in root directory only.* > *+/pgagent* > *+!/*/pgagent* > * pgagent.control* > *+!/*/pgagent.control* > * *.log* > *-*.sql* > *+# Ignore '*.sql' files in root directory only.* > *+/*.sql* > *+!/*/*.sql* > > > And, I am getting the following warning applying the patch. > > *$ git apply ~/Downloads/pgagent-4.0-update.diff* > */Users/asheshvashi/Downloads/pgagent-4.0-update.diff:320: trailing > whitespace.* > *//* > *warning: 1 line adds whitespace errors.* > > > Otherwise - it looks good to me. > > -- > > Thanks & Regards, > > Ashesh Vashi > EnterpriseDB INDIA: Enterprise PostgreSQL Company > > > > *http://www.linkedin.com/in/asheshvashi > * > >> >> Thanks. >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --0000000000009ce21f056de1d796 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, committed with those changes.

P= aresh; can you please create some pgAgent 4.0 installers (PG not EPAS Bitro= ck installers) from git head for Fahar to test?

On= ce he's happy with them, I'll tag and build the community packages.=

Thanks!
On Tue, Jun 5, 2018 at 5:07 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
On Mon, Jun 4= , 2018 at 10:04 PM, Dave Page <dpage@pgadmin.org> wrote:
=
Hi

Can you review the attached please Ashesh?
=
Hi D= ave,

Due to the wrong pattern in '.gitignore', = it was ignoring the new file 'sql/pgagent--3.4--4.0.sql'.
We should ignore only the '*.sql= 9; in the root directory.
Some= thing like this.
$=C2=A0git diff .gitignore
diff --git a/.gitignore b/.gitignore
index 9883354..40fe7a9 100644<= /i>
--- a/.gitignore=
+++ b/.gitignore
@@ -6,7 +6,12 @@ CPac= kSourceConfig.cmake
=C2=A0Makefile
=C2=A0cmake_install.cmake
=C2=A0install_manifest.txt
= -pgagent
+# Ignore 'pgagent' & 'pgagent.control'= ; in root directory only.
+/pgagent
+!/*/pgagent
=C2=A0pgagent.control
+!/*/pgagent.control
=C2=A0*.log
-*.sql
= +# Ignore '*.sql' files in root directory only.
+/*.sql
=
+!/*/*.sql

And, I am getting the following warning applying the patc= h.
$=C2=A0git= apply ~/Downloads/pgagent-4.0-update.diff
/Users/asheshvashi/Downloads/pgagent= -4.0-update.diff:320: trailing whitespace.
= //
warning: 1 line adds whitespace errors.

Otherwise - it looks good to me.

--

Thanks & Regards,<= /span>

Ashesh Vashi
EnterpriseDB INDIA:=C2=A0Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi=C2= =A0

<= div>
Thanks.

--
Dave Page=
Blog: http://= pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprised= b.com
The Enterprise PostgreSQL Company




--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--0000000000009ce21f056de1d796--