Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iSicO-0001uu-5T for pgadmin-hackers@arkaria.postgresql.org; Thu, 07 Nov 2019 14:18:36 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iSicM-000848-SQ for pgadmin-hackers@arkaria.postgresql.org; Thu, 07 Nov 2019 14:18:34 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iSicM-000840-8r for pgadmin-hackers@lists.postgresql.org; Thu, 07 Nov 2019 14:18:34 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iSicI-0000cZ-RF for pgadmin-hackers@postgresql.org; Thu, 07 Nov 2019 14:18:33 +0000 Received: by mail-wr1-x444.google.com with SMTP id b3so3160525wrs.13 for ; Thu, 07 Nov 2019 06:18:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fPFqKmmlPaIeKmi5J5KkLjwimAGd7yzd0vLveLs72t4=; b=KVGVVh8QXZMb7+tDtfqO+YK/e/p0/VOCzAvQUShuXSjptodAc/UW1bmu9uH872jOa+ RNI5e/OgrDP7Nm4t5qFoNCFb4aQyOUjaH49/M7gtfwCS/e3ULxOPSsHEwFB1eNEQXzz7 0bxkLXRhkhGasouemHRmsrMHSRwHGdBkIKUOvAm93CI7C/40h8SlLQcT8OmvnuilvooG XquWnKOymbZsazxS0tBs1Kbc1GNNYZkAGZxpvRV1ij8gUVqea7/sOW2laJz8yVjJiALs YJ+DmYRq2MHwDhC8x4x2OdsWELb5UQGzPQ9SOv7qdJl2jwNy+nDjOdl1cYArqM/qwGKO H5mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fPFqKmmlPaIeKmi5J5KkLjwimAGd7yzd0vLveLs72t4=; b=ViV8X1Ls5OvXJIsPuhEDnuVtpdzRDKrEUXOGeA4Aph424N6j01G1koJ+iwSjmz8uzC nLGmv+l6+9zBWEAz6RMpT5eFpqz8/sDkITBUuZCCUkiQT7ZOcauKzNAFdPw6MnMkXsEO 6iALEaQGovrjI/We7XLFOyAM8ktPOxPd1Hp7S/jBDVx8SoiWNypKY0Q2WwNW4WF9Ck/P uoqveVUejz0lH8QHGNOwgtfeB2xRVmtinoKwKoC1ip7WsCVYFLo6r4wSQUunrQHEMfqz KdcaQs7kXCZwwxhlQKV5Ju/BTxsluZIV2xCW75RrSJ1kS753tw1laKhk5RUNHwZFHP9z eInQ== X-Gm-Message-State: APjAAAXcmLiocQjllbaAG6IclrSFES66gzX+12iNN59cfW5iIMdzKoQ6 GYbXSDlmQLHGxjirv0MDxPtsFK2czWY7aOzOi6cpDw== X-Google-Smtp-Source: APXvYqzDtaBk1hdu6eavkRLZ1bhSu8u4LmcahIShzbqC+kWFQi1X2TxG1+dcWQDQfv4Xpqp7oQ97H6E/5C/jgVhkoOM= X-Received: by 2002:adf:9381:: with SMTP id 1mr3108200wrp.10.1573136308685; Thu, 07 Nov 2019 06:18:28 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Thu, 7 Nov 2019 14:18:16 +0000 Message-ID: Subject: Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme To: Akshay Joshi Cc: Aditya Toshniwal , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000dceaef0596c25615" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000dceaef0596c25615 Content-Type: text/plain; charset="UTF-8" On Thu, Nov 7, 2019 at 1:25 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Thu, Nov 7, 2019 at 6:39 PM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the updated patch with few more changes and corrections. >> Kindly review. >> > I've committed a couple of minor tweaks - one to remove a space, e.g. gettext('A page refresh is required to apply the theme. Do you wish to refresh the page now ?'), is now: gettext('A page refresh is required to apply the theme. Do you wish to refresh the page now?'), And another change to fix the word wrapping in the README which was totally different from the rest of the file. Thanks! >> On Wed, Nov 6, 2019 at 12:32 PM Aditya Toshniwal < >> aditya.toshniwal@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the patch to introduce theme options in pgAdmin. >>> Changes include: >>> 1) New theme option in preferences - Miscellaneous -> Themes. You can >>> select the theme from the dropdown. It also has a preview of the theme just >>> below the dropdown. Note that, a page refresh is needed to apply changes. >>> On saving, a dialog appears to ask for refresh. >>> 2) You can create your own theme and submit to hackers. README is >>> updated to help you create a theme. Theme will be available only after >>> bundle. >>> 3) Correction of SASS variables at few places and few other CSS >>> corrections. >>> 4) Added iconfont-webpack-plugin, which will convert all the svg >>> files(monochrome) used as icons for buttons to font icons. This will allow >>> us to change the color of icon by using CSS color property. >>> 5) All the .css files will bundle into a separate file now- >>> pgadmin.style.css. This will help reduce the size of theme css files as CSS >>> in .css files will not change with the change of SASS variables. >>> 6) "Dark Beta" theme added as a new theme option. >>> >>> How theme is built ? >>> Webpack config is changed to achieve it. On running yarn run bundle, >>> code will read all the directories in web/pgadmin/static/scss/resources >>> which will be considered as theme dirs, build a separate css for every >>> theme and then create a file named pgadmin.themes.json which will have all >>> the information required. >>> >>> The patch also fixes RM4173, where there some issue with arrow icons in >>> browser tree. >>> >>> Kindly review. >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> Sr. Software Engineer | EnterpriseDB India | Pune >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Sr. Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --000000000000dceaef0596c25615 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Thu, Nov 7, 2019 at 1:25 PM Akshay Jos= hi <akshay.joshi@enterp= risedb.com> wrote:
Thanks, patch applied.

On Thu, Nov 7, 2019 at 6:= 39 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
=
Hi Hackers,

Attached is the updated patch with few more changes and correc= tions.
Kindly review.

I've commi= tted a couple of minor tweaks - one to remove a space, e.g.
gettext('A =
page refresh is required to apply the theme. Do you wish to refresh the pag=
e now ?'),
is now:
gettext('A page refresh i=
s required to apply the theme. Do you wish to refresh the page now?'),
And another change to fix the word wrapping in the R= EADME which was totally different from the rest of the file.

=
Thanks!


On Wed, Nov 6, 2019 at 12:32 PM Aditya Toshniwal <aditya.toshniwal= @enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to i= ntroduce theme options in pgAdmin.
Changes include:
1) New theme option in preferences - Miscellaneous -> Themes. You ca= n select the theme from the dropdown. It also has a preview of the theme ju= st below the dropdown. Note that, a page refresh is needed to apply changes= . On saving, a dialog=C2=A0appears to ask for refresh.
2) You can create your own theme and submit = to hackers. README is updated to help you create a theme. Theme will be ava= ilable only after bundle.
3) Correction of SASS variables at few places and few other CSS correctio= ns.
4) Added iconfont-webpack-= plugin, which will convert all the svg files(monochrome) used as icons for = buttons to font icons. This will allow us to change the color of icon by us= ing CSS color property.
5) All the .css files will bundle into a separate file now- pgadmin.style.= css. This will help reduce the size of theme css files as CSS in .css files= will not change with the change of SASS variables.
6) "Dark Beta" theme added as a new = theme option.

How theme is built ?
Webpack config is changed to achieve it.=C2=A0On running yarn run bundl= e, code will read all the directories in=C2=A0web/pgadmin/static/scss/resou= rces which will be considered as theme dirs, build a separate css for every= theme and then create a file named pgadmin.themes.json which will have all= the information required.

The patch also= fixes RM4173, where there some issue with arrow icons in browser tree.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer |=C2=A0Ente= rpriseDB India |=C2=A0Pune
"Don't Complain about Heat, Plant a TREE"<= /div>


--
Th= anks and Regards,
Aditya = Toshniwal
Sr. Software Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain a= bout Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
<= font color=3D"#3333FF">Sr. Software Architect=
<= font color=3D"#000000" face=3D"arial, sans-serif">EnterpriseDB Software = India Private Limited
Mobile: +91 976-788-8246=


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @p= gsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL = Company
--000000000000dceaef0596c25615--