Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1snwvn-0078kk-C6 for pgadmin-hackers@arkaria.postgresql.org; Tue, 10 Sep 2024 09:13:05 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1snwvn-00A9b1-0f for pgadmin-hackers@arkaria.postgresql.org; Tue, 10 Sep 2024 09:13:03 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1snwvl-00A9Yo-Rg for pgadmin-hackers@lists.postgresql.org; Tue, 10 Sep 2024 09:13:02 +0000 Received: from mail-lj1-x229.google.com ([2a00:1450:4864:20::229]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1snwvh-000RTl-Vk for pgadmin-hackers@postgresql.org; Tue, 10 Sep 2024 09:13:00 +0000 Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2f75c6ed428so32526011fa.0 for ; Tue, 10 Sep 2024 02:12:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; t=1725959576; x=1726564376; darn=postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=vktbzwwckv78NlnL59xoc0ulkZnFwTthx0ZHnRvBuL8=; b=VXZx/OwWepJq8I4UHodqCCMxZl9QGVMXvS3HcxsmfUpLZMiLfkgU0N7fEfCMgxdaw5 rbjACRsvzYiZJZMdr70zETrRWEuLQUacUGcSdfPda214eQ7gEOsLd6ZaV+J3VP6k8DHR L+tHsANJN2LAKl5R6DpiTMJZlPiyrELXILQLGZP5z29oCW4W2r3HdiVtolTL0X5HQ+t0 JYIRuTnZDh4Io9oDBJsWw3OomdUhVtOHCyEBr1ku3Eci8sF0lznKS+M+PkaXgbtFawxb Hk5d/a90mKtX3RNgeWSp5CZACyX1jhyzgNXcm0Uwh9xqfSnLWu6P/jmoQDT1khNRbEfI lWeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725959576; x=1726564376; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vktbzwwckv78NlnL59xoc0ulkZnFwTthx0ZHnRvBuL8=; b=Ag4Z2sPSfAVIreTGuF8bJOrDjXaVSylTdR+Rs/wSqEFGIfs6RNXMno1tIEhTmmTcOO dRaTfpSytGV4p8MRH/kSkFqVGSGi7S8aX3e0QThQM1OyRMEqngQdyzrZfLy5No7KjeAP rlAWICa4QocukVfp6BlZVl3Yqe1yqonNRvnvYuzpF9+HaBSCx3ohY2MsVwLfzOVFUNsL 8jsLfS3PR6Hxchn70LsaE27QuvNBvwdW6UD1o7mg8zABzEi8ciyVNXg+zp7r6UbLQuXC hcY+ReaWWtVpKBz3K+Cgp6b+wD3R1Y8BKS++ub1UzA4XI8iGM0158zR4lBpxnyGlutUU sHmg== X-Gm-Message-State: AOJu0YzNDLT4dwTUcQ69nveWAwej91E9Qn/olQ4aTjFPOmgEpvTkUiym b674SYnVn7o3WRKyexNjA6auF3J3Su24LhVlwxfU1xECkly0W1rgO7r5v8Rld0LXeJT/5zW/bv1 1ViFj11Yc5UJHtEF3pcNAB+Vz9aWYfYtojO4p X-Google-Smtp-Source: AGHT+IFeEi4q41CYNXzz5L9j6FkgR5EKmmBu5dvdIm0vU1RlYmnC3Xcd02DEBzNbV/SMloA0tuas9gH/nk1gzqc+TeU= X-Received: by 2002:a2e:be0e:0:b0:2f7:5d53:7196 with SMTP id 38308e7fff4ca-2f75d5375aamr79199631fa.4.1725959575903; Tue, 10 Sep 2024 02:12:55 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Tue, 10 Sep 2024 10:12:44 +0100 Message-ID: Subject: Re: Require suggestions for Issue #2874 To: Rohit Bhati Cc: pgadmin-hackers@postgresql.org Content-Type: multipart/alternative; boundary="0000000000006b41100621c047f8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --0000000000006b41100621c047f8 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Shadow is more visible, but it doesn't really follow the material UI styling which is flat rather than 3D. I think Anil's idea is worth exploring; remove the alternating colour for the row number column, and use a different background shade for it entirely= . On Tue, 10 Sept 2024 at 08:38, Rohit Bhati wrote: > Hi Dave, > > I have added shadow to make the text more distinct and attached > screenshots based on themes. > Please once check and let me know if we can go ahead with this or provide > suggestions if need to make changes. > > Thanks & Regards > Rohit Bhati > > > On Mon, Sep 9, 2024 at 4:11=E2=80=AFPM Rohit Bhati > wrote: > >> I already set weight to 900. >> If we need to be more distinct then I think we can have some shadow or i= f >> anything else please suggest. >> >> On Mon, Sep 9, 2024 at 3:29=E2=80=AFPM Dave Page wro= te: >> >>> Hi >>> >>> On Mon, 9 Sept 2024 at 10:18, Rohit Bhati >>> wrote: >>> >>>> Hi Dave, >>>> >>>> I have made changes as per your suggestions. >>>> I have attached screenshots showing how the updates look across all >>>> themes for your reference. >>>> >>>> If the current changes does not fit well with the theme or if you have >>>> any suggestions for improvements, please let me know. >>>> >>> >>> The colours etc. look correct now (ie. there are no weird borders), but >>> I still don't think the row number looks visually distinct from the res= t of >>> the data. The bold text simply isn't very bold - I think it still needs >>> more weight. >>> >>> >>> >>>> >>>> Thanks >>>> Rohit Bhati >>>> EnterpriseDB >>>> >>>> >>>> On Fri, Sep 6, 2024 at 2:01=E2=80=AFPM Dave Page w= rote: >>>> >>>>> >>>>> >>>>> On Fri, 6 Sept 2024 at 09:25, Rohit Bhati < >>>>> rohit.bhati@enterprisedb.com> wrote: >>>>> >>>>>> I have made some more changes with changing background color. >>>>>> >>>>> >>>>> Yeah, that looks weird again, specifically on the selected rows. I >>>>> believe the issue is that we should not highlight the row number colu= mn >>>>> when a row is selected at all. That makes sense, as we should only be >>>>> highlighting the columns that would get copied in a copy/paste operat= ion >>>>> anyway. >>>>> >>>>> Also, the bold still doesn't look bold. I think the weight needs to b= e >>>>> increased. >>>>> >>>>> >>>>>> >>>>>> I have attached screenshots showing how the updates look across all >>>>>> themes. >>>>>> >>>>>> On Fri, Sep 6, 2024 at 1:51=E2=80=AFPM Dave Page = wrote: >>>>>> >>>>>>> Hi >>>>>>> >>>>>>> On Fri, 6 Sept 2024 at 09:19, Rohit Bhati < >>>>>>> rohit.bhati@enterprisedb.com> wrote: >>>>>>> >>>>>>>> Hi, >>>>>>>> >>>>>>>> I have removed the border and background color, just made the row >>>>>>>> numbers bold. >>>>>>>> >>>>>>>> I have attached screenshots showing how the updates look across al= l >>>>>>>> themes. >>>>>>>> >>>>>>> >>>>>>> That doesn't look bold at all to me - and I think we still need som= e >>>>>>> other visual distinction, such as the column background colour. >>>>>>> >>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> On Fri, Sep 6, 2024 at 12:35=E2=80=AFPM Khushboo Vashi < >>>>>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> On Thu, Sep 5, 2024 at 7:11=E2=80=AFPM Dave Page >>>>>>>>> wrote: >>>>>>>>> >>>>>>>>>> Hi >>>>>>>>>> >>>>>>>>>> On Thu, 5 Sept 2024 at 14:38, Rohit Bhati < >>>>>>>>>> rohit.bhati@enterprisedb.com> wrote: >>>>>>>>>> >>>>>>>>>>> Hi, >>>>>>>>>>> >>>>>>>>>>> I have made changes for issue #7863 >>>>>>>>>>> based on >>>>>>>>>>> theme requirements. >>>>>>>>>>> >>>>>>>>>>> I have attached screenshots showing how the updates look across >>>>>>>>>>> all themes for your reference. >>>>>>>>>>> >>>>>>>>>>> If the current color does not fit well with the theme or if you >>>>>>>>>>> have any suggestions for improvements, please let me know. >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> Is the colour contrast high enough on the row numbers for >>>>>>>>>> selected rows in the high contrast theme? The black on grey seem= s like it >>>>>>>>>> might not be to me, but I haven't tested. >>>>>>>>>> >>>>>>>>>> I wonder also if we should make the row numbers bold all the >>>>>>>>>> time. Thoughts? >>>>>>>>>> >>>>>>>>> We can check how it looks. Also the cell border doesn't look good >>>>>>>>> to me. >>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Dave Page >>>>>>>>>> pgAdmin: https://www.pgadmin.org >>>>>>>>>> PostgreSQL: https://www.postgresql.org >>>>>>>>>> EDB: https://www.enterprisedb.com >>>>>>>>>> >>>>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/ >>>>>>>>>> >>>>>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Dave Page >>>>>>> pgAdmin: https://www.pgadmin.org >>>>>>> PostgreSQL: https://www.postgresql.org >>>>>>> EDB: https://www.enterprisedb.com >>>>>>> >>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/ >>>>>>> >>>>>>> >>>>> >>>>> -- >>>>> Dave Page >>>>> pgAdmin: https://www.pgadmin.org >>>>> PostgreSQL: https://www.postgresql.org >>>>> EDB: https://www.enterprisedb.com >>>>> >>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/ >>>>> >>>>> >>> >>> -- >>> Dave Page >>> pgAdmin: https://www.pgadmin.org >>> PostgreSQL: https://www.postgresql.org >>> EDB: https://www.enterprisedb.com >>> >>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/ >>> >>> --=20 Dave Page pgAdmin: https://www.pgadmin.org PostgreSQL: https://www.postgresql.org EDB: https://www.enterprisedb.com PGDay UK 2024, 11th September, London: https://2024.pgday.uk/ --0000000000006b41100621c047f8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

Shadow is more visible, b= ut it doesn't really follow the material UI styling which is flat rathe= r than 3D.

I think Anil's idea is worth explor= ing; remove the=C2=A0alternating colour for the row number column, and use = a different background shade for it entirely.

On Tue, 10 Sept 2024 at 08:38,= Rohit Bhati <rohit.bhat= i@enterprisedb.com> wrote:
Hi=C2=A0Dave,

I have added shadow to make the text=C2=A0more distinct and attached screenshots based on th= emes.
Please once check and let me=C2=A0know if we can go=C2=A0ah= ead with this or provide suggestions if need to make changes.

Thanks= & Regards
Rohit Bhati


<= div dir=3D"ltr" class=3D"gmail_attr">On Mon, Sep 9, 2024 at 4:11=E2=80=AFPM= Rohit Bhati <rohit.bhati@enterprisedb.com> wrote:
I already set weight to 900.
If we need to be more d= istinct then I think we can have some shadow or if anything else please sug= gest.

On Mon, Sep 9, 2024 at 3:29=E2=80=AFPM Dave Page <dpage@pgadmin.org> wrote:<= br>
Hi

On Mon, 9 Sept 2024 at 10= :18, Rohit Bhati <rohit.bhati@enterprisedb.com> wrote:
Hi Dave,

I have made changes as per your sug= gestions.
I have attached screenshots showing how the updates look acros= s all themes for your reference.

If the current changes does not fit= well with the theme or if you have any suggestions for improvements, pleas= e let me=C2=A0know.

The colours e= tc. look correct now (ie. there are no weird borders), but I still don'= t think the row number looks visually distinct from the rest of the data. T= he bold text simply isn't very bold - I think it still needs more weigh= t.

=C2=A0
<= br>Thanks
Rohit Bhati
EnterpriseDB


On Fri, Sep 6, 2024 at 2:01= =E2=80=AFPM Dave Page <dpage@pgadmin.org> wrote:


On Fri, 6 Sept 2024 at 09:25, Rohit Bhati <= ;rohit.bh= ati@enterprisedb.com> wrote:
I have made some more changes with changing background color.
=

Yeah, that looks weird again, specifically= =C2=A0on the selected rows. I believe the issue is that we should not highl= ight the row number column when a row is selected at all. That makes sense,= as we should only be highlighting the columns that would get copied in a c= opy/paste operation anyway.

Also, the bold still d= oesn't look bold. I think the weight needs to be increased.
= =C2=A0

I have attached screenshots showing how the updates look across a= ll themes.

On Fri, Sep = 6, 2024 at 1:51=E2=80=AFPM Dave Page <dpage@pgadmin.org> wrote:
Hi

On Fri, 6 Sept 2024 at 09:19, Rohit Bhati <= ;rohit.bh= ati@enterprisedb.com> wrote:
Hi,

I have removed the border and background color, just=C2=A0made the=C2=A0row numbers bold.

I have attached screenshots showing how the updates look across all t= hemes.

That doesn't look bold at all to me - and I thin= k we still need some other visual distinction, such as the column backgroun= d colour.
=C2=A0


<= div dir=3D"ltr" class=3D"gmail_attr">On Fri, Sep 6, 2024 at 12:35=E2=80=AFP= M Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:


On Thu, Sep 5, 2024 at 7= :11=E2=80=AFPM Dave Page <dpage@pgadmin.org> wrote:
Hi

On Thu, 5 Sept 2024 at 14:38, Rohit Bhati <rohit.bhati@enterpris= edb.com> wrote:
Hi,
<= br>I have made changes for issue #7863=C2=A0based on theme requi= rements.

I have attached screenshots showing how the updates look ac= ross all themes for your reference.

If the current color does not fi= t well with the theme or if you have any suggestions for improvements, plea= se let me know.

Is the colo= ur contrast high enough on the row numbers for selected rows in the high co= ntrast theme? The black on grey seems like it might not be to me, but I hav= en't tested.
=C2=A0
I wonder also if we should make= the row numbers bold all the time. Thoughts?
We can check how it looks. Also the cell border doesn't look good= to me.


--
Dave Page
PostgreSQL: https://www.postgresql.org<= br>

PGDay UK 2024, = 11th September, London: https://2024.pgday.uk/



--
Dave Page
PostgreSQL: https://www.postgresql.or= g

PGDay UK = 2024, 11th September, London: https://2024.pgday.uk/



--
Dave Page
PostgreSQL: https://www.postgresql.or= g

PGDay UK = 2024, 11th September, London: https://2024.pgday.uk/



--
Dave Page
PostgreSQL: https://www.postgresql.or= g

PGDay UK = 2024, 11th September, London: https://2024.pgday.uk/



--
Dave Page
PostgreSQL: https://www.postgresql.or= g

PGDay UK = 2024, 11th September, London: https://2024.pgday.uk/

--0000000000006b41100621c047f8--