Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bn52E-0004eW-5P for pgadmin-hackers@arkaria.postgresql.org; Thu, 22 Sep 2016 14:31:34 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bn52D-0001Ys-Ia for pgadmin-hackers@arkaria.postgresql.org; Thu, 22 Sep 2016 14:31:33 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bn52D-0001Ym-5G for pgadmin-hackers@postgresql.org; Thu, 22 Sep 2016 14:31:33 +0000 Received: from mail-ua0-x231.google.com ([2607:f8b0:400c:c08::231]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bn526-0006Ce-6O for pgadmin-hackers@postgresql.org; Thu, 22 Sep 2016 14:31:32 +0000 Received: by mail-ua0-x231.google.com with SMTP id q42so1351327uaq.1 for ; Thu, 22 Sep 2016 07:31:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=oSx69SalrdZAvpyzSEZUaGkMH44SugudSDHj6b2HYJY=; b=p8bvWEPWsjzSF8/7PyTQPiF2nUUNilO++NCS6QGgTwUF765YxaUiMeOJwnXRp3n9a0 dUPQ3n/B7RjKFdwVaWk4jjaAHAvsff+Sx3SR4RAFIVOq/JATqndMMo1tGmk7xzpDCGU2 izlHoBddn0ltF4e/bPtRoewogOSK7xVY++W1L1QoafRGD3WPFkBa3kGPhQjLncJZ3ljS A9UC0wAM6y9Z8bifTbplOgKQI5k3anBLRDJiTFGmtP/nKDylreOEuoUqV4nYAol9iRKB dYRsgpzlRjKtTgKKwQAZkHZyW2XrrciBNnxjcoO5NYpoGusaOY+OmnKKfP0slBropNjz EkCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=oSx69SalrdZAvpyzSEZUaGkMH44SugudSDHj6b2HYJY=; b=EDYxkQAfahobu9B7rt0YNUhoW2CTxaT6UxUgBLXvpULAlR1ePgZoaih5PF1wM0BEKa qSP0dzwBXzfUwHJeXLVafjM8GMsU7+7mLabzKq5+a3wBD/qaXtP0fefsvsIiWdMTNGnD obgU9BlOxibfLI/gDsa6uS21MlgfvLOlvznTdy3NaYEVnAYRl6JzbR/8yuX16IVVhW7v nQ5qhByKJz7u2Mu7CwP8B4UTbhDhExgDfzoeLFre2gU1QJoh6IHUTNPdIEoVgAoCuguj ilN5vGPTcC8NkOGAvLSGiFv/tUEGy+M5McNnDNJsxa3MWQRXkN7Izolwy973VEQSZLQX AwVg== X-Gm-Message-State: AE9vXwPxGBnTVRd5bNLWcPgaD1BtGN1hWRLMEmn9xgGc60k4P7J2VCGNp1sBInb6iknTDXxueLInmmLWupxN1A== X-Received: by 10.176.7.65 with SMTP id h59mr189144uah.64.1474554684283; Thu, 22 Sep 2016 07:31:24 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.97.71 with HTTP; Thu, 22 Sep 2016 07:31:23 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Thu, 22 Sep 2016 15:31:23 +0100 Message-ID: Subject: Re: PATCH: pgAgent support To: Ashesh Vashi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=94eb2c12324828b4fe053d1984ce X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --94eb2c12324828b4fe053d1984ce Content-Type: text/plain; charset=UTF-8 Hi On Thu, Sep 22, 2016 at 11:47 AM, Ashesh Vashi < ashesh.vashi@enterprisedb.com> wrote: > Hi Dave, > > Please find the patch for support for paAgent in pgAdmin 4. > Did you forget the binary switch? piranha:web dpage$ git apply --binary ~/Downloads/pgagent_v2.patch error: cannot apply binary patch to 'web/pgadmin/browser/server_groups/servers/pgAgent/schedules/static/img/coll-pga_schedule.png' without full index line error: web/pgadmin/browser/server_groups/servers/pgAgent/schedules/static/img/coll-pga_schedule.png: patch does not apply error: cannot apply binary patch to 'web/pgadmin/browser/server_groups/servers/pgAgent/schedules/static/img/pga_schedule.png' without full index line error: web/pgadmin/browser/server_groups/servers/pgAgent/schedules/static/img/pga_schedule.png: patch does not apply error: cannot apply binary patch to 'web/pgadmin/browser/server_groups/servers/pgAgent/static/img/coll-pga_job.png' without full index line error: web/pgadmin/browser/server_groups/servers/pgAgent/static/img/coll-pga_job.png: patch does not apply error: cannot apply binary patch to 'web/pgadmin/browser/server_groups/servers/pgAgent/static/img/pga_job-disabled.png' without full index line error: web/pgadmin/browser/server_groups/servers/pgAgent/static/img/pga_job-disabled.png: patch does not apply error: cannot apply binary patch to 'web/pgadmin/browser/server_groups/servers/pgAgent/static/img/pga_job.png' without full index line error: web/pgadmin/browser/server_groups/servers/pgAgent/static/img/pga_job.png: patch does not apply error: cannot apply binary patch to 'web/pgadmin/browser/server_groups/servers/pgAgent/steps/static/img/coll-pga_jobstep.png' without full index line error: web/pgadmin/browser/server_groups/servers/pgAgent/steps/static/img/coll-pga_jobstep.png: patch does not apply error: cannot apply binary patch to 'web/pgadmin/browser/server_groups/servers/pgAgent/steps/static/img/pga_jobstep.png' without full index line error: web/pgadmin/browser/server_groups/servers/pgAgent/steps/static/img/pga_jobstep.png: patch does not apply > > I have also attached another patch for miscellaneous fixes, and adding new > controls. > It includes: > - Added DatetimepickerControl, MomentCell (using moment.js) > - Used the 'DatetimepickerControl' in Role (Also - resolved an issue, when > unset the datetime for 'Valid Until'.) > - Added a 'Select All/Unselect All' adaptor for Select2 used by pgAgent > nodes. > - Fixed an issue with SubNodeCollectionControl, which was not starting the > modification session of the child model, when created default value for > collection is not null/undefined. And, hence - validation on the child > model was not working. > - Fixed a memory leak with SqlFieldControl, and SqlTabControl, which was > not releasing the CodeMirror properly. > Urgh, that's big. Applied - but can you look at the following please? - Account expires has a hint of 'MMM D YYYY HH:mm:ss.SSS Z". Are milliseconds really needed? I also get 00 as a fractional timezone offset. Perhaps we should hide that, when it's 00? - The date format differs from the ISO format displayed by the query tool. They should be consistent - and really should be either based on the client's locale settings, or ISO format. Thanks. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --94eb2c12324828b4fe053d1984ce Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi

On Thu, Sep 22, 2016 at 11:47 AM, Ashesh Vashi <= ashesh.v= ashi@enterprisedb.com> wrote:
Hi Dave,

Please f= ind the patch for support for paAgent in pgAdmin 4.

Did you forget the binary switch?

=
piranha:web dpage$ git apply --binary ~/Downloads/pgagent_v2.patch=C2= =A0
error: cannot apply binary patch to 'web/pgadmin/browser/= server_groups/servers/pgAgent/schedules/static/img/coll-pga_schedule.png= 9; without full index line
error: web/pgadmin/browser/server_grou= ps/servers/pgAgent/schedules/static/img/coll-pga_schedule.png: patch does n= ot apply
error: cannot apply binary patch to 'web/pgadmin/bro= wser/server_groups/servers/pgAgent/schedules/static/img/pga_schedule.png= 9; without full index line
error: web/pgadmin/browser/server_grou= ps/servers/pgAgent/schedules/static/img/pga_schedule.png: patch does not ap= ply
error: cannot apply binary patch to 'web/pgadmin/browser/= server_groups/servers/pgAgent/static/img/coll-pga_job.png' without full= index line
error: web/pgadmin/browser/server_groups/servers/pgAg= ent/static/img/coll-pga_job.png: patch does not apply
error: cann= ot apply binary patch to 'web/pgadmin/browser/server_groups/servers/pgA= gent/static/img/pga_job-disabled.png' without full index line
error: web/pgadmin/browser/server_groups/servers/pgAgent/static/img/pga_jo= b-disabled.png: patch does not apply
error: cannot apply binary p= atch to 'web/pgadmin/browser/server_groups/servers/pgAgent/static/img/p= ga_job.png' without full index line
error: web/pgadmin/browse= r/server_groups/servers/pgAgent/static/img/pga_job.png: patch does not appl= y
error: cannot apply binary patch to 'web/pgadmin/browser/se= rver_groups/servers/pgAgent/steps/static/img/coll-pga_jobstep.png' with= out full index line
error: web/pgadmin/browser/server_groups/serv= ers/pgAgent/steps/static/img/coll-pga_jobstep.png: patch does not apply
error: cannot apply binary patch to 'web/pgadmin/browser/server_= groups/servers/pgAgent/steps/static/img/pga_jobstep.png' without full i= ndex line
error: web/pgadmin/browser/server_groups/servers/pgAgen= t/steps/static/img/pga_jobstep.png: patch does not apply=C2=A0

I have also attached another patch for miscellaneous fixes, and ad= ding new controls.
It includes:
- Added DatetimepickerC= ontrol, MomentCell (using moment.js)
- Used the 'Datetimepick= erControl' in Role (Also - resolved an issue, when unset the datetime f= or 'Valid Until'.)
- Added a 'Select All/Unselect All= ' adaptor for Select2 used by pgAgent nodes.
- Fixed an issue= with SubNodeCollectionControl, which was not starting the modification ses= sion of the child model, when created default value for collection is not n= ull/undefined. And, hence - validation on the child model was not working.<= /div>
- Fixed a memory leak with SqlFieldControl, and SqlTabControl, wh= ich was not releasing the CodeMirror properly.

Urgh, that's big. Applied - but can you look at the fol= lowing please?=C2=A0

- Account expir= es has a hint of 'MMM D YYYY HH:mm:ss.SSS Z". Are milliseconds rea= lly needed? I also get 00 as a fractional timezone offset. Perhaps we shoul= d hide that, when it's 00?

- The date format d= iffers from the ISO format displayed by the query tool. They should be cons= istent - and really should be either based on the client's locale setti= ngs, or ISO format.

Thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com=
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterpr= ise PostgreSQL Company
--94eb2c12324828b4fe053d1984ce--