MIME-Version: 1.0
In-Reply-To: 
 <CAKKotZQW3EwwSasyeE2uZd_f2_2j9gSdNgL+Tp+wjO=c9PwEPQ@mail.gmail.com>
References: 
 <CAKKotZTJY1zV+Edi_oJ3611WJVq4Qi4RXi00Ddzkp6iWJardMA@mail.gmail.com>
 <CA+OCxowMGSBwuAVj96y4eQ7FSFOnv943bkJZVzZ=SN8Rb3St3g@mail.gmail.com>
 <CAG7mmowVhXbusQ1ZO879GxNvXR0CoGETM27mgpiUebZzLzmMMQ@mail.gmail.com>
 <CA+OCxoy8FKgAT2RVw-yctkJcURmLKpk2bBcGqbneP+=F87BtNw@mail.gmail.com>
 <CAG7mmoykBtHBnzHhDCbJ2342MpggKx95Ng21Evy90FmcEynjVQ@mail.gmail.com>
 <CA+OCxoxU_n7oCMDv_gcAWfXpVYU_m--JjZbYYC1cuFYJPhW7wQ@mail.gmail.com>
 <CAG7mmoy23TqokXu8ppWXams2LHyyoDOze8CH1t+Xk2CuTUQwuA@mail.gmail.com>
 <CA+OCxoym1Afqb6P1fFBdbpqy1H2GnPUWZTdkKGG4fMh+0ncqwA@mail.gmail.com>
 <CAKKotZQtpV2Ya3=eOq8wanvH922bW4ypOM8aXJDjUAtB9wFdOQ@mail.gmail.com>
 <CA+OCxoyDihtqywWAq9FHYSyDtWNyxLB1WZG9s88_1LrY6u-eow@mail.gmail.com>
 <CAKKotZQW3EwwSasyeE2uZd_f2_2j9gSdNgL+Tp+wjO=c9PwEPQ@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Wed, 17 Aug 2016 14:39:43 +0100
Message-ID: 
 <CA+OCxoznXaQCXZTbjNErtjZeoGzR5+16fXAyQFK8BORQC+tGzA@mail.gmail.com>
Subject: Re: PATCH: To fix the issue where message panel was
 showing incomplete info (pgAdmin4)
To: Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>
Cc: Ashesh Vashi <ashesh.vashi@enterprisedb.com>,
	pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: text/plain; charset=UTF-8
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

Hi

On Tue, Aug 16, 2016 at 3:56 PM, Murtuza Zabuawala
<murtuza.zabuawala@enterprisedb.com> wrote:
> Hi Dave,
>
> PFA updated patch.

I just tested this, and found a number of issues:

- For a query like VACUUM FULL ANALYZE VERBOSE, the query runtime is
not displayed at the end of the messages. It is for SELECT queries
(note: pgAdmin 3 returns "Query returned successfully with no result
in 6.6 secs.").

- Messages seem to be duplicated. For example, the output from the
query above, run on pgAdmin3 is 95KB, whilst from pgAdmin4 it's
3.1MB(!). I believe it's because you're not clearing __notices in
messages(). I'm not entirely clear why that's even needed though -
can't we just return messages from self.conn.notices and clear that
directly?

- The messages div should scroll to the end as it's updated, per discussion.

Thanks.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers