Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kFamb-0004rP-1F for pgadmin-hackers@arkaria.postgresql.org; Tue, 08 Sep 2020 10:23:25 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kFama-0003Zt-00 for pgadmin-hackers@arkaria.postgresql.org; Tue, 08 Sep 2020 10:23:24 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kFamZ-0003TJ-03 for pgadmin-hackers@lists.postgresql.org; Tue, 08 Sep 2020 10:23:23 +0000 Received: from mail-ed1-x541.google.com ([2a00:1450:4864:20::541]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kFamW-0005tI-Di for pgadmin-hackers@postgresql.org; Tue, 08 Sep 2020 10:23:21 +0000 Received: by mail-ed1-x541.google.com with SMTP id c8so15433741edv.5 for ; Tue, 08 Sep 2020 03:23:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6FAaZSRvRaIigtQwI5Azy63L1NFWcHXYgkHsSPSyjyA=; b=gLVAxaHfm7NJITtkzJK6Zq7od+iBinDeWJaIU5zlBvhdSntHt8yMW6FaYJeb8ORsiu savWUb3rwWCJLrPdNCswVNIWAdeZsUototDn+qEeHkSDrTIsADDCneCkioDPJaLtcNKd vjhqH/hXyUFIlLKI63GxAwImcGrTlxS6gCFG1oCkl9NLWfUPN0emAy8ssbrRc4eBthwp gya5p1wJ//tAVuIxIvh9eIbn6o8QONvHlfUqdpS/BaO49H6F07d3bR0kCcMuEAefaHYj uRiKbIQJFbTgUzWCTtACt9jHs5iEhMLvhFc+851e4ME80YWxbP7VdCBZEOvubXWZqmWC Ge/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6FAaZSRvRaIigtQwI5Azy63L1NFWcHXYgkHsSPSyjyA=; b=lT2DlwBtatZZmwd3hjxYWMvDrCy7VLBin3f8ENtTuLBXqpe58GtYxM5pgcaYO6UB0F wiXDy5nJFAge9Th/3QNhBgMZ3Z7lZvMCYeUrnvs1NTBJmJ8/ki92vYwN2Yb83ShNqf/s pQCuosbe5Id4/Tzd2jmM3UsNHVPoKnVg6beazC7CIzTuQcOgBaBV8HsEZhXEoeK4gOTK nWBZjeAmzn4jKhwqSQ1RS3LusZwLgJQTOMRc2vGP96cDwaaonSCv4r5eT3AJQ6mO/zb8 qC4t+HxgJ2iFULwmWq5VJHhWKFCw7LmjDtuQLknScl0YXYsNUKvbvTpb9Oc9RhBOVQw7 ycMg== X-Gm-Message-State: AOAM530/wqOMMyiL7dOjjPF/V4og+G2K9WXGg/YgQJCMIevgrgghPzIT kvOw2eBhCwW+ifUzEtEiMTAn0WjwShmqCdy/tEW5sg== X-Google-Smtp-Source: ABdhPJzkXrqRH0saGZsbUwJpA/ni9aXkelKrw31a4nZ+ZpeiN0mRKbEmTrygYP+sv/+T0tx/CYp2SHpU40pL/Yri894= X-Received: by 2002:a50:fe0f:: with SMTP id f15mr25877050edt.235.1599560599142; Tue, 08 Sep 2020 03:23:19 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Tue, 8 Sep 2020 11:23:08 +0100 Message-ID: Subject: Re: Patch for SonarQube code scan fixes. To: Aditya Toshniwal Cc: Nikhil Mohite , pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000004f151a05aecab939" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000004f151a05aecab939 Content-Type: text/plain; charset="UTF-8" On Tue, Sep 8, 2020 at 11:01 AM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi, > > sqlautocomplete code is mostly inherited from the pgcli project. Changing > it might create trouble in updating the code with new versions. > Send a patch upstream :-) > > On Tue, Sep 8, 2020 at 2:59 PM Nikhil Mohite < > nikhil.mohite@enterprisedb.com> wrote: > >> Hi Team, >> >> I have fixed some code smell issues in the SonarQube scan, PFA patch. >> Details as follows: >> >> 1. psycopg2/connection: >> >> - Refactor this function to reduce its Cognitive Complexity from 32 >> to the 15 allowed. >> - Refactor this function to reduce its Cognitive Complexity from 17 >> to the 15 allowed. >> >> 2. psycopg2/server_manager: >> >> - Refactor this function to reduce its Cognitive Complexity from 20 >> to the 15 allowed. >> - Refactor this function to reduce its Cognitive Complexity from 33 >> to the 15 allowed. >> - Refactor this function to reduce its Cognitive Complexity from 26 >> to the 15 allowed. >> >> 3. sqlautocomplete/parseutils: >> >> - Refactor this function to reduce its Cognitive Complexity from 23 >> to the 15 allowed. >> >> >> >> -- >> *Thanks & Regards,* >> *Nikhil Mohite* >> *Software Engineer.* >> *EDB Postgres* >> *Mob.No: +91-7798364578.* >> > > > -- > Thanks, > Aditya Toshniwal > pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* > > "Don't Complain about Heat, Plant a TREE" > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EDB: http://www.enterprisedb.com --0000000000004f151a05aecab939 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Tue, Sep 8, 2020 at 11:01 AM Aditya To= shniwal <aditya.tos= hniwal@enterprisedb.com> wrote:
Hi,

sqlautocomplete=C2=A0code is= mostly inherited from the pgcli project. Changing it might create trouble = in updating the code with new versions.

Send a patch upstream :-)
=C2=A0

On Tue, Sep 8, 2020 at 2:59 PM Nikhil Mohite = <nik= hil.mohite@enterprisedb.com> wrote:
Hi Team,

I have fixed some code smell issues in the SonarQube scan, PFA patch.
Details as=C2=A0follows:

1.=C2=A0psycopg2/= connection:
  • Refactor this function to reduce its Cognitive Comp= lexity from 32 to the 15 allowed.
  • Refactor this function to reduce = its Cognitive Complexity from 17 to the 15 allowed.
2. psycopg2/se= rver_manager:
  • Refactor this function to reduce its Cognitive C= omplexity from 20 to the 15 allowed.
  • Refactor this function to redu= ce its Cognitive Complexity from 33 to the 15 allowed.
  • Refactor thi= s function to reduce its Cognitive Complexity from 26 to the 15 allowed.
3. sqlautocomplete/parseutils:
  • Refactor this function to= reduce its Cognitive Complexity from 23 to the 15 allowed.
<= br>

--
Thanks & Regards,
Nikhil Mohite
Software Engineer.
Mob.No: +91-7798364578.


--
Thanks,
Aditya Toshniwal=
pgAdmin hacker=C2=A0| Sr. Software Engineer | edbpostgres.com
&quo= t;Don't Complain about Heat, Plant a TREE"


--
--0000000000004f151a05aecab939--