MIME-Version: 1.0
In-Reply-To: 
 <CAOAJCYr7U44=MAJ4a=UnaQCqk5WibE88KpUu7TmgSbGQg=kbMw@mail.gmail.com>
References: 
 <CAOAJCYr7U44=MAJ4a=UnaQCqk5WibE88KpUu7TmgSbGQg=kbMw@mail.gmail.com>
From: Dave Page <dave.page@enterprisedb.com>
Date: Fri, 16 Sep 2016 16:53:37 +0100
Message-ID: 
 <CA+OCxozoON-GQfcMoGB1v1NJQ6K1ta1y7yAtTacbvNox+vLs7Q@mail.gmail.com>
Subject: Re: pgAdmin IV- Testing framework: Enhanced Test Result Summary
To: Navnath Gadakh <navnath.gadakh@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>,
	Kanchan Mohitey <kanchan.mohitey@enterprisedb.com>
Content-Type: text/plain; charset=UTF-8
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

Hi

On Fri, Sep 16, 2016 at 2:37 PM, Navnath Gadakh
<navnath.gadakh@enterprisedb.com> wrote:
> Hi Dave,
>      Please find the patch for the enhanced test result summary for testing
> framework. The code for this, was completed before drop object's
> functionality & independent from drop objects work.
> Drop objects work will take time, I am working on that for remaining nodes.
> Meanwhile, we go ahead with enhanced test summary.
>
> To run the test suite follow the commands
> 1. python regression/runtests.py --pkg browser.server_groups.servers
> 2. python regression/runtests.py --pkg
> browser.server_groups.servers.databases

I'm seeing some issues with this patch:

- There are updates to config.py and setup.py that shouldn't be there.
- I get this error at the end of a successful test run:

Test Result Summary
============================
Regression - PG 9.4: 25 tests passed, 0 tests failed
============================

Please check output in file:
/Users/dpage/git/pgadmin4/web/regression/regression.log
Error in atexit._run_exitfuncs:
Traceback (most recent call last):
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/atexit.py",
line 24, in _run_exitfuncs
    func(*targs, **kargs)
  File "/Users/dpage/git/pgadmin4/web/regression/test_utils.py", line
360, in drop_objects
    file_name, sys.exc_traceback.tb_lineno, exception))
Exception: test_utils.py: line:337 'NoneType' object has no attribute
'__getitem__'
Error in sys.exitfunc:
Traceback (most recent call last):
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/atexit.py",
line 24, in _run_exitfuncs
    func(*targs, **kargs)
  File "/Users/dpage/git/pgadmin4/web/regression/test_utils.py", line
360, in drop_objects
    file_name, sys.exc_traceback.tb_lineno, exception))
Exception: test_utils.py: line:337 'NoneType' object has no attribute
'__getitem__'

-- 
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers