Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBHll-0004D3-AZ for pgadmin-hackers@arkaria.postgresql.org; Thu, 18 May 2017 09:30:53 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1dBHlk-0000ur-KN for pgadmin-hackers@arkaria.postgresql.org; Thu, 18 May 2017 09:30:52 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dBHlj-0000uf-D3 for pgadmin-hackers@postgresql.org; Thu, 18 May 2017 09:30:52 +0000 Received: from mail-it0-x230.google.com ([2607:f8b0:4001:c0b::230]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1dBHlf-0000U0-Se for pgadmin-hackers@postgresql.org; Thu, 18 May 2017 09:30:49 +0000 Received: by mail-it0-x230.google.com with SMTP id g126so24529410ith.0 for ; Thu, 18 May 2017 02:30:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=hDqHx8BGKAI9RenK7O3lUitKlfJD7gklnZn7msnQE3I=; b=LWzdgHnyXNHVCvhz9B4P7nLDFAcTHRHiU9EoMIFPjW/tO5otpMp3JViGwuJDt3rsRq BE8x+cPoQqUBOfKEvwRHLbTC9N+8/SkwAeOzcaNRbpcKjcJKjFWOz309KmSbwXgdS3V8 zCMS2rmXDfDR1VohaeVjVOMmr2I2DTLKHyQHpV9qcwQMvz7jaBC9PgJJmMr1pYuowV2D hGNRFWFZpU3ZF+lrwfWwsEbG30v3XEXorp2jqCEiWBSo1+vu81ldCU/3uv8Ya+/bacgO DRwsXb5ya1rF+0lSES6aT0o6HaOwMLqmJQmlgaDI94N6zkfQ9jMpzvlotj2hXBYQeB8x f/dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=hDqHx8BGKAI9RenK7O3lUitKlfJD7gklnZn7msnQE3I=; b=dkx44Ci990ohFMn1Ki9zr2J65MsLj6/E5VBThViFfh2QlB2/ShG1bVtTSl5fHBrvUt T2VVzs7YAnRFI+/McXfuDpb3FPCpXWCTP7OC4yUBQUGHEL9K6fvwGgJIVu7UIgfY54k4 5kvBo7ejqxg0zh6pIQmF6anlfqCw8bNHLjGRBiX1wmEY7XwIovp1S++iiu3lTLyZlD7l NDQ1uZdQUn30rcG4bHRr6Shkfasfmj+Z3hXN7HMQIux3SmlKWKg448fV2t9q8VOhq5iD wdUiZttRvOWTnY1Ri5x7CYxQT6DThSsVmjjoXMzf/gAlCz9w8j1YB1Hfhvw8B9ZtALtA OSnw== X-Gm-Message-State: AODbwcDVK03na02CMBUR/aO91uDtqrRHFa7lgkoYbq1VFEZAj6XoV9lC RTQMPe1MqU+iKCZ59MQVUsZYvwv16mGJ X-Received: by 10.36.245.132 with SMTP id k126mr19768715ith.43.1495099847173; Thu, 18 May 2017 02:30:47 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.174.147 with HTTP; Thu, 18 May 2017 02:30:46 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Thu, 18 May 2017 10:30:46 +0100 Message-ID: Subject: Re: [patch] update table name in confirmation dialog for 'Reset Statistics' and 'Truncate Table' To: Akshay Joshi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="94eb2c11c8b04b7cc7054fc90f58" X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --94eb2c11c8b04b7cc7054fc90f58 Content-Type: text/plain; charset="UTF-8" Hi Please see the discussion here: https://redmine.postgresql.org/issues/2308 Would moving to the client-side translation mechanism help here? We need to do that anyway - and it's been added since the previous discussion. On Thu, May 18, 2017 at 10:17 AM, Akshay Joshi < akshay.joshi@enterprisedb.com> wrote: > Hi All > > I have found one issue where table name is not displaying in the confirmation > dialog when user click on "Reset Statistics" and "Truncate/Truncate > cascade". Confirmation dialog shows below message: > > - Are you sure you want to truncate table {}? > - Are you sure you want to reset the statistics for table {}? > > Also header is missing for "Truncate/Truncate cascade" confirmation > dialog. Attached is the patch file to fix that above. Please review it. > > -- > *Akshay Joshi* > *Principal Software Engineer * > > > > *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246 > <+91%2097678%2088246>* > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --94eb2c11c8b04b7cc7054fc90f58 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

Please see the discussion here:=C2= =A0https://redmine.p= ostgresql.org/issues/2308

Would moving to the = client-side translation mechanism help here? We need to do that anyway - an= d it's been added since the previous discussion.

On Thu, May 18, 2017 at 10:= 17 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi All=C2=A0

I have found one issue where table name is not displaying in= the=C2=A0con= firmation dialog=C2=A0wh= en user click on "Reset Statistics" and "Truncate/Truncate c= ascade". Confirmation dialog=C2= =A0shows below message:
  • Are you sure you want to= truncate table {}?
  • Are you sure you want to reset = the statistics f= or table {}?
    • =
Al= so header is missing for "Truncate/Truncate cascade"=C2=A0confirmation dialog. Att= ached is the patch file to fix that above. Please review it.
<= div>
--
<= div dir=3D"ltr">
= Akshay Joshi
Principal Software Engineer=C2=A0




--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-ha= ckers




--
--94eb2c11c8b04b7cc7054fc90f58--