public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Murtuza Zabuawala <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: PATCH: To fix issue in synonym node (pgAdmin4)
Date: Fri, 7 Oct 2016 12:08:28 +0100
Message-ID: <CA+OCxozpkwj5N4iTwi01J87je+eFoEyOvE6KpN761LyK-nDpWw@mail.gmail.com> (raw)
In-Reply-To: <CAKKotZSJBF_UCEFar8DFpYhk=giwi3ppGPYH3M+5GADYBFoS_w@mail.gmail.com>
References: <CAKKotZT8huV=9w7vy_8MWyUa1J6GCJ3-830HbB3LJeQVGJT3-A@mail.gmail.com>
<CA+OCxoxyyyQkTPvGsg69U-MMrgZyaY+_e07ngF2DXe=9QFREEQ@mail.gmail.com>
<CAKKotZSayUMYQgQh-An0FnL7hA_U7ybhfDsJYr=nEMMKw03v5A@mail.gmail.com>
<CA+OCxoxErKeHdvboDjr4vqZkjiqRZQvwMoZzxw5Be6k+FphApA@mail.gmail.com>
<CAKKotZSJBF_UCEFar8DFpYhk=giwi3ppGPYH3M+5GADYBFoS_w@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
Thanks, patch applied.
On Thu, Oct 6, 2016 at 10:42 AM, Murtuza Zabuawala
<[email protected]> wrote:
> Hi Dave,
>
> The issue you mentioned is different issue and not related to synonyms node.
> I will create separate ticket & work on it mean while you can commit changes
> for RM#1611
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Wed, Oct 5, 2016 at 6:53 PM, Dave Page <[email protected]> wrote:
>>
>> Hi
>>
>> I created a synonym from within the "dave" schema, but selected
>> "public" (which wasn't expanded), and it placed the synonym as a
>> direct child of "public". See the attached screenshot.
>>
>> On Wed, Oct 5, 2016 at 1:28 PM, Murtuza Zabuawala
>> <[email protected]> wrote:
>> > Hi Dave,
>> >
>> > PFA updated patch, Added schema filter in sql.
>> > Please review.
>> >
>> > --
>> > Regards,
>> > Murtuza Zabuawala
>> > EnterpriseDB: http://www.enterprisedb.com
>> > The Enterprise PostgreSQL Company
>> >
>> > On Wed, Oct 5, 2016 at 5:38 PM, Dave Page <[email protected]> wrote:
>> >>
>> >> Hi
>> >>
>> >> On Wed, Oct 5, 2016 at 9:53 AM, Murtuza Zabuawala
>> >> <[email protected]> wrote:
>> >> > Hi,
>> >> >
>> >> > PFA patch to fix the issue in synonym node, where it was not horning
>> >> > parent
>> >> > node while creating in different node, issue was that we were not
>> >> > sending
>> >> > node properly.
>> >> > RM#1611
>> >>
>> >> That doesn't seem like a reliable way to get the correct parent ID -
>> >> what if there are multiple synonyms in different schemas but with the
>> >> same name?
>> >>
>> >> --
>> >> Dave Page
>> >> Blog: http://pgsnake.blogspot.com
>> >> Twitter: @pgsnake
>> >>
>> >> EnterpriseDB UK: http://www.enterprisedb.com
>> >> The Enterprise PostgreSQL Company
>> >
>> >
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
view thread (6+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: PATCH: To fix issue in synonym node (pgAdmin4)
In-Reply-To: <CA+OCxozpkwj5N4iTwi01J87je+eFoEyOvE6KpN761LyK-nDpWw@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox