Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d2z7B-0004mV-7K for pgadmin-hackers@arkaria.postgresql.org; Tue, 25 Apr 2017 11:58:41 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1d2z7A-000369-Q9 for pgadmin-hackers@arkaria.postgresql.org; Tue, 25 Apr 2017 11:58:40 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d2z6w-0002hX-KL for pgadmin-hackers@postgresql.org; Tue, 25 Apr 2017 11:58:26 +0000 Received: from mail-io0-x22d.google.com ([2607:f8b0:4001:c06::22d]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1d2z6t-00074O-Td for pgadmin-hackers@postgresql.org; Tue, 25 Apr 2017 11:58:25 +0000 Received: by mail-io0-x22d.google.com with SMTP id r16so207269733ioi.2 for ; Tue, 25 Apr 2017 04:58:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=yxKeG5m/2icw6d8QDaYLcbvKJp/IG79ZHjXOJq/CJAE=; b=ed6+Gphe8ftcALywrTLjhcyjooE3dVzRiKj5bfUhRbKJ2nx0d0QbEmetFaDug+H9+H 75ThHywmgzTqphdECjnM26C+xz69dDQn0WT9dUcjTYs/h0fF5K5RdILrhvwvpINn9EUD PfUyz0/GhfY4QJe2I/48g140BSQF/UYa6/IIx++qN9WDS4dyPPF0Ibwmvr7SB7lLI6m8 1oWH4G9fdBfyHjIskCutW5mG0BQ+Q322Yw5Iyg3YXDqoea1yO7/l8ACb08AV7N7xYHpL MTPak+waWX7pAvSo36MjiJjU6dmYH2RcES3s6hCRKzruZJCZywdecg8XQPqY5uhk59VK 1aNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=yxKeG5m/2icw6d8QDaYLcbvKJp/IG79ZHjXOJq/CJAE=; b=iH4H5i9YIj1ZJftHUMPt9XTjuOE37D9DGI9ybZ1SH8yn+aZdMuHaVpS2Wpy5nArbe6 akCm/AyM90oowbA1neNtl700MXuJpz1SKnX4BhemaFDWpJ7TDfBxwSCrtn+1KlazMw9K vZZL+6QhK7vEnC43+Eyc599aEPVmmu8/Kb+RnhGkP98kRa03RuTN9iWL3FL5ZAvZqvdf ZRA5sUOJ6PqjLkSpn7gSKiRMIse69s17X6JQafAXzTqLG9PENAkAiS+nmoe6h//DPzgh V55269tG9mfeOm/qRTASInpsE9izp+htQZRG5VyAp2kCHlluiupsh6E57WFyqJdQn24L Uv2w== X-Gm-Message-State: AN3rC/42xXp2PIaSovCs7FcMKvSkDHGWkD4WHV9iIk4msoPAbQXbpPxs r/0TgzTooEoH5FYm3vAUeZpg8ifSeg== X-Received: by 10.107.162.4 with SMTP id l4mr13296271ioe.169.1493121503158; Tue, 25 Apr 2017 04:58:23 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.174.167 with HTTP; Tue, 25 Apr 2017 04:58:22 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Tue, 25 Apr 2017 12:58:22 +0100 Message-ID: Subject: Re: [pgAdmin4][Patch]: Fixed RM #2315 : Sorting by size is broken To: Khushboo Vashi Cc: pgadmin-hackers , Ashesh Vashi Content-Type: multipart/alternative; boundary=001a11410004cdd4c2054dfc70ea X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a11410004cdd4c2054dfc70ea Content-Type: text/plain; charset=UTF-8 Ashesh, can you review/commit this please? Thanks. On Tue, Apr 25, 2017 at 10:18 AM, Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > Hi, > > Fixed RM #2315 : Sorting by size is broken. > > Removed the pg_size_pretty function from query for the collection and > introduced the client side function to convert size into human readable > format. So, the sorting issue is fixed as the algorithm will get the actual > value of size instead of formatted value. > > > Thanks, > Khushboo > > > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a11410004cdd4c2054dfc70ea Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Ashesh, can you review/commit this please?

<= div>Thanks.

On Tue, Apr 25, 2017 at 10:18 AM, Khushboo Vashi &l= t;khus= hboo.vashi@enterprisedb.com> wrote:
Hi,

Fixed RM #2315 : Sorting b= y size is broken.

Removed the pg_size_pretty funct= ion from query for the collection and introduced the client side function t= o convert size into human readable format. So, the sorting issue is fixed a= s the algorithm will get the actual value of size instead of formatted valu= e.=C2=A0
=C2=A0

Thanks,
Kh= ushboo




--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-ha= ckers




--
--001a11410004cdd4c2054dfc70ea--