MIME-Version: 1.0
In-Reply-To: 
 <CAE+jjamhfMrW5p3rsDddDCdJD_i+RU+O=i2sTNeLf=TV_J==WQ@mail.gmail.com>
References: 
 <CAAdJd1OqoYe1=FZkZrO-WYEYH_asph3GP8u7a6XdjmQ7FwAaiA@mail.gmail.com>
 <CAE+jjamnK3vVZYqs_6+4yVxUPgpMbgM9NM06m1L4ytaMbkXpVQ@mail.gmail.com>
 <CANxoLDdrGtD76fwSe-b3swcbFcrcm8Me-s5Du+F_xyCYfCg_9A@mail.gmail.com>
 <CAE+jjamhfMrW5p3rsDddDCdJD_i+RU+O=i2sTNeLf=TV_J==WQ@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Thu, 29 Mar 2018 14:03:24 +0100
Message-ID: 
 <CA+OCxozsQr88HoxoCRXsxqi-7nQ6EGx3MJimqXR897GiL5WcfQ@mail.gmail.com>
Subject: Re: Bug #3083 fix
To: Joao De Almeida Pereira <jdealmeidapereira@pivotal.io>
Cc: Akshay Joshi <akshay.joshi@enterprisedb.com>,
	Neethu Mariya Joy <neethumariyajoy@gmail.com>,
	pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="001a114248a0b4e59f05688cbf0e"
Precedence: bulk

--001a114248a0b4e59f05688cbf0e
Content-Type: text/plain; charset="UTF-8"

Hi

On Wed, Mar 28, 2018 at 7:06 PM, Joao De Almeida Pereira <
jdealmeidapereira@pivotal.io> wrote:

> Hey Akshay and Neethu
>
> We refactored the patch to add tests for the resize feature.  We were able
> to write test cases for the drag event by using spies and setting the rect
> dimensions.  In cases like this, we can just test some components in order
> to have enough confidence in the code.  So we isolated the function that
> implements the behavior of this feature and tested that it was performing
> as expected.
>
> We ran the patch through the pipelines and all of the tests passed.
>

I'm consistently seeing the feature test failure below with this patch
applied:

======================================================================
FAIL: runTest
(pgadmin.feature_tests.view_data_dml_queries.CheckForViewDataTest)
Validate Insert, Update operations in View/Edit data with given test data
----------------------------------------------------------------------
Traceback (most recent call last):
  File
"/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py",
line 125, in runTest
    self._verify_row_data(True)
  File
"/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py",
line 325, in _verify_row_data
    self.assertEquals(cells[idx], config_data[str(idx)][1])
AssertionError: u'[null]' != u'1'
- [null]
+ 1


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--001a114248a0b4e59f05688cbf0e
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi<br><div class=3D"gmail_extra"><br><div class=3D"gmail_q=
uote">On Wed, Mar 28, 2018 at 7:06 PM, Joao De Almeida Pereira <span dir=3D=
"ltr">&lt;<a href=3D"mailto:jdealmeidapereira@pivotal.io" target=3D"_blank"=
>jdealmeidapereira@pivotal.io</a>&gt;</span> wrote:<br><blockquote class=3D=
"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(2=
04,204,204);padding-left:1ex"><div dir=3D"ltr">Hey Akshay and Neethu<div><b=
r></div><div>We refactored the patch to add tests for the resize feature.=
=C2=A0 We were able to write test cases for the drag event by using spies a=
nd setting the rect dimensions.=C2=A0 In cases like this, we can just test =
some components in order to have enough confidence in the code.=C2=A0 So we=
 isolated the function that implements the behavior of this feature and tes=
ted that it was performing as expected.</div><div><br></div><div>We ran the=
 patch through the pipelines and all of the tests passed.</div></div></bloc=
kquote><div><br></div><div>I&#39;m consistently seeing the feature test fai=
lure below with this patch applied:</div><div><br></div><div><div>=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D</div><div>FAIL: runTest=
 (pgadmin.feature_tests.view_data_dml_queries.CheckForViewDataTest)</div><d=
iv>Validate Insert, Update operations in View/Edit data with given test dat=
a</div><div>---------------------------------------------------------------=
-------</div><div>Traceback (most recent call last):</div><div>=C2=A0 File =
&quot;/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_que=
ries.py&quot;, line 125, in runTest</div><div>=C2=A0 =C2=A0 self._verify_ro=
w_data(True)</div><div>=C2=A0 File &quot;/Users/dpage/git/pgadmin4/web/pgad=
min/feature_tests/view_data_dml_queries.py&quot;, line 325, in _verify_row_=
data</div><div>=C2=A0 =C2=A0 self.assertEquals(cells[idx], config_data[str(=
idx)][1])</div><div>AssertionError: u&#39;[null]&#39; !=3D u&#39;1&#39;</di=
v><div>- [null]</div><div>+ 1</div></div></div><br clear=3D"all"><div><br><=
/div>-- <br><div class=3D"gmail_signature">Dave Page<br>Blog: <a href=3D"ht=
tp://pgsnake.blogspot.com" target=3D"_blank">http://pgsnake.blogspot.com</a=
><br>Twitter: @pgsnake<br><br>EnterpriseDB UK: <a href=3D"http://www.enterp=
risedb.com" target=3D"_blank">http://www.enterprisedb.com</a><br>The Enterp=
rise PostgreSQL Company<br></div>
</div></div>

--001a114248a0b4e59f05688cbf0e--