Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tGLO7-002OHN-8f for pgadmin-hackers@arkaria.postgresql.org; Wed, 27 Nov 2024 16:59:39 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tGLO5-00GuEU-ST for pgadmin-hackers@arkaria.postgresql.org; Wed, 27 Nov 2024 16:59:37 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tGLO5-00GuEL-Jn for pgadmin-hackers@lists.postgresql.org; Wed, 27 Nov 2024 16:59:37 +0000 Received: from mail-lj1-x22f.google.com ([2a00:1450:4864:20::22f]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1tGLO2-004MFo-P7 for pgadmin-hackers@postgresql.org; Wed, 27 Nov 2024 16:59:37 +0000 Received: by mail-lj1-x22f.google.com with SMTP id 38308e7fff4ca-2ffd6af012eso13847381fa.2 for ; Wed, 27 Nov 2024 08:59:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; t=1732726773; x=1733331573; darn=postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=nYbWh9h/v9jIQL9lU0zdVJ++Adoy0b7bBU+j0j23l6g=; b=aTOaysJJbL19EueOpPDF1mU6e0HuF5ub+pzrl9F7GmwzJ3HSfwJOOydRl/DTPqNVDe qselmrz7vB7RGptHhCtBRdqj3XMuA9AwvluZJXI+y679h2Fcg2vURF2a1Isio8il8Dic tecJLIJLLoUahrjWw3sMhHHKZoAgPUoFcOVbdN8f5j2CWN9Lh/9zAH7zZ9Wchy9oD019 xpSvHohleHh1ohJIjlXuJw8ZRSmDSYq4pr9KDMHhECACRBQGY+vjqySVtYTHCxe0D/4W OusVeCwbdpbaUErHlD176sZv+OMHW1kNWac2DIkf75CC0iEQLBQUuknLCw1kJwd+OSmt XkiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732726773; x=1733331573; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nYbWh9h/v9jIQL9lU0zdVJ++Adoy0b7bBU+j0j23l6g=; b=FN/0oMhivTznv/AR4LSkt2KQE9wXf/3UEF6m79paTqoW0wcrCoce/20ZaCqvnRKSVj RKzqPeDDlLrIxFo/Ng0OQ1QDjp8j/BIFw6odVIuvwsiXIF0aH1tvGJa64l5ntRr9izss TKCwZ46DhC/V+FsBHnr1czlX18LDKvgXNtiwufIJMMiMQ0V2R+vyTPc40V4vqLcbVqXt cepaKupcfBmB1LQkVr/A3AO2RbQNmGn/j74pToCbgu5mpfJvSEBoFxSsa+5BOwTCNlCI VGUI1PhJcIWOS2Qccq/be7j3HD8hxOsFtrq6iplgDbvDDTjXmH0s85lhwqHxvGPhHVSx jLAQ== X-Gm-Message-State: AOJu0Yx/LJD6TjLZE1BdmjEXheXJhQCLgyOBlVrMFb33J1jNhiGAHcDd aTffmpx9zEAWS8z2hjbB5udJjhhu0RtyDiscDNpBfWNLwEP5jqKARHFLeBVabhvY7ppEkPtWL6d d/E+NyAdSenUEI0O2AVYWPR1xnbcmGnbOFlEZ X-Gm-Gg: ASbGncuH9uphwvc2e5+de9QZDv0VflrmW7qtbjGK+BAEGn/1i7S1iJ/xmUmHG0626xr FGyRAZ3u0d8qu1EkP4ZAL8tZ+SVr3N7o3 X-Google-Smtp-Source: AGHT+IGuevHyIdxs7OImA1R/gHMmUfuyeqP6tImoFxeQyS0iBc1dwXOUsk1z1wgMT8cLn0pcYd87ut02DolSG/fcsX0= X-Received: by 2002:a2e:be0d:0:b0:2ff:ce85:8c98 with SMTP id 38308e7fff4ca-2ffd61429e7mr28891321fa.33.1732726772504; Wed, 27 Nov 2024 08:59:32 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Wed, 27 Nov 2024 16:59:21 +0000 Message-ID: Subject: Re: Require suggestion for issue #6513 To: Rohit Bhati Cc: pgadmin-hackers@postgresql.org Content-Type: multipart/alternative; boundary="000000000000c4b5420627e7e308" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000c4b5420627e7e308 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Rohit! On Wed, 27 Nov 2024 at 07:12, Rohit Bhati wrote: > Hi Dave, > > I hope you're doing well. I would greatly appreciate it if you could > provide your suggestions also on this issue. > I'm fine with the button label changes. We should make sure the text is structured consistently though: Are you sure you want to disconnect from the database "FooBar"? Are you sure you want to delete the database "FooBar"? For the delete option, I would also: - Make Cancel the default option. - Colour the button ("danger" in the palette) Thanks! > Thank you in advance. > > Best regards, > Rohit Bhati > > > On Thu, Nov 21, 2024 at 11:40=E2=80=AFPM Usman Khan wr= ote: > >> Yes, I think it would be nice to do it across all appropriate places. >> 'Disconnect' is available for Server and Database, while Delete is >> available across all database objects in the tree area. >> >> >> >> >> >> On Thu, Nov 21, 2024 at 12:48=E2=80=AFPM Rohit Bhati < >> rohit.bhati@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> I have been working on issue #6513 >>> and have >>> implemented some changes based on user suggestions. Here=E2=80=99s a su= mmary of the >>> modifications I made locally: >>> >>> 1. *Button Label Changes*: >>> - Updated the labels of the buttons to "Delete" or "Disconnect" >>> for affirmative actions. >>> - Changed the label "No" to "Cancel" for negative actions. >>> 2. *Icon Additions*: >>> - Added appropriate icons for the "Disconnect" and "Delete" >>> actions. >>> >>> I would like your input on whether these changes should be applied >>> universally across all delete and disconnect scenarios, or if they shou= ld >>> be limited to just the database delete and disconnect actions. >>> >>> Please find the attached screenshots showcasing the changes. >>> >>> >>> Thank you for your feedback! >>> >>> Best regards, >>> Rohit Bhati >>> >>> >>> >> --=20 Dave Page pgAdmin: https://www.pgadmin.org PostgreSQL: https://www.postgresql.org pgEdge: https://www.pgedge.com --000000000000c4b5420627e7e308 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Rohit!

On Wed, 27 Nov 2024 at 07:12, Rohit Bhati &l= t;rohit.bhati@enterprisedb.= com> wrote:

Hi = Dave,

Thank you in advance= .

Best regards,
Rohit Bhati



On Thu, Nov 21, 2024 at 11:40=E2=80=AFPM Usman Khan <= umk555@gmail.com&= gt; wrote:
Yes, I think it = would be nice to do it across all appropriate places.
'D= isconnect' is available for Server and Database, while Delete is availa= ble across all database objects in the tree area.

=



<= div class=3D"gmail_quote">
On Thu, Nov= 21, 2024 at 12:48=E2=80=AFPM Rohit Bhati <rohit.bhati@enterprisedb.com> w= rote:

Hi Hackers,

I have been wor= king on issue #6513 and have implemented some changes based on u= ser suggestions. Here=E2=80=99s a summary of the modifications I made local= ly:

  1. But= ton Label Changes:
    • Updated the labels of the buttons to= "Delete" or "Disconnect" for affirmative actions.
    • Changed the label "No" to = "Cancel" for negative actions.
  2. Ico= n Additions:
    • Added appropriate icons for the &quo= t;Disconnect" and "Delete" actions.

I = would like your input on whether these changes should be applied universall= y across all delete and disconnect scenarios, or if they should be limited = to just the database delete and disconnect actions.

Please find the att= ached screenshots showcasing the changes.


Thank you for your feedback!

<= p style=3D"color:rgb(0,0,0)">

Best regards,
Rohit Bhati

=C2=A0



--
--000000000000c4b5420627e7e308--