Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBKl5-0007L1-Gl for pgadmin-hackers@arkaria.postgresql.org; Thu, 18 May 2017 12:42:23 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1dBKl5-0002U2-3L for pgadmin-hackers@arkaria.postgresql.org; Thu, 18 May 2017 12:42:23 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dBKkq-00025C-HD for pgadmin-hackers@postgresql.org; Thu, 18 May 2017 12:42:08 +0000 Received: from mail-io0-x22a.google.com ([2607:f8b0:4001:c06::22a]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1dBKkm-00041u-3Q for pgadmin-hackers@postgresql.org; Thu, 18 May 2017 12:42:07 +0000 Received: by mail-io0-x22a.google.com with SMTP id f102so27324633ioi.2 for ; Thu, 18 May 2017 05:42:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=p76IFFz13nFmHtXFmtr72bqhsbosj44nssBFblFoz1I=; b=mVfZ2n+hYHJlxikjVMo0Q/EV5HD6UafgYqnBI68kfk1bdLSz7R828sQSNXBX/0xqb9 lYiWinRaou0nuPqfEyqi4/v4u8pBX+2P01jKqFzKdAHrpUP/q3Y/6OwVFjMiuRnpdL5u RzGRWYH0Ad0JyGq/DG8YgiDSiVe4V0a1u2sr18CsYAwPKLUaRpy2vdlqweCJYWgLW89S ZeSx2rmKa/R+cAWV2CzSfQxzAh47mE/gl+AxjRabshRu3es8T4Hnwodf1CS2HH35g/0x xp60lEQ7LBi187w2F+7RTxt3804x+ehbriV7E36LWHVVJ5M4/dmJxH0aEpdCKsZoeWB7 kFZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=p76IFFz13nFmHtXFmtr72bqhsbosj44nssBFblFoz1I=; b=b15SArMRQMPS80MrhP1P+haJPTUnEvxDcnDgYL7/VBdLH2s8ezZvyY5f+/1XB2oEtP 40D18NXOl0F60cZJAiotczCJlC+gHAzXhy4/U4x78GmcgwryE3cLa9gbzASnvBwyu0TT w5J6BeLtGBkpw206Z8us6G2jKe/lz434geayepstEVtEjgCxy/P4YcqWbI8JvnWCzaMZ z5rSH88L33yGKCR1yBaB5LrmdHa9ha8IX3lGzPNS4Fx100ddOE8/5OSlpEvjIT7ZR/Nh qSxrpH3FxC52X2cQYRvRanQtJ2jIousAW9aIz2vEzbgpRakTRN+irjCajJK2hEEa5gb2 SeLg== X-Gm-Message-State: AODbwcAFDuafCtCKwzM+KChQI2FlHwitTV3DSe75Hf3qOkPWDjW/aUKg JLM98GbTPJjy6o0IR6dtZ7vamn85cIxu X-Received: by 10.107.51.14 with SMTP id z14mr4187272ioz.84.1495111322377; Thu, 18 May 2017 05:42:02 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.174.147 with HTTP; Thu, 18 May 2017 05:42:01 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Thu, 18 May 2017 13:42:01 +0100 Message-ID: Subject: Re: [patch] update table name in confirmation dialog for 'Reset Statistics' and 'Truncate Table' To: Akshay Joshi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="001a113a8bc845251c054fcbbba2" X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a113a8bc845251c054fcbbba2 Content-Type: text/plain; charset="UTF-8" On Thu, May 18, 2017 at 11:03 AM, Akshay Joshi < akshay.joshi@enterprisedb.com> wrote: > > > On Thu, May 18, 2017 at 3:23 PM, Dave Page wrote: > >> >> >> On Thu, May 18, 2017 at 10:37 AM, Akshay Joshi < >> akshay.joshi@enterprisedb.com> wrote: >> >>> >>> >>> On Thu, May 18, 2017 at 3:00 PM, Dave Page wrote: >>> >>>> Hi >>>> >>>> Please see the discussion here: https://redmine.postgres >>>> ql.org/issues/2308 >>>> >>>> Would moving to the client-side translation mechanism help here? We >>>> need to do that anyway - and it's been added since the previous discussion. >>>> >>> >>> OK, at least we should checked-in code for showing title of the >>> confirmation dialog for "Truncate". >>> >> >> Right, but it doesn't work. See the first comment in the bug. >> > > I am talking about the header title of the confirmation dialog. If we > click on Truncate table without opening any alertify dialog header shows " > AlertifyJS" and if any other alertify dialog opens before then it shows > the header title of that dialog even if user clicks on Truncate. Please > refer attached screenshot. > Oh, sure - that can be fixed. The other part does need resolution as well though. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a113a8bc845251c054fcbbba2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Thu, May 18, 2017 at 11:03 AM, Akshay Joshi <akshay.jos= hi@enterprisedb.com> wrote:


On Thu, May 18, 2017 at 3:23 PM, Dave Page <dpage@pgadmin.org> wrote:


On Thu, May 18, 2017 at 10:37 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:


On Thu, May 18, 2017 at 3:00 PM, Dave= Page <dpage@pgadmin.org> wrote:
Hi

Please see the discussion her= e:=C2=A0https://redmine.postgresql.org/issues/2308

Would moving to the client-side translation mechanism help here? We= need to do that anyway - and it's been added since the previous discus= sion.

=C2=A0 =C2=A0OK, a= t least we should checked-in code for showing title of the confirmation dia= log for "Truncate".=C2=A0

Right, but it doesn't work. See the first c= omment in the bug.

=C2=A0 =C2=A0 I am talking about the header title of the confirmatio= n dialog. If we click on Tr= uncate table without opening any a= lertify dialog heade= r shows "AlertifyJS&qu= ot; and if any other alertify dialog opens before then= it shows the header title of that dialog even if user clicks on Truncate. Please refer attached scree= nshot. =C2=A0 =C2=A0

Oh, sure - that can be fixed. The other part does need resolution as well= though.=C2=A0

--
Dave Page
Blog: http://pgsnake.blogspot.comTwitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise= PostgreSQL Company
--001a113a8bc845251c054fcbbba2--