Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1arM7C-0004g4-TV for pgadmin-hackers@arkaria.postgresql.org; Sat, 16 Apr 2016 09:02:07 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1arM7C-0003yK-GK for pgadmin-hackers@arkaria.postgresql.org; Sat, 16 Apr 2016 09:02:06 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1arM6z-0003jt-6p for pgadmin-hackers@postgresql.org; Sat, 16 Apr 2016 09:01:53 +0000 Received: from mail-ig0-x231.google.com ([2607:f8b0:4001:c05::231]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1arM6r-0007Vg-6K for pgadmin-hackers@postgresql.org; Sat, 16 Apr 2016 09:01:52 +0000 Received: by mail-ig0-x231.google.com with SMTP id gy3so9640519igb.1 for ; Sat, 16 Apr 2016 02:01:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=v3U3JA16Ymfbn4ch1TOZ1bMBQnD7E0zAYDEepcHG6/k=; b=iSgJWzSufgDeltfE8H727seWN9WiTms4r2hrGxhs42V4ovxIzp1CwGU4Q2Q7/1YQ2Z el8eaDVx2wOo4I/oJvFJ/FPYeK4gsCwoeFGwXP/AxXoTExlVM0BHL1vw+CsfBID2pQCG YzLdeHiZCW91QVvSIKgH713dFpviQyipYi/X81UkFKicTJv/plTeKs72APUKalrWDYJb wcNfKxNoNefMVoAFUK4x36XNEat7BUT+7yIXF92QaSbtYdaUROcpjV+T+bRAHQM/Xkd+ ikx2zL4njaTnbMp610sUqH6eXxPOwMznI3q9n6Y+D+VQ/QYr/Sa7B6DdhAg9gwspvjLi cKbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=v3U3JA16Ymfbn4ch1TOZ1bMBQnD7E0zAYDEepcHG6/k=; b=gWNEzSRZqAOzUfPBujE7sj+Ag6bKlE+X3J+AbH0LrqO6Mczmd043BUXBXuJPm1S/xc dkA5NRgQiODaALPRSa47YwQVDeN0If+ea9Mmek4cN+XxHY05+3nLaIzHXtpYB19sgpmm FW4Ex4Ffcd1LVtQKrbJFXR6siBsCfWqacIz+rsicgmbO3ljEA5xDSTXIYAZS5iFqcEY0 Hqs2WCMe1IH/VmUGnkP1YXNc1ehi6TkfA28eSxoA9yo5UdLOLYHDEeoVyxtBzQqTZeLr 20p4SZB46UsOn3JaxlXflHw5h4R6XM99rt23cgIsf/7AVWUqo5Ktovad65bUU1BoGoD+ u0+A== X-Gm-Message-State: AOPr4FWjKRDvPapemhJzROvTq9VrY+yYueXBK/nXegPMtXr3wNRdICgZg1+DD1MfmS3v8QYH+663FUNEw0Ic8w== MIME-Version: 1.0 X-Received: by 10.50.186.136 with SMTP id fk8mr9603191igc.11.1460797303162; Sat, 16 Apr 2016 02:01:43 -0700 (PDT) Received: by 10.64.105.131 with HTTP; Sat, 16 Apr 2016 02:01:43 -0700 (PDT) In-Reply-To: References: Date: Sat, 16 Apr 2016 10:01:43 +0100 Message-ID: Subject: Re: [pgAdmin4] [Patch]: Grant Wizard From: Dave Page To: Surinder Kumar Cc: Ashesh Vashi , pgadmin-hackers Content-Type: multipart/alternative; boundary=14dae93410c15828ae0530966039 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --14dae93410c15828ae0530966039 Content-Type: text/plain; charset=UTF-8 Thanks, patch applied. On Friday, April 15, 2016, Surinder Kumar wrote: > Hi, > > PFA patch with following issues fixed: > > 1. Fixed 'get_schemas.sql' template for PPAS. It was fetching system > level schemas due to wrong sql query. > 2. Allowed the grant wizard to open on procedures node if server type > is PPAS. > > Also, I will send another patch for the remaining issues. > > On Wed, Apr 13, 2016 at 8:41 PM, Dave Page > wrote: > >> Hi >> >> On Fri, Apr 8, 2016 at 6:59 PM, Surinder Kumar < >> surinder.kumar@enterprisedb.com >> > wrote: >> >>> Hi >>> >>> PFA patch with resolved review comments. >>> >>> On Fri, Apr 8, 2016 at 12:52 AM, Dave Page >> > wrote: >>> >>>> Hi >>>> >>>> Nearly there :-). Assuming no regressions, I believe we'll be ready to >>>> commit once the following issues are resolved: >>>> >>>> - The select object grid should fill the available vertical space in >>>> the dialogue - at present there's a gap below it. >>>> >>> Done >>> >> >> This does not seem to be fixed (see attached screenshot). In fact, the >> gap gets bigger proportionally as the window is resized. >> >> >>> >>>> - When selecting privileges, each time I click on a checkbox, the row >>>> closes. Similar grids elsewhere in the app close the row when the cell >>>> loses focus, *however*, that is also the incorrect behaviour - the row >>>> should only close when the row itself loses focus (and should open when it >>>> gets focus). >>>> >>> I checked the row closes either when gets clicked on row or outside row, >>> it doesn't seems to close on click on checkbox. >>> >> >> This is still broken for me. I'm using Chrome on OS X. As soon as I click >> any checkbox, the row closes, and I have to click again to see the >> checkboxes again. >> >> One additional issue: >> >> - If I select some objects and permissions (in my case, everything in a >> PEM database, and ALL), hit Next so I can see the SQL, then hit back >> *twice*, I see the second attached screenshot. >> >> I'm going to commit the code with these issues as they are largely >> cosmetic. Please submit a patch to fix them (I'll add a new card to our >> internal Kanban chart). >> >> Thanks. >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --14dae93410c15828ae0530966039 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Thanks, patch applied.

On Friday, April 15, 2016, Surinder Kumar <= ;surinder.kumar@enterpri= sedb.com> wrote:
= Hi,

PFA patch with following issues fixed:
  • Fixed =C2=A0'get_schemas.sql' template for PPAS. It was fetchi= ng system level schemas due to wrong sql query.
  • Allowed the grant w= izard to open on procedures node if server type is PPAS.
    • Also= , I will send another patch for the remaining issues.

    On Wed, Apr 13, 2016 = at 8:41 PM, Dave Page <dpage@pgad= min.org> wrote:
    Hi

    On Fri, Apr 8, 2016 at 6:59 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:
    Hi
    <= br>
    PFA patch with resolved review comments.

    On Fri, Apr 8, 2016 = at 12:52 AM, Dave Page <dpage@pga= dmin.org> wrote:
    Hi

    Nearly there :-). Assuming no reg= ressions, I believe we'll be ready to commit once the following issues = are resolved:

    - The select object grid should= fill the available vertical space in the dialogue - at present there's= a gap below it.
    Done=C2=A0
    =

    This does not see= m to be fixed (see attached screenshot). In fact, the gap gets bigger propo= rtionally as the window is resized.
    =C2=A0

    - When selecting privileges, each time I click on a ch= eckbox, the row closes. Similar grids elsewhere in the app close the row wh= en the cell loses focus, *however*, that is also the incorrect behaviour - = the row should only close when the row itself loses focus (and should open = when it gets focus).
    I checked th= e row closes either when gets clicked on row or outside row, it doesn't= seems to close on click on checkbox.
    <= div>
    This is still broken for me. I'm using Chrome= on OS X. As soon as I click any checkbox, the row closes, and I have to cl= ick again to see the checkboxes again.

    One additio= nal issue:

    - If I select some objects and permissi= ons (in my case, everything in a PEM database, and ALL), hit Next so I can = see the SQL, then hit back *twice*, I see the second attached screenshot.

    I'm going to commit the code with these issues = as they are largely cosmetic. Please submit a patch to fix them (I'll a= dd a new card to our internal Kanban chart).

    Thank= s.

    --
    Dave Page
    Blog: http://pgsnake.blogspot.= com
    Twitter: @pgsnake

    EnterpriseDB UK: http://www.enterprisedb.com
    The = Enterprise PostgreSQL Company


    --
    Dave Page
    Blog: http://pgsnake.blogspot.com
    Twitter: @= pgsnake

    EnterpriseDB UK: http://www.enterprisedb.com
    The Enterprise PostgreSQL= Company

    --14dae93410c15828ae0530966039--