public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Murtuza Zabuawala <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: PATCH: To fix the performance of delete operation (pgAdmin4)
Date: Fri, 16 Sep 2016 16:48:05 +0100
Message-ID: <CA+OCxozvXweNAjYqFYW5yk+s3hJWTZUD_hp7ikftBMNMQaqcZg@mail.gmail.com> (raw)
In-Reply-To: <CAKKotZSW7SsQ6StbcZHyOh68jwVF381=r=dH7hJyeUuNtCVpwQ@mail.gmail.com>
References: <CAKKotZQvEXHC_z76muv0V+f--Uskph1Oj3WHB5PfPxS2MEgHUA@mail.gmail.com>
<CA+OCxozdc=Dz80uBEYeJ0B4cj9j8GeWbZSkaoy0QqexAWY1q4g@mail.gmail.com>
<CAKKotZSW7SsQ6StbcZHyOh68jwVF381=r=dH7hJyeUuNtCVpwQ@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
Thanks - committed with a couple of changes:
- I re-formatted the SQL
- s/lables/labels
Awesome speedup BTW - deleting 25K rows went from >10 minutes to
virtually instant. Good work.
On Fri, Sep 16, 2016 at 12:34 PM, Murtuza Zabuawala
<[email protected]> wrote:
> Hi Dave,
>
> Please find updated patch.
>
>
> Regards,
> Murtuza
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Fri, Sep 16, 2016 at 3:31 PM, Dave Page <[email protected]> wrote:
>>
>> Can you rebase this please?
>>
>> Thanks.
>>
>> On Thu, Sep 15, 2016 at 11:08 AM, Murtuza Zabuawala
>> <[email protected]> wrote:
>> > Hi,
>> >
>> > PFA patch to fix the issue of slow performance while deleting rows from
>> > grid.
>> > RM#1696
>> >
>> > Issue:
>> > As per logic implemented for Backgrid, we were deleting individual rows,
>> > means If user selects 100 rows to delete then we were rendering sql
>> > template
>> > 100 times to generate sql for each individual rows and then execute all
>> > 100
>> > delete statements one by one due to which we were getting poor
>> > performance.
>> >
>> > Please review.
>> >
>> > --
>> > Regards,
>> > Murtuza Zabuawala
>> > EnterpriseDB: http://www.enterprisedb.com
>> > The Enterprise PostgreSQL Company
>> >
>> >
>> > --
>> > Sent via pgadmin-hackers mailing list ([email protected])
>> > To make changes to your subscription:
>> > http://www.postgresql.org/mailpref/pgadmin-hackers
>> >
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
view thread (4+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: PATCH: To fix the performance of delete operation (pgAdmin4)
In-Reply-To: <CA+OCxozvXweNAjYqFYW5yk+s3hJWTZUD_hp7ikftBMNMQaqcZg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox