Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d6cBo-0003PI-Jg for pgadmin-hackers@arkaria.postgresql.org; Fri, 05 May 2017 12:18:28 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1d6cBn-0001V2-Oa for pgadmin-hackers@arkaria.postgresql.org; Fri, 05 May 2017 12:18:27 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d6cBY-00016Y-S5 for pgadmin-hackers@postgresql.org; Fri, 05 May 2017 12:18:13 +0000 Received: from mail-io0-x231.google.com ([2607:f8b0:4001:c06::231]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1d6cBQ-0000mA-IF for pgadmin-hackers@postgresql.org; Fri, 05 May 2017 12:18:11 +0000 Received: by mail-io0-x231.google.com with SMTP id p80so5759494iop.3 for ; Fri, 05 May 2017 05:18:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ppPPooKMV4Mw2A18mTm6DOhfDzBUoh47/grWsRD/Clc=; b=sUO6alpX5mICChvqKIPYdCBs1p/cmIV6IIPJn7McypB7PDckWoBJlSt1WQ9KRxrxWI geyfl6OzzU8IoAqI6UQVJ8fkM0coF6xw8q5mcHkZQftttuTdwbcG83vsRT+xKHLtKZdy NTQdwn7MXQYaEJ+Hw6PQrNN+SH6DCsYT46kz34tckYujvBZKp4GCttES1Ybrg2u703Zj vFseb6iPyHswo+VorH9FAsB67w+ZckR3I2H4cvhm+UI0GTvJUXLpSHxg6VT6DHwbcgBd 8vSJc1qi6jcohcUMa4AHyr0GDGfm02OuE8zoZfnMACbpN167Na2YZdakX+9yR7yrR9/a SQOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ppPPooKMV4Mw2A18mTm6DOhfDzBUoh47/grWsRD/Clc=; b=lwEJmEfWHIg8PCS735n7p6CiZJfQnQZ8yLDC+vOPyZ+H61b0PA35V1louN+0DMn3DD 8rDjpfu0Q2pCccyxQ8wDr7h5v43yqhx5DBlL2LTJRz0gxmQACoahatAZH8BjniZ+MfNT FvnfhZzilRhGfgLezuDtw39iBmwJx1nwpgbqv7F5g/tqAQNyB7ZXptGtmdc17Ae7YtW8 7W52LXUZCzHEmpRLaw34QnJm3RD5CS73MocYJCwY/EqiryWMG7DhrUVAuNqE26z3JDxa Xo0aCjQb3fnJtAtc+1sszoPEyohhMGKwQn+TQpvCby8gwS72/xAEBc4145WnSBrHkdN0 H6Hg== X-Gm-Message-State: AN3rC/4ETIIkcsDBj4Z7MPqC3/Hu0URGDIm3RA+r3d/8Yq/FBYq3yqfX oaPE/4BAK3jC/GqM6H3S8KR0RdJsuw== X-Received: by 10.107.173.14 with SMTP id w14mr46827783ioe.232.1493986683384; Fri, 05 May 2017 05:18:03 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.174.167 with HTTP; Fri, 5 May 2017 05:18:02 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Fri, 5 May 2017 13:18:02 +0100 Message-ID: Subject: Re: [patch] Dependents and Dependencies in GreenPlum To: Robert Eckhardt Cc: Sarah McAlear , Joao Pedro De Almeida Pereira , Ashesh Vashi , pgadmin-hackers , Matthew Kleiman Content-Type: multipart/alternative; boundary=001a114409e4900879054ec5e1c4 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a114409e4900879054ec5e1c4 Content-Type: text/plain; charset=UTF-8 Can you get this polished off on Monday please Ashesh? On Thu, May 4, 2017 at 12:51 PM, Robert Eckhardt wrote: > All, > > This change in the xss testing is preventing our CI from going green and > is also preventing the Dependents and Dependencies tabs in Greenplum from > being useful. > > Can we either merge this or provide feedback as to what needs to change so > that it can be merged. > > Thank you > Rob > > On Tue, May 2, 2017 at 5:17 PM, Sarah McAlear wrote: > >> Hi Hackers & Ashesh! >> >> Is there anything else we can do for this? >> >> Thanks! >> Matt & Sarah >> >> On Thu, Apr 27, 2017 at 10:37 AM, Joao Pedro De Almeida Pereira < >> jdealmeidapereira@pivotal.io> wrote: >> >>> Thanks for reviewing, Ashesh. >>> >>> We have updated the patch. The headers are all consistent and we removed >>> the __init__.py files in directories containing only .sql. >>> >>> Thanks! >>> Joao & Matt >>> >>> On Wed, Apr 26, 2017 at 11:22 AM, Joao Pedro De Almeida Pereira < >>> jdealmeidapereira@pivotal.io> wrote: >>> >>>> Hello Ashesh, >>>> >>>> Thanks for reviewing the patch. >>>> >>>> We added the __init__.py files into templates to convert them into >>>> packages so that the tests inside of them can be found by the test runner. >>>> >>>> Thanks! >>>> Joao & Sarah >>>> >>>> On Wed, Apr 26, 2017 at 1:26 AM, Ashesh Vashi < >>>> ashesh.vashi@enterprisedb.com> wrote: >>>> >>>>> On Mon, Apr 24, 2017 at 4:43 PM, Dave Page wrote: >>>>> >>>>>> Ashesh, can you review/commit this please? >>>>>> >>>>>> On Fri, Apr 21, 2017 at 8:42 PM, Joao Pedro De Almeida Pereira < >>>>>> jdealmeidapereira@pivotal.io> wrote: >>>>>> >>>>>>> Hi Hackers, >>>>>>> >>>>>>> We found out that when you are connected to a GreenPlum database and >>>>>>> try to get Dependents and Dependencies of an object the application was >>>>>>> returning a SQL error. >>>>>>> >>>>>>> This patch splits the SQL query used to retrieve the Dependents, >>>>>>> Dependencies, and Roles SQL file into multiple versioned files. >>>>>>> Add Unit Tests for each file. >>>>>>> Also added __init__.py files to other test directories to run the >>>>>>> tests in them. >>>>>>> >>>>>> Hi Joao & Sarah, >>>>> >>>>> Why do we need to add __init__.py in the template directory? >>>>> I didn't understand the purpose of the adding __init__.py files in the >>>>> template directories. >>>>> >>>>> NOTE: The headers in those files are not consistent with the other >>>>> project files. >>>>> >>>>> -- >>>>> >>>>> Thanks & Regards, >>>>> >>>>> Ashesh Vashi >>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>>>> >>>>> >>>>> >>>>> *http://www.linkedin.com/in/asheshvashi* >>>>> >>>>> >>>>>> Add ORDER BY into Copy Selection Feature test to ensure the results >>>>>>> are retrieved always in the same order >>>>>>> Renamed the Scenario of the xss_checks_pgadmin_debugger_test and >>>>>>> skip it for versions less than 9.1 >>>>>>> >>>>>>> Thanks >>>>>>> >>>>>>> Joao & Sarah >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.or >>>>>>> g) >>>>>>> To make changes to your subscription: >>>>>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Dave Page >>>>>> Blog: http://pgsnake.blogspot.com >>>>>> Twitter: @pgsnake >>>>>> >>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>> >>>>> >>>> >>> >>> >>> -- >>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>> To make changes to your subscription: >>> http://www.postgresql.org/mailpref/pgadmin-hackers >>> >>> >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a114409e4900879054ec5e1c4 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Can you get this polished off on Monday please Ashesh?

On Thu, May 4, = 2017 at 12:51 PM, Robert Eckhardt <reckhardt@pivotal.io> = wrote:
All,=C2=A0
This change in the xss testing is preventing our CI from going= green and is also preventing the=C2=A0Dependents and Dependencies tabs in = Greenplum from being useful.=C2=A0

Can we either m= erge this or provide feedback as to what needs to change so that it can be = merged.=C2=A0

Thank you
Rob
<= div class=3D"HOEnZb">

On Tue, May 2, 2017 at 5:17 PM, Sarah McAlear <smc= alear@pivotal.io> wrote:
Hi Hackers & Ashesh!

Is there anything else = we can do for this?

Thanks!
Matt & Sarah

O= n Thu, Apr 27, 2017 at 10:37 AM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Thanks for reviewing, Ashesh.

We have updated the patch. The headers are all consistent and we removed = the __init__.py files in directo= ries containing only .sql.
=

Thanks!
Joao & Matt

On Wed, Apr 26, 2017 at 11:22 AM, Joao Pedro De Almei= da Pereira <jdealmeidapereira@pivotal.io> wrote:<= br>
Hello Ashesh,

Thanks for reviewing the patch.

We added the __= init__.py files into templates to convert them into packages so that the te= sts inside of them can be found by the test runner.

Thanks!
Joao & Sarah

On Wed, Apr 26, 2017 at 1:2= 6 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com>= wrote:
On Mon, Apr 24, 2017 at = 4:43 PM, Dave Page <dpage@pgadmin.org> wrote:
Ashesh, can you rev= iew/commit this please?

On = Fri, Apr 21, 2017 at 8:42 PM, Joao Pedro De Almeida Pereira <jd= ealmeidapereira@pivotal.io> wrote:
Hi Hackers,

We = found out that when you are connected to a GreenPlum database and try to ge= t Dependents and Dependencies of an object the application was returning a = SQL error.

This patch splits the SQL query used to= retrieve the Dependents, Dependencies, and Roles SQL file into multiple ve= rsioned files.
Add Unit Tests for each file.
Also added= __init__.py files to other test directories to run the tests in them.
Hi Joao &am= p; Sarah,

Why do we need to add __init__.py in the templ= ate directory?
I didn't understand the purpose of the adding = __init__.py files in the template directories.

NOT= E: The headers in those files are not consistent with the other project fil= es.

=

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA:=C2=A0Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi

A= dd ORDER BY into Copy Selection Feature test to ensure the results are retr= ieved always in the same order
Renamed the Scenario of the=C2=A0x= ss_checks_pgadmin_debugger_test and skip it for versions less than 9.1=

Thanks

Joao & Sarah<= /div>


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-ha= ckers



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter:= @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreS= QL Company





--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-ha= ckers






--
=
Dave Page=
Blog: http://= pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprised= b.com
The Enterprise PostgreSQL Company
--001a114409e4900879054ec5e1c4--