Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tsgsG-004gXa-9f for pgadmin-hackers@arkaria.postgresql.org; Thu, 13 Mar 2025 11:37:16 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tsgsF-00BTy2-08 for pgadmin-hackers@arkaria.postgresql.org; Thu, 13 Mar 2025 11:37:15 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tsgsE-00BTxg-Mr for pgadmin-hackers@lists.postgresql.org; Thu, 13 Mar 2025 11:37:14 +0000 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1tsgsA-002dlc-34 for pgadmin-hackers@postgresql.org; Thu, 13 Mar 2025 11:37:14 +0000 Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-547bcef2f96so1000839e87.1 for ; Thu, 13 Mar 2025 04:37:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; t=1741865831; x=1742470631; darn=postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=YxVXwNiD9USPChJnvo+jR2ktHsRF9EYYWDMnLIvA/pM=; b=RC0GLlFDM85O9Yxpl5mbDIfc40XJyMQVCKXsqXj7PfavdfxhvYiGUFOCvGqq4ptbYz 29Gr1GNwNtoiPPHmnvNuF4icZP7gr48iEsq7l6ExhaCrAtRvxzZlKjPSkrP6pZDpNYjO q5ntM6lZLtTRDRGTAn2YvpRUWruoa+JYUjJl/X25XBciITV/9CEll6RWg8q/v67z4Nf4 UIUs6I7EVPaSzllThWtu/EuViTniocSMUs61JFJmBeR/mD3KZy+e7feCvnHOCFAxMwzq HHV6HQQ/5zSgVyDKPTxlMd9MXmqgBMPeJ9aMyqRtB2K+t/13XHU3azlXu25RD6FYA1cC POtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741865831; x=1742470631; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YxVXwNiD9USPChJnvo+jR2ktHsRF9EYYWDMnLIvA/pM=; b=H+lyZi7osO0ejD0FhOb44vf/8VMjmVPznupvvU2QHMSqi7Q+KpIROBTcEYi6jdFYZK nnjyYuEkXInj+dWy1gkJXtcETy+UPdrGHab4gJNzi5HzIsjmd4u4whfzbtELDIGFrpVf 3hKNc46LEs4TjZq/eepQanclduKjYfSO/lEa8eXsKqjNxpKENXUch0VtGSRFqF4WlWV6 k8ykmGtRVsn+xugcDSUxoQeG1eiF0r8cnmCosJ11Xrt/x9TbZxOcNpP7qdc3b9Cm5p+J k6IPEe3iqnrX3J3rDCniT+5wJiRzYRg8GfCfz43kC+L8rSQmiaMwYJsqZRDW4rWVpZ0X WMmQ== X-Gm-Message-State: AOJu0YwIv817XV15iG5aXOShcoJU03j3cc34ejOKKd4A3l+cDVpsDtJF 4wmoYSaW0YVnTmnZKEbA5W1yqDHcGB11eB3uzawiVTubZjPZ8HODsBriuA3vXQK0Me38kr/Wyw5 FsIp8Q+4SrkgNZPJNhcWXLDcWNNvPvoWTqST8 X-Gm-Gg: ASbGncui/LbkTy50tb/RZWTowUy6i3R+uujtPIOAESkfGYW1Lx4t5tB6g0LRzKLrqo3 tkGgH5ToEh0ishSfJFExEPDEKnLHIhzHJhA4j4PcsYIUSc8fgKzlDonIZYfpEP5DAlcKAjdTKrY 1LmpZ2CRfQdZoRlSTJgRFUWkq5KdUu X-Google-Smtp-Source: AGHT+IHImbWwdS8hsT/N4rXnQuec4lnbO+vLgeGPVOJljjdDHzLBE+GTlM+OtJBN48azVhZ3huOQELC0IChG7H+hGPU= X-Received: by 2002:a05:6512:3e26:b0:545:8a1:5381 with SMTP id 2adb3069b0e04-549abaaad1bmr4577748e87.11.1741865831485; Thu, 13 Mar 2025 04:37:11 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Thu, 13 Mar 2025 11:36:59 +0000 X-Gm-Features: AQ5f1JqAkCwi97LLLkYyYBsr9q79ocJyoa41_T0rAxekPQVzM-AXiFh-kXmCj0Q Message-ID: Subject: Re: Regarding feature #3319 To: Yogesh Mahajan Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000021f171063037becc" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --00000000000021f171063037becc Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi On Thu, 13 Mar 2025 at 11:35, Yogesh Mahajan < yogesh.mahajan@enterprisedb.com> wrote: > Hi Dave, > > What about the query tools opened with an ad-hoc server, should we just > open a query tool with data without connections? > Can we not save the connection parameters used in the JSON (excluding the password that we can prompt for of course)? > > Thanks, > Yogesh Mahajan > EnterpriseDB > > > On Thu, Mar 13, 2025 at 4:59=E2=80=AFPM Dave Page wro= te: > >> Hi >> >> On Thu, 13 Mar 2025 at 11:20, Yogesh Mahajan < >> yogesh.mahajan@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> Couple of follow up questions - >>> >>> Thanks, >>> Yogesh Mahajan >>> EnterpriseDB >>> >>> >>> On Thu, Mar 13, 2025 at 4:37=E2=80=AFPM Dave Page w= rote: >>> >>>> >>>> >>>> On Tue, 11 Mar 2025 at 08:31, Yogesh Mahajan < >>>> yogesh.mahajan@enterprisedb.com> wrote: >>>> >>>>> Hello Team, >>>>> >>>>> Couple of more questions arose during discussion - >>>>> >>>>> 1.What all tools should we reopen while restoration? It could be Quer= y >>>>> tool, ERD, Psql, Schema diff as of now may get additional in future. >>>>> >>>> >>>> Yes :-). Ideally, as much of the original state as possible should be >>>> restored. >>>> >>> >>> So, should we open the psql without data and schema diff without >>> comparison results? >>> >> >> I don't see that we have any choice for psql. We absolutely should *not* >> attempt to automatically re-run user queries. >> >> For the schema diff, yes, that could be very expensive. The user can >> press the button if they want to incur that cost. >> >> >>> Also for the query tools open with an ad-hoc server, should we just ope= n >>> a query tool with data without connections? >>> >>> >>>> >>>>> 2.Can we use an existing crypt key to encrypt the query data or simpl= y >>>>> json encoding should be enough? >>>>> >>>> >>>> We're already storing the query history, so we should follow the >>>> precedent there. >>>> >>> Currently we are storing this data with json encoding done by the >>> request module. >>> >>> >>>> -- >>>> Dave Page >>>> pgAdmin: https://www.pgadmin.org >>>> PostgreSQL: https://www.postgresql.org >>>> pgEdge: https://www.pgedge.com >>>> >>>> >> >> -- >> Dave Page >> pgAdmin: https://www.pgadmin.org >> PostgreSQL: https://www.postgresql.org >> pgEdge: https://www.pgedge.com >> >> --=20 Dave Page pgAdmin: https://www.pgadmin.org PostgreSQL: https://www.postgresql.org pgEdge: https://www.pgedge.com --00000000000021f171063037becc Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

On Thu, 13 Mar 2025 at 11:35,= Yogesh Mahajan <yoge= sh.mahajan@enterprisedb.com> wrote:
Hi Dave,

What about the query tools opened with an ad-hoc server, should=C2=A0we ju= st open a query tool with data without=C2=A0connections?

Can we not save the connection paramete= rs used in the JSON (excluding the password that we can prompt for of cours= e)?
=C2=A0

Thanks,
Yogesh Mahajan
EnterpriseDB


On Thu, Mar 13, 2025= at 4:59=E2=80=AFPM Dave Page <dpage@pgadmin.org> wrote:
=
Hi

On Thu, 13 Mar 2025 at 11:20, Yogesh Mahajan <yogesh.m= ahajan@enterprisedb.com> wrote:
Hi Dave,

Couple of follow up questions -=C2=A0

Thanks,
Yogesh Mahajan
EnterpriseDB


On Thu, Mar 13, 2025= at 4:37=E2=80=AFPM Dave Page <dpage@pgadmin.org> wrote:
=


=
On Tue, 11 Mar 2025 at 08:31, Yogesh = Mahajan <yogesh.mahajan@enterprisedb.com> wrote:
Hello Team,

Couple of more questions arose during discus= sion -=C2=A0

1.What all tools should we reopen while restoration? It could be Query to= ol, ERD, Psql, Schema diff as of now may get additional=C2=A0in future.

Yes :-). Ideally, as m= uch of the original state as possible should be restored.=C2=A0
=

So, should we open the psql without data and sche= ma diff without comparison results?

I don't see that we have any choice for psql. We absol= utely should *not* attempt to automatically re-run user queries.
=
For the schema diff, yes, that could be very expensive. The = user can press the button if they want to incur that cost.
=C2=A0=
Also for the que= ry tools open with an ad-hoc server, should=C2=A0we just open a query tool = with data without=C2=A0connections?

=C2=A0
2.Can we use an existing crypt key to encr= ypt the query data or simply json encoding should be enough?

We're already storing the que= ry history, so we should follow the precedent there.
Currently we are storing this data with json encod= ing done by the request=C2=A0module.


--
<= /div>


--


--
--00000000000021f171063037becc--